[INFO] updating cached repository kirjavascript/wasm-string [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kirjavascript/wasm-string [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kirjavascript/wasm-string" "work/ex/clippy-test-run/sources/stable/gh/kirjavascript/wasm-string"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirjavascript/wasm-string'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kirjavascript/wasm-string" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/wasm-string"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/wasm-string'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0b936631d7b74cef95f40b91246b609e7b11ce4 [INFO] sha for GitHub repo kirjavascript/wasm-string: e0b936631d7b74cef95f40b91246b609e7b11ce4 [INFO] validating manifest of kirjavascript/wasm-string on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kirjavascript/wasm-string on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kirjavascript/wasm-string [INFO] finished frobbing kirjavascript/wasm-string [INFO] frobbed toml for kirjavascript/wasm-string written to work/ex/clippy-test-run/sources/stable/gh/kirjavascript/wasm-string/Cargo.toml [INFO] started frobbing kirjavascript/wasm-string [INFO] finished frobbing kirjavascript/wasm-string [INFO] frobbed toml for kirjavascript/wasm-string written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/wasm-string/Cargo.toml [INFO] crate kirjavascript/wasm-string has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kirjavascript/wasm-string against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/wasm-string:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 005864afdb941f07b908a68527e9d03fd16bb8f6629673a91a41f31e66146387 [INFO] running `"docker" "start" "-a" "005864afdb941f07b908a68527e9d03fd16bb8f6629673a91a41f31e66146387"` [INFO] [stderr] Checking wasm-demo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `string` [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn console_log(string: &str) { [INFO] [stderr] | ^^^^^^ help: consider using `_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `console_log_stack` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn console_log_stack(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 18 | let mut d = Vec::with_capacity(cap); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; cap]` [INFO] [stderr] 19 | d.set_len(cap); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string` [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn console_log(string: &str) { [INFO] [stderr] | ^^^^^^ help: consider using `_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_owned(&mut self) -> Box { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `console_log_stack` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn console_log_stack(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:57:40 [INFO] [stderr] | [INFO] [stderr] 57 | unsafe { let _ = CString::from_raw(ptr); } [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 18 | let mut d = Vec::with_capacity(cap); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; cap]` [INFO] [stderr] 19 | d.set_len(cap); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_owned(&mut self) -> Box { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:57:40 [INFO] [stderr] | [INFO] [stderr] 57 | unsafe { let _ = CString::from_raw(ptr); } [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-demo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-demo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "005864afdb941f07b908a68527e9d03fd16bb8f6629673a91a41f31e66146387"` [INFO] running `"docker" "rm" "-f" "005864afdb941f07b908a68527e9d03fd16bb8f6629673a91a41f31e66146387"` [INFO] [stdout] 005864afdb941f07b908a68527e9d03fd16bb8f6629673a91a41f31e66146387