[INFO] updating cached repository kirhgoff/rust_utils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kirhgoff/rust_utils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kirhgoff/rust_utils" "work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust_utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust_utils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kirhgoff/rust_utils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust_utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust_utils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 662711b2e94f72c8636ca70fec98487260cb7a94 [INFO] sha for GitHub repo kirhgoff/rust_utils: 662711b2e94f72c8636ca70fec98487260cb7a94 [INFO] validating manifest of kirhgoff/rust_utils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kirhgoff/rust_utils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kirhgoff/rust_utils [INFO] finished frobbing kirhgoff/rust_utils [INFO] frobbed toml for kirhgoff/rust_utils written to work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust_utils/Cargo.toml [INFO] started frobbing kirhgoff/rust_utils [INFO] finished frobbing kirhgoff/rust_utils [INFO] frobbed toml for kirhgoff/rust_utils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust_utils/Cargo.toml [INFO] crate kirhgoff/rust_utils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kirhgoff/rust_utils against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust_utils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8d3313f2b2dcd9cf8a05416f1e83cfb38f584479a5f0504925bc8316f3982094 [INFO] running `"docker" "start" "-a" "8d3313f2b2dcd9cf8a05416f1e83cfb38f584479a5f0504925bc8316f3982094"` [INFO] [stderr] Checking hamming v0.1.3 [INFO] [stderr] Checking smallvec v0.4.4 [INFO] [stderr] Checking primal-estimate v0.2.1 [INFO] [stderr] Checking primal-check v0.2.3 [INFO] [stderr] Checking num-bigint v0.1.41 [INFO] [stderr] Checking primal-bit v0.2.4 [INFO] [stderr] Checking primal-sieve v0.2.8 [INFO] [stderr] Checking num-rational v0.1.41 [INFO] [stderr] Checking primal v0.2.3 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking fraction v0.3.7 [INFO] [stderr] Checking rust_utils v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/mod.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | DigitsGenerator { number: number, base: base } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/mod.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | DigitsGenerator { number: number, base: base } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/mod.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | DigitsGenerator { number: number, base: base } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/mod.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | DigitsGenerator { number: number, base: base } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(digit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(digit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | return DigitsGenerator::decimal(number).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DigitsGenerator::decimal(number).collect::>()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | return DigitsGenerator::binary(number).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DigitsGenerator::binary(number).collect::>()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | return binary_digits(number).iter().rev().map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `binary_digits(number).iter().rev().map(|x| x.to_string()).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | return (number as f64).log10().abs() as u64 + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(number as f64).log10().abs() as u64 + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | assert!(!is_pandigital(145678999)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `145_678_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | assert!(is_pandigital(123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(digit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(digit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | return DigitsGenerator::decimal(number).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DigitsGenerator::decimal(number).collect::>()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | return DigitsGenerator::binary(number).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DigitsGenerator::binary(number).collect::>()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | return binary_digits(number).iter().rev().map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `binary_digits(number).iter().rev().map(|x| x.to_string()).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | return (number as f64).log10().abs() as u64 + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(number as f64).log10().abs() as u64 + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/mod.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/euler36.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | let result = (0 as u64 .. 1000000 as u64) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/euler36.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | let result = (0 as u64 .. 1000000 as u64) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/euler38.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(192384576, concatenated_product(192, 3)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `192_384_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/euler38.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(918273645, concatenated_product(9, 5)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `918_273_645` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/euler33.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(big - small).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/euler33.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/euler33.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(big - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/euler33.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler38.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | (1..max_multiplier + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=max_multiplier)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler38.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | for x in 0..10_000+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=10_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler38.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | for y in 0..multipliers_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=multipliers_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/euler39.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match hypothenuse(a, b) { [INFO] [stderr] 40 | | Some(c) => { [INFO] [stderr] 41 | | hash_map [INFO] [stderr] 42 | | .entry(a + b + c).or_insert(vec![]) [INFO] [stderr] ... | [INFO] [stderr] 45 | | None => { } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | if let Some(c) = hypothenuse(a, b) { [INFO] [stderr] 40 | hash_map [INFO] [stderr] 41 | .entry(a + b + c).or_insert(vec![]) [INFO] [stderr] 42 | .push((a, b, c)); [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/euler39.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | .entry(a + b + c).or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_utils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/euler33.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(big - small).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/euler33.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/euler33.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(big - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/euler33.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | if big == small && big != 1.0 && big != 0.0 && !big.is_infinite() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler38.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | (1..max_multiplier + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=max_multiplier)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler38.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | for x in 0..10_000+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=10_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler38.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | for y in 0..multipliers_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=multipliers_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/euler39.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match hypothenuse(a, b) { [INFO] [stderr] 40 | | Some(c) => { [INFO] [stderr] 41 | | hash_map [INFO] [stderr] 42 | | .entry(a + b + c).or_insert(vec![]) [INFO] [stderr] ... | [INFO] [stderr] 45 | | None => { } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | if let Some(c) = hypothenuse(a, b) { [INFO] [stderr] 40 | hash_map [INFO] [stderr] 41 | .entry(a + b + c).or_insert(vec![]) [INFO] [stderr] 42 | .push((a, b, c)); [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/euler39.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | .entry(a + b + c).or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_utils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8d3313f2b2dcd9cf8a05416f1e83cfb38f584479a5f0504925bc8316f3982094"` [INFO] running `"docker" "rm" "-f" "8d3313f2b2dcd9cf8a05416f1e83cfb38f584479a5f0504925bc8316f3982094"` [INFO] [stdout] 8d3313f2b2dcd9cf8a05416f1e83cfb38f584479a5f0504925bc8316f3982094