[INFO] updating cached repository kilork/google-codejam-2018-saving-the-universe-again [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kilork/google-codejam-2018-saving-the-universe-again [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kilork/google-codejam-2018-saving-the-universe-again" "work/ex/clippy-test-run/sources/stable/gh/kilork/google-codejam-2018-saving-the-universe-again"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kilork/google-codejam-2018-saving-the-universe-again'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kilork/google-codejam-2018-saving-the-universe-again" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kilork/google-codejam-2018-saving-the-universe-again"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kilork/google-codejam-2018-saving-the-universe-again'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a79d07a407810271c469ec0d708fcd0bc49c709 [INFO] sha for GitHub repo kilork/google-codejam-2018-saving-the-universe-again: 6a79d07a407810271c469ec0d708fcd0bc49c709 [INFO] validating manifest of kilork/google-codejam-2018-saving-the-universe-again on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kilork/google-codejam-2018-saving-the-universe-again on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kilork/google-codejam-2018-saving-the-universe-again [INFO] finished frobbing kilork/google-codejam-2018-saving-the-universe-again [INFO] frobbed toml for kilork/google-codejam-2018-saving-the-universe-again written to work/ex/clippy-test-run/sources/stable/gh/kilork/google-codejam-2018-saving-the-universe-again/Cargo.toml [INFO] started frobbing kilork/google-codejam-2018-saving-the-universe-again [INFO] finished frobbing kilork/google-codejam-2018-saving-the-universe-again [INFO] frobbed toml for kilork/google-codejam-2018-saving-the-universe-again written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kilork/google-codejam-2018-saving-the-universe-again/Cargo.toml [INFO] crate kilork/google-codejam-2018-saving-the-universe-again has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kilork/google-codejam-2018-saving-the-universe-again against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kilork/google-codejam-2018-saving-the-universe-again:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c19921ff4b28671ad6f2e0ffa1abf806c67873fe311148ee0dcb1d45d09b85e [INFO] running `"docker" "start" "-a" "8c19921ff4b28671ad6f2e0ffa1abf806c67873fe311148ee0dcb1d45d09b85e"` [INFO] [stderr] Checking saving-the-universe-again v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | for case in 1..cases_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=cases_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &Hack::Impossible => write!(f, "IMPOSSIBLE"), [INFO] [stderr] 35 | | &Hack::SwapsCount(count) => write!(f, "{}", count), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | Hack::Impossible => write!(f, "IMPOSSIBLE"), [INFO] [stderr] 35 | Hack::SwapsCount(count) => write!(f, "{}", count), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | program.iter().for_each(|x| match x { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 51 | | &ProgramStatement::Shot => damage += hit, [INFO] [stderr] 52 | | &ProgramStatement::Charge => hit *= 2, [INFO] [stderr] 53 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | program.iter().for_each(|x| match *x { [INFO] [stderr] 51 | ProgramStatement::Shot => damage += hit, [INFO] [stderr] 52 | ProgramStatement::Charge => hit *= 2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | for case in 1..cases_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=cases_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &Hack::Impossible => write!(f, "IMPOSSIBLE"), [INFO] [stderr] 35 | | &Hack::SwapsCount(count) => write!(f, "{}", count), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | Hack::Impossible => write!(f, "IMPOSSIBLE"), [INFO] [stderr] 35 | Hack::SwapsCount(count) => write!(f, "{}", count), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | program.iter().for_each(|x| match x { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 51 | | &ProgramStatement::Shot => damage += hit, [INFO] [stderr] 52 | | &ProgramStatement::Charge => hit *= 2, [INFO] [stderr] 53 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | program.iter().for_each(|x| match *x { [INFO] [stderr] 51 | ProgramStatement::Shot => damage += hit, [INFO] [stderr] 52 | ProgramStatement::Charge => hit *= 2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "8c19921ff4b28671ad6f2e0ffa1abf806c67873fe311148ee0dcb1d45d09b85e"` [INFO] running `"docker" "rm" "-f" "8c19921ff4b28671ad6f2e0ffa1abf806c67873fe311148ee0dcb1d45d09b85e"` [INFO] [stdout] 8c19921ff4b28671ad6f2e0ffa1abf806c67873fe311148ee0dcb1d45d09b85e