[INFO] updating cached repository kettlekat/oiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kettlekat/oiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kettlekat/oiler" "work/ex/clippy-test-run/sources/stable/gh/kettlekat/oiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kettlekat/oiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kettlekat/oiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kettlekat/oiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kettlekat/oiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b2b00538a1c13db3eebea6fb026b2771e3a477c [INFO] sha for GitHub repo kettlekat/oiler: 0b2b00538a1c13db3eebea6fb026b2771e3a477c [INFO] validating manifest of kettlekat/oiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kettlekat/oiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kettlekat/oiler [INFO] finished frobbing kettlekat/oiler [INFO] frobbed toml for kettlekat/oiler written to work/ex/clippy-test-run/sources/stable/gh/kettlekat/oiler/Cargo.toml [INFO] started frobbing kettlekat/oiler [INFO] finished frobbing kettlekat/oiler [INFO] frobbed toml for kettlekat/oiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kettlekat/oiler/Cargo.toml [INFO] crate kettlekat/oiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kettlekat/oiler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kettlekat/oiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b72fc923358e04fc90743077002a2c126f1eb87673f52ca1771e83fc1ad50786 [INFO] running `"docker" "start" "-a" "b72fc923358e04fc90743077002a2c126f1eb87673f52ca1771e83fc1ad50786"` [INFO] [stderr] Checking num-integer v0.1.33 [INFO] [stderr] Checking num-complex v0.1.36 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking oiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `util` [INFO] [stderr] warning: unused import: `util` [INFO] [stderr] --> src/series/fibonacci.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use util; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/series/primes.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] --> src/series/fibonacci.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use util; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/series/primes.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Range` [INFO] [stderr] --> src/util.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub struct Range(pub T, pub T, pub T) [INFO] [stderr] 29 | | where for<'a> &'a T: Add<&'a T, Output = T>, [INFO] [stderr] 30 | | T: PartialOrd, [INFO] [stderr] 31 | | T: Clone; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Fibonacci` [INFO] [stderr] --> src/series/fibonacci.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub struct Fibonacci { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/series/fibonacci.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new() -> Fibonacci { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/series/fibonacci.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/series/primes.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | for x in 2..(n/2)+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=(n/2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Range` [INFO] [stderr] --> src/util.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub struct Range(pub T, pub T, pub T) [INFO] [stderr] 29 | | where for<'a> &'a T: Add<&'a T, Output = T>, [INFO] [stderr] 30 | | T: PartialOrd, [INFO] [stderr] 31 | | T: Clone; [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Fibonacci` [INFO] [stderr] --> src/series/fibonacci.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub struct Fibonacci { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/series/fibonacci.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new() -> Fibonacci { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/series/fibonacci.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/series/primes.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | for x in 2..(n/2)+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=(n/2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.50s [INFO] running `"docker" "inspect" "b72fc923358e04fc90743077002a2c126f1eb87673f52ca1771e83fc1ad50786"` [INFO] running `"docker" "rm" "-f" "b72fc923358e04fc90743077002a2c126f1eb87673f52ca1771e83fc1ad50786"` [INFO] [stdout] b72fc923358e04fc90743077002a2c126f1eb87673f52ca1771e83fc1ad50786