[INFO] updating cached repository kenan-rhoton/stak [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kenan-rhoton/stak [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kenan-rhoton/stak" "work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/stak"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/stak'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kenan-rhoton/stak" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/stak"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/stak'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c98d4fc566595b5c32e3d482415c79539c3a77d [INFO] sha for GitHub repo kenan-rhoton/stak: 7c98d4fc566595b5c32e3d482415c79539c3a77d [INFO] validating manifest of kenan-rhoton/stak on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kenan-rhoton/stak on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kenan-rhoton/stak [INFO] finished frobbing kenan-rhoton/stak [INFO] frobbed toml for kenan-rhoton/stak written to work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/stak/Cargo.toml [INFO] started frobbing kenan-rhoton/stak [INFO] finished frobbing kenan-rhoton/stak [INFO] frobbed toml for kenan-rhoton/stak written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/stak/Cargo.toml [INFO] crate kenan-rhoton/stak has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kenan-rhoton/stak against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/stak:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a949a2eb2ac0421e88755504b541bdfbdde04662d5d26b9bf9e0ae7f77437e01 [INFO] running `"docker" "start" "-a" "a949a2eb2ac0421e88755504b541bdfbdde04662d5d26b9bf9e0ae7f77437e01"` [INFO] [stderr] Checking stak v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn append_data(new_line: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn append_data(new_line: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.49s [INFO] running `"docker" "inspect" "a949a2eb2ac0421e88755504b541bdfbdde04662d5d26b9bf9e0ae7f77437e01"` [INFO] running `"docker" "rm" "-f" "a949a2eb2ac0421e88755504b541bdfbdde04662d5d26b9bf9e0ae7f77437e01"` [INFO] [stdout] a949a2eb2ac0421e88755504b541bdfbdde04662d5d26b9bf9e0ae7f77437e01