[INFO] updating cached repository kenan-rhoton/roll [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kenan-rhoton/roll [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kenan-rhoton/roll" "work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/roll"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/roll'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kenan-rhoton/roll" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/roll"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/roll'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5117c47f4f2b0dba6bada1c331d2a2f642375784 [INFO] sha for GitHub repo kenan-rhoton/roll: 5117c47f4f2b0dba6bada1c331d2a2f642375784 [INFO] validating manifest of kenan-rhoton/roll on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kenan-rhoton/roll on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kenan-rhoton/roll [INFO] finished frobbing kenan-rhoton/roll [INFO] frobbed toml for kenan-rhoton/roll written to work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/roll/Cargo.toml [INFO] started frobbing kenan-rhoton/roll [INFO] finished frobbing kenan-rhoton/roll [INFO] frobbed toml for kenan-rhoton/roll written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/roll/Cargo.toml [INFO] crate kenan-rhoton/roll has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kenan-rhoton/roll against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/roll:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bc691091961a9bb033ccf7de9c3d2e5e8f162686a3c98333deb2d00aeee9d46 [INFO] running `"docker" "start" "-a" "7bc691091961a9bb033ccf7de9c3d2e5e8f162686a3c98333deb2d00aeee9d46"` [INFO] [stderr] Checking roll v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | fn roll_kind(kind: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | fn roll(expression: &String) -> Roll { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | let split: Vec = expression.split("d").map(|x| x.to_string()).filter(|x| !x.is_empty()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'d'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | fn roll_kind(kind: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | fn roll(expression: &String) -> Roll { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | let split: Vec = expression.split("d").map(|x| x.to_string()).filter(|x| !x.is_empty()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'d'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "7bc691091961a9bb033ccf7de9c3d2e5e8f162686a3c98333deb2d00aeee9d46"` [INFO] running `"docker" "rm" "-f" "7bc691091961a9bb033ccf7de9c3d2e5e8f162686a3c98333deb2d00aeee9d46"` [INFO] [stdout] 7bc691091961a9bb033ccf7de9c3d2e5e8f162686a3c98333deb2d00aeee9d46