[INFO] updating cached repository keatinge/rust-html-parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/keatinge/rust-html-parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/keatinge/rust-html-parser" "work/ex/clippy-test-run/sources/stable/gh/keatinge/rust-html-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/keatinge/rust-html-parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/keatinge/rust-html-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keatinge/rust-html-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keatinge/rust-html-parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 14a9d43b776bbce0f4a98ac3c3d3761150bf66cb [INFO] sha for GitHub repo keatinge/rust-html-parser: 14a9d43b776bbce0f4a98ac3c3d3761150bf66cb [INFO] validating manifest of keatinge/rust-html-parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of keatinge/rust-html-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing keatinge/rust-html-parser [INFO] finished frobbing keatinge/rust-html-parser [INFO] frobbed toml for keatinge/rust-html-parser written to work/ex/clippy-test-run/sources/stable/gh/keatinge/rust-html-parser/Cargo.toml [INFO] started frobbing keatinge/rust-html-parser [INFO] finished frobbing keatinge/rust-html-parser [INFO] frobbed toml for keatinge/rust-html-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keatinge/rust-html-parser/Cargo.toml [INFO] crate keatinge/rust-html-parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting keatinge/rust-html-parser against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keatinge/rust-html-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34f9d5e85425dc46860247df856ca19e8e48e4cf504782223b19b30553b51557 [INFO] running `"docker" "start" "-a" "34f9d5e85425dc46860247df856ca19e8e48e4cf504782223b19b30553b51557"` [INFO] [stderr] Checking html_parser_f v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | write!(f, "{}<{}>\n", indent_str, el.tag_data.name)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:307:49 [INFO] [stderr] | [INFO] [stderr] 307 | HtmlNode::El(Element {tag_data: td, children: children, token_count: 1_usize}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:49 [INFO] [stderr] | [INFO] [stderr] 310 | HtmlNode::El(Element {tag_data: td, children: children, token_count: 2_usize}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:329:50 [INFO] [stderr] | [INFO] [stderr] 329 | HtmlNode::El(Element {tag_data: &td, children: children, token_count: tokens_used}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | write!(f, "{}<{}>\n", indent_str, el.tag_data.name)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:307:49 [INFO] [stderr] | [INFO] [stderr] 307 | HtmlNode::El(Element {tag_data: td, children: children, token_count: 1_usize}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:49 [INFO] [stderr] | [INFO] [stderr] 310 | HtmlNode::El(Element {tag_data: td, children: children, token_count: 2_usize}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:329:50 [INFO] [stderr] | [INFO] [stderr] 329 | HtmlNode::El(Element {tag_data: &td, children: children, token_count: tokens_used}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | if el.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!el.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | assert!(!name.contains("/")); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match self { [INFO] [stderr] 95 | | &Token::VoidTag(ref td) => write!(f, "", td), [INFO] [stderr] 96 | | &Token::OpenTag(ref td) => write!(f, "", td), [INFO] [stderr] 97 | | &Token::CloseTag(ref td) => write!(f, "", td), [INFO] [stderr] 98 | | &Token::Text(ref td) => write!(f, "{:?}", td) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | match *self { [INFO] [stderr] 95 | Token::VoidTag(ref td) => write!(f, "", td), [INFO] [stderr] 96 | Token::OpenTag(ref td) => write!(f, "", td), [INFO] [stderr] 97 | Token::CloseTag(ref td) => write!(f, "", td), [INFO] [stderr] 98 | Token::Text(ref td) => write!(f, "{:?}", td) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / fn to_str<'a>(data:&'a[u8]) -> &'a str { [INFO] [stderr] 111 | | ::std::str::from_utf8(&data).unwrap() [INFO] [stderr] 112 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:135:38 [INFO] [stderr] | [INFO] [stderr] 135 | if tok_text.as_bytes()[0] != '<' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:108 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:162 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'>' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:216 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:269 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:146:51 [INFO] [stderr] | [INFO] [stderr] 146 | if tok_text.as_bytes()[name_end_chr_i] == '/' as u8 || is_void_tag_name(to_str(&tok_text.as_bytes()[1..name_end_chr_i])){ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:154:43 [INFO] [stderr] | [INFO] [stderr] 154 | else if tok_text.as_bytes()[1] == '/' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn from_str(s: &'a str) -> Token<'a> { [INFO] [stderr] 170 | | Token::from_str_checked(s).expect("Called from_str on an invalid token") [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | while !(bytes[closing_bracket_i] == '>' as u8 && !inside_a_string){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inside_a_string || bytes[closing_bracket_i] != '>' as u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:40 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:78 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:117 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:156 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\t' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:250:49 [INFO] [stderr] | [INFO] [stderr] 250 | while !(bytes[closing_bracket_i] == '>' as u8 && !inside_a_string){ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'>' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:252:68 [INFO] [stderr] | [INFO] [stderr] 252 | if !inside_a_string && bytes[closing_bracket_i] == '<' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:258:48 [INFO] [stderr] | [INFO] [stderr] 258 | if bytes[closing_bracket_i] == '"' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'"' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:266:70 [INFO] [stderr] | [INFO] [stderr] 266 | if let Some(tok) = Token::from_str_checked(to_str(&bytes[first_non_ws_i..(closing_bracket_i + 1)])) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first_non_ws_i..=closing_bracket_i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:274:52 [INFO] [stderr] | [INFO] [stderr] 274 | while bytes[next_opening_bracket_i] != '<' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | if el.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!el.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | assert!(!name.contains("/")); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match self { [INFO] [stderr] 95 | | &Token::VoidTag(ref td) => write!(f, "", td), [INFO] [stderr] 96 | | &Token::OpenTag(ref td) => write!(f, "", td), [INFO] [stderr] 97 | | &Token::CloseTag(ref td) => write!(f, "", td), [INFO] [stderr] 98 | | &Token::Text(ref td) => write!(f, "{:?}", td) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | match *self { [INFO] [stderr] 95 | Token::VoidTag(ref td) => write!(f, "", td), [INFO] [stderr] 96 | Token::OpenTag(ref td) => write!(f, "", td), [INFO] [stderr] 97 | Token::CloseTag(ref td) => write!(f, "", td), [INFO] [stderr] 98 | Token::Text(ref td) => write!(f, "{:?}", td) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / fn to_str<'a>(data:&'a[u8]) -> &'a str { [INFO] [stderr] 111 | | ::std::str::from_utf8(&data).unwrap() [INFO] [stderr] 112 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:135:38 [INFO] [stderr] | [INFO] [stderr] 135 | if tok_text.as_bytes()[0] != '<' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:108 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:162 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'>' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:216 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:141:269 [INFO] [stderr] | [INFO] [stderr] 141 | while tok_text.as_bytes()[name_end_chr_i] != (' ' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('/' as u8) && tok_text.as_bytes()[name_end_chr_i] != ('>' as u8) && tok_text.as_bytes()[name_end_chr_i] != '\n' as u8 && tok_text.as_bytes()[name_end_chr_i] != '\r' as u8{ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:146:51 [INFO] [stderr] | [INFO] [stderr] 146 | if tok_text.as_bytes()[name_end_chr_i] == '/' as u8 || is_void_tag_name(to_str(&tok_text.as_bytes()[1..name_end_chr_i])){ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:154:43 [INFO] [stderr] | [INFO] [stderr] 154 | else if tok_text.as_bytes()[1] == '/' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn from_str(s: &'a str) -> Token<'a> { [INFO] [stderr] 170 | | Token::from_str_checked(s).expect("Called from_str on an invalid token") [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | while !(bytes[closing_bracket_i] == '>' as u8 && !inside_a_string){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inside_a_string || bytes[closing_bracket_i] != '>' as u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:40 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:78 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:117 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:226:156 [INFO] [stderr] | [INFO] [stderr] 226 | while bytes[first_non_ws_i] == ' ' as u8 || bytes[first_non_ws_i] == '\n' as u8 || bytes[first_non_ws_i] == '\r' as u8 || bytes[first_non_ws_i] == '\t' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\t' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:250:49 [INFO] [stderr] | [INFO] [stderr] 250 | while !(bytes[closing_bracket_i] == '>' as u8 && !inside_a_string){ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'>' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:252:68 [INFO] [stderr] | [INFO] [stderr] 252 | if !inside_a_string && bytes[closing_bracket_i] == '<' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:258:48 [INFO] [stderr] | [INFO] [stderr] 258 | if bytes[closing_bracket_i] == '"' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'"' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:266:70 [INFO] [stderr] | [INFO] [stderr] 266 | if let Some(tok) = Token::from_str_checked(to_str(&bytes[first_non_ws_i..(closing_bracket_i + 1)])) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first_non_ws_i..=closing_bracket_i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:274:52 [INFO] [stderr] | [INFO] [stderr] 274 | while bytes[next_opening_bracket_i] != '<' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benchmarks.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `html_parser_f`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "34f9d5e85425dc46860247df856ca19e8e48e4cf504782223b19b30553b51557"` [INFO] running `"docker" "rm" "-f" "34f9d5e85425dc46860247df856ca19e8e48e4cf504782223b19b30553b51557"` [INFO] [stdout] 34f9d5e85425dc46860247df856ca19e8e48e4cf504782223b19b30553b51557