[INFO] updating cached repository kcotugno/urlify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kcotugno/urlify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kcotugno/urlify" "work/ex/clippy-test-run/sources/stable/gh/kcotugno/urlify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kcotugno/urlify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kcotugno/urlify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/urlify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/urlify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee25553b992240317ec77cce67e4c0e67c5815fa [INFO] sha for GitHub repo kcotugno/urlify: ee25553b992240317ec77cce67e4c0e67c5815fa [INFO] validating manifest of kcotugno/urlify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kcotugno/urlify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kcotugno/urlify [INFO] finished frobbing kcotugno/urlify [INFO] frobbed toml for kcotugno/urlify written to work/ex/clippy-test-run/sources/stable/gh/kcotugno/urlify/Cargo.toml [INFO] started frobbing kcotugno/urlify [INFO] finished frobbing kcotugno/urlify [INFO] frobbed toml for kcotugno/urlify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/urlify/Cargo.toml [INFO] crate kcotugno/urlify has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kcotugno/urlify against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/urlify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4ce19b6feda75ec2a4b0a4d6f3b1a2917906d0deaf6b1d62bc1ee185a9ef80b [INFO] running `"docker" "start" "-a" "c4ce19b6feda75ec2a4b0a4d6f3b1a2917906d0deaf6b1d62bc1ee185a9ef80b"` [INFO] [stderr] Checking urlify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 40 | | if u < 0x10 { [INFO] [stderr] 41 | | encoded.push_str(format!("%0{:X}", u).as_str()); [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | encoded.push_str(format!("%{:X}", u).as_str()); [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if u < 0x10 { [INFO] [stderr] 40 | encoded.push_str(format!("%0{:X}", u).as_str()); [INFO] [stderr] 41 | } else { [INFO] [stderr] 42 | encoded.push_str(format!("%{:X}", u).as_str()); [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 40 | | if u < 0x10 { [INFO] [stderr] 41 | | encoded.push_str(format!("%0{:X}", u).as_str()); [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | encoded.push_str(format!("%{:X}", u).as_str()); [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if u < 0x10 { [INFO] [stderr] 40 | encoded.push_str(format!("%0{:X}", u).as_str()); [INFO] [stderr] 41 | } else { [INFO] [stderr] 42 | encoded.push_str(format!("%{:X}", u).as_str()); [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "c4ce19b6feda75ec2a4b0a4d6f3b1a2917906d0deaf6b1d62bc1ee185a9ef80b"` [INFO] running `"docker" "rm" "-f" "c4ce19b6feda75ec2a4b0a4d6f3b1a2917906d0deaf6b1d62bc1ee185a9ef80b"` [INFO] [stdout] c4ce19b6feda75ec2a4b0a4d6f3b1a2917906d0deaf6b1d62bc1ee185a9ef80b