[INFO] updating cached repository kballard/flip-text.alfredworkflow [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kballard/flip-text.alfredworkflow [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kballard/flip-text.alfredworkflow" "work/ex/clippy-test-run/sources/stable/gh/kballard/flip-text.alfredworkflow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kballard/flip-text.alfredworkflow'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kballard/flip-text.alfredworkflow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kballard/flip-text.alfredworkflow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kballard/flip-text.alfredworkflow'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 48b5ea74b5733bf6cb4aac5a8dff11b3f2e34dba [INFO] sha for GitHub repo kballard/flip-text.alfredworkflow: 48b5ea74b5733bf6cb4aac5a8dff11b3f2e34dba [INFO] validating manifest of kballard/flip-text.alfredworkflow on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kballard/flip-text.alfredworkflow on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kballard/flip-text.alfredworkflow [INFO] finished frobbing kballard/flip-text.alfredworkflow [INFO] frobbed toml for kballard/flip-text.alfredworkflow written to work/ex/clippy-test-run/sources/stable/gh/kballard/flip-text.alfredworkflow/Cargo.toml [INFO] started frobbing kballard/flip-text.alfredworkflow [INFO] finished frobbing kballard/flip-text.alfredworkflow [INFO] frobbed toml for kballard/flip-text.alfredworkflow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kballard/flip-text.alfredworkflow/Cargo.toml [INFO] crate kballard/flip-text.alfredworkflow has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kballard/flip-text.alfredworkflow against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kballard/flip-text.alfredworkflow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a58b438be63beb2368e324940c81d9f254148048964df56b74c0dee7b91be75 [INFO] running `"docker" "start" "-a" "4a58b438be63beb2368e324940c81d9f254148048964df56b74c0dee7b91be75"` [INFO] [stderr] Checking serde v1.0.11 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking alfred v4.0.0 [INFO] [stderr] Checking flip-text v1.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/flip.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | pub const FLIP_PREFIX: &'static str = "(╯°□°）╯︵"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/flip.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | pub const UNFLIP_SUFFIX: &'static str = "ノ( º _ ºノ)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/flip.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | pub const FLIP_PREFIX: &'static str = "(╯°□°）╯︵"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/flip.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | pub const UNFLIP_SUFFIX: &'static str = "ノ( º _ ºノ)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flip.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Operation::Flip(ref s) => write!(f, "{} {}", FLIP_PREFIX, s), [INFO] [stderr] 20 | | &Operation::Unflip(ref s) => write!(f, "{} {}", s, UNFLIP_SUFFIX) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Operation::Flip(ref s) => write!(f, "{} {}", FLIP_PREFIX, s), [INFO] [stderr] 20 | Operation::Unflip(ref s) => write!(f, "{} {}", s, UNFLIP_SUFFIX) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/flip.rs:93:11 [INFO] [stderr] | [INFO] [stderr] 93 | ].into_iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flip.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Operation::Flip(ref s) => write!(f, "{} {}", FLIP_PREFIX, s), [INFO] [stderr] 20 | | &Operation::Unflip(ref s) => write!(f, "{} {}", s, UNFLIP_SUFFIX) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Operation::Flip(ref s) => write!(f, "{} {}", FLIP_PREFIX, s), [INFO] [stderr] 20 | Operation::Unflip(ref s) => write!(f, "{} {}", s, UNFLIP_SUFFIX) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/flip.rs:96:66 [INFO] [stderr] | [INFO] [stderr] 96 | let mut map = [('ƃ', 'g'), ('ʃ', 'l'), ('\u{5DF}', 'l')].into_iter().cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | let arg = env::args().skip(1).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match process_argument(arg.as_ref().map_or("", |s| &s[..])) { [INFO] [stderr] 16 | | Err(err) => { [INFO] [stderr] 17 | | let _ = writeln!(&mut io::stderr(), "I/O error: {}", err); [INFO] [stderr] 18 | | exit(1); [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Err(err) = process_argument(arg.as_ref().map_or("", |s| &s[..])) { [INFO] [stderr] 16 | let _ = writeln!(&mut io::stderr(), "I/O error: {}", err); [INFO] [stderr] 17 | exit(1); [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/flip.rs:93:11 [INFO] [stderr] | [INFO] [stderr] 93 | ].into_iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/flip.rs:96:66 [INFO] [stderr] | [INFO] [stderr] 96 | let mut map = [('ƃ', 'g'), ('ʃ', 'l'), ('\u{5DF}', 'l')].into_iter().cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | let arg = env::args().skip(1).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match process_argument(arg.as_ref().map_or("", |s| &s[..])) { [INFO] [stderr] 16 | | Err(err) => { [INFO] [stderr] 17 | | let _ = writeln!(&mut io::stderr(), "I/O error: {}", err); [INFO] [stderr] 18 | | exit(1); [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Err(err) = process_argument(arg.as_ref().map_or("", |s| &s[..])) { [INFO] [stderr] 16 | let _ = writeln!(&mut io::stderr(), "I/O error: {}", err); [INFO] [stderr] 17 | exit(1); [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flip-text`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flip-text`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4a58b438be63beb2368e324940c81d9f254148048964df56b74c0dee7b91be75"` [INFO] running `"docker" "rm" "-f" "4a58b438be63beb2368e324940c81d9f254148048964df56b74c0dee7b91be75"` [INFO] [stdout] 4a58b438be63beb2368e324940c81d9f254148048964df56b74c0dee7b91be75