[INFO] updating cached repository kbacha/shuffle-simple-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kbacha/shuffle-simple-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kbacha/shuffle-simple-rs" "work/ex/clippy-test-run/sources/stable/gh/kbacha/shuffle-simple-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kbacha/shuffle-simple-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kbacha/shuffle-simple-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/shuffle-simple-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/shuffle-simple-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c79d0b9e542e3d33d946ec43bd224bebd8e24d4 [INFO] sha for GitHub repo kbacha/shuffle-simple-rs: 0c79d0b9e542e3d33d946ec43bd224bebd8e24d4 [INFO] validating manifest of kbacha/shuffle-simple-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kbacha/shuffle-simple-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kbacha/shuffle-simple-rs [INFO] finished frobbing kbacha/shuffle-simple-rs [INFO] frobbed toml for kbacha/shuffle-simple-rs written to work/ex/clippy-test-run/sources/stable/gh/kbacha/shuffle-simple-rs/Cargo.toml [INFO] started frobbing kbacha/shuffle-simple-rs [INFO] finished frobbing kbacha/shuffle-simple-rs [INFO] frobbed toml for kbacha/shuffle-simple-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/shuffle-simple-rs/Cargo.toml [INFO] crate kbacha/shuffle-simple-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kbacha/shuffle-simple-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/shuffle-simple-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9290acaff16c32030ff997331a48300beb11bb6c0fba78e968ff02462b5014bf [INFO] running `"docker" "start" "-a" "9290acaff16c32030ff997331a48300beb11bb6c0fba78e968ff02462b5014bf"` [INFO] [stderr] Checking shuffle-simple-deck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping elements of `deck` manually [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / let swap = deck[i]; [INFO] [stderr] 12 | | deck[i] = deck[j]; [INFO] [stderr] 13 | | deck[j] = swap; [INFO] [stderr] | |______________________^ help: try: `deck.swap(i, j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:65 [INFO] [stderr] | [INFO] [stderr] 50 | 1_000 * shuffles / (elapsed.as_secs() * 1_000 + elapsed.subsec_millis() as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `deck` manually [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / let swap = deck[i]; [INFO] [stderr] 12 | | deck[i] = deck[j]; [INFO] [stderr] 13 | | deck[j] = swap; [INFO] [stderr] | |______________________^ help: try: `deck.swap(i, j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:65 [INFO] [stderr] | [INFO] [stderr] 50 | 1_000 * shuffles / (elapsed.as_secs() * 1_000 + elapsed.subsec_millis() as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "9290acaff16c32030ff997331a48300beb11bb6c0fba78e968ff02462b5014bf"` [INFO] running `"docker" "rm" "-f" "9290acaff16c32030ff997331a48300beb11bb6c0fba78e968ff02462b5014bf"` [INFO] [stdout] 9290acaff16c32030ff997331a48300beb11bb6c0fba78e968ff02462b5014bf