[INFO] updating cached repository kaorun343/uno [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kaorun343/uno [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kaorun343/uno" "work/ex/clippy-test-run/sources/stable/gh/kaorun343/uno"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kaorun343/uno'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kaorun343/uno" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaorun343/uno"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaorun343/uno'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d25e06a439d5cf7f46fc479c2f6aa450687153ce [INFO] sha for GitHub repo kaorun343/uno: d25e06a439d5cf7f46fc479c2f6aa450687153ce [INFO] validating manifest of kaorun343/uno on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kaorun343/uno on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kaorun343/uno [INFO] finished frobbing kaorun343/uno [INFO] frobbed toml for kaorun343/uno written to work/ex/clippy-test-run/sources/stable/gh/kaorun343/uno/Cargo.toml [INFO] started frobbing kaorun343/uno [INFO] finished frobbing kaorun343/uno [INFO] frobbed toml for kaorun343/uno written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaorun343/uno/Cargo.toml [INFO] crate kaorun343/uno has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kaorun343/uno against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaorun343/uno:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ab0d48e150016ae60c4df4cc92598580278f08fc0d14de6d7cecc5b4a0e2560 [INFO] running `"docker" "start" "-a" "2ab0d48e150016ae60c4df4cc92598580278f08fc0d14de6d7cecc5b4a0e2560"` [INFO] [stderr] Checking uno v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dealer.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | mountain: mountain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mountain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dealer.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | mountain: mountain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mountain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | players: players, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dealer.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return self.mountain.swap_remove(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mountain.swap_remove(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | return len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `len - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | return index - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `index - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dealer.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return self.mountain.swap_remove(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mountain.swap_remove(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | return len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `len - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | return index - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `index - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dealer.rs:143:12 [INFO] [stderr] | [INFO] [stderr] 143 | if self.mountain.len() == 0 {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.mountain.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:23:59 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn put_down_a_card(&mut self, card: &Card, color: &Option) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | let availables: Vec<_> = match card { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 26 | | &Card::Number(color, number) => indexes [INFO] [stderr] 27 | | .filter(|i| { [INFO] [stderr] 28 | | let card = &self.cards[*i]; [INFO] [stderr] ... | [INFO] [stderr] 88 | | }).collect(), [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | let availables: Vec<_> = match *card { [INFO] [stderr] 26 | Card::Number(color, number) => indexes [INFO] [stderr] 27 | .filter(|i| { [INFO] [stderr] 28 | let card = &self.cards[*i]; [INFO] [stderr] 29 | match *card { [INFO] [stderr] 30 | Card::Number(c, n) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/player.rs:33:51 [INFO] [stderr] | [INFO] [stderr] 33 | } else if n == number { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 34 | | return true; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/player.rs:31:43 [INFO] [stderr] | [INFO] [stderr] 31 | if c == color { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 32 | | return true; [INFO] [stderr] 33 | | } else if n == number { [INFO] [stderr] | |_____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/player.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | format!("{}", &self.name) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&self.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uno`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dealer.rs:143:12 [INFO] [stderr] | [INFO] [stderr] 143 | if self.mountain.len() == 0 {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.mountain.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:23:59 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn put_down_a_card(&mut self, card: &Card, color: &Option) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | let availables: Vec<_> = match card { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 26 | | &Card::Number(color, number) => indexes [INFO] [stderr] 27 | | .filter(|i| { [INFO] [stderr] 28 | | let card = &self.cards[*i]; [INFO] [stderr] ... | [INFO] [stderr] 88 | | }).collect(), [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | let availables: Vec<_> = match *card { [INFO] [stderr] 26 | Card::Number(color, number) => indexes [INFO] [stderr] 27 | .filter(|i| { [INFO] [stderr] 28 | let card = &self.cards[*i]; [INFO] [stderr] 29 | match *card { [INFO] [stderr] 30 | Card::Number(c, n) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/player.rs:33:51 [INFO] [stderr] | [INFO] [stderr] 33 | } else if n == number { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 34 | | return true; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/player.rs:31:43 [INFO] [stderr] | [INFO] [stderr] 31 | if c == color { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 32 | | return true; [INFO] [stderr] 33 | | } else if n == number { [INFO] [stderr] | |_____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/player.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | format!("{}", &self.name) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&self.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uno`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2ab0d48e150016ae60c4df4cc92598580278f08fc0d14de6d7cecc5b4a0e2560"` [INFO] running `"docker" "rm" "-f" "2ab0d48e150016ae60c4df4cc92598580278f08fc0d14de6d7cecc5b4a0e2560"` [INFO] [stdout] 2ab0d48e150016ae60c4df4cc92598580278f08fc0d14de6d7cecc5b4a0e2560