[INFO] updating cached repository kaojo/sudojo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kaojo/sudojo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kaojo/sudojo" "work/ex/clippy-test-run/sources/stable/gh/kaojo/sudojo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kaojo/sudojo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kaojo/sudojo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaojo/sudojo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaojo/sudojo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] adb8e9e8e6331231215574817f28e0db40b5b7a6 [INFO] sha for GitHub repo kaojo/sudojo: adb8e9e8e6331231215574817f28e0db40b5b7a6 [INFO] validating manifest of kaojo/sudojo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kaojo/sudojo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kaojo/sudojo [INFO] finished frobbing kaojo/sudojo [INFO] frobbed toml for kaojo/sudojo written to work/ex/clippy-test-run/sources/stable/gh/kaojo/sudojo/Cargo.toml [INFO] started frobbing kaojo/sudojo [INFO] finished frobbing kaojo/sudojo [INFO] frobbed toml for kaojo/sudojo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaojo/sudojo/Cargo.toml [INFO] crate kaojo/sudojo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kaojo/sudojo against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kaojo/sudojo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b828fc3fd4e9f6e89848108f6233605ed02ae9292de9fb05f9117078a829d91d [INFO] running `"docker" "start" "-a" "b828fc3fd4e9f6e89848108f6233605ed02ae9292de9fb05f9117078a829d91d"` [INFO] [stderr] Checking sudojo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmdwrapper/mod.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | AppStarter { app: app } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/coordinate.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | Coordinate { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/coordinate.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | Coordinate { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/square.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/square.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | initial: initial, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmdwrapper/mod.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | AppStarter { app: app } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/coordinate.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | Coordinate { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/coordinate.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | Coordinate { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/square.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sudoku/game/square.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | initial: initial, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmdwrapper/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / return Err(String::from( [INFO] [stderr] 22 | | "Initializing squares in the board is only allowed during init phase.", [INFO] [stderr] 23 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Err(String::from( [INFO] [stderr] 22 | "Initializing squares in the board is only allowed during init phase.", [INFO] [stderr] 23 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / return Err(String::from( [INFO] [stderr] 26 | | "Can't put non initial values in the board during init phase.", [INFO] [stderr] 27 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | Err(String::from( [INFO] [stderr] 26 | "Can't put non initial values in the board during init phase.", [INFO] [stderr] 27 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | / return Err(String::from( [INFO] [stderr] 34 | | "A Field with these coordinates allready exists!", [INFO] [stderr] 35 | | )) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Err(String::from( [INFO] [stderr] 34 | "A Field with these coordinates allready exists!", [INFO] [stderr] 35 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | None => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmdwrapper/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / return Err(String::from( [INFO] [stderr] 22 | | "Initializing squares in the board is only allowed during init phase.", [INFO] [stderr] 23 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Err(String::from( [INFO] [stderr] 22 | "Initializing squares in the board is only allowed during init phase.", [INFO] [stderr] 23 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / return Err(String::from( [INFO] [stderr] 26 | | "Can't put non initial values in the board during init phase.", [INFO] [stderr] 27 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | Err(String::from( [INFO] [stderr] 26 | "Can't put non initial values in the board during init phase.", [INFO] [stderr] 27 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | / return Err(String::from( [INFO] [stderr] 34 | | "A Field with these coordinates allready exists!", [INFO] [stderr] 35 | | )) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Err(String::from( [INFO] [stderr] 34 | "A Field with these coordinates allready exists!", [INFO] [stderr] 35 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sudoku/game/board.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | None => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/cmdwrapper/mod.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | &self.app.start(start_choice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app.start(start_choice);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/cmdwrapper/mod.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | &self.app.start(&Some(choice)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app.start(&Some(choice));` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sudoku::game::board::Board` [INFO] [stderr] --> src/sudoku/game/board.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Board { [INFO] [stderr] 14 | | data: HashMap::new(), [INFO] [stderr] 15 | | initialized: false, [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | writeln!(f, "Board"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | writeln!(f, "-------------------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | write!(f, "| "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | / write!( [INFO] [stderr] 62 | | f, [INFO] [stderr] 63 | | "{} ", [INFO] [stderr] 64 | | match self.get_square(&Coordinate::new(x, y)) [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sudoku/game/board.rs:69:40 [INFO] [stderr] | [INFO] [stderr] 69 | Some(ref p) => String::from(p.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `p.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | writeln!(f, "|"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/sudoku/game/coordinate.rs:1:21 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Debug, Eq, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/sudoku/game/coordinate.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / impl PartialEq for Coordinate { [INFO] [stderr] 8 | | fn eq(&self, other: &Coordinate) -> bool { [INFO] [stderr] 9 | | self.x.eq(&other.x) && self.y.eq(&other.y) [INFO] [stderr] 10| | } [INFO] [stderr] 11| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sudoku::Sudoku` [INFO] [stderr] --> src/sudoku/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | Sudoku { [INFO] [stderr] 13 | | board: Board::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for sudoku::Sudoku { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/sudoku/mod.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | for &(x,y,value) in square_map.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/sudoku/mod.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | &self.init(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `self.init();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sudojo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/cmdwrapper/mod.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | &self.app.start(start_choice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app.start(start_choice);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/cmdwrapper/mod.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | &self.app.start(&Some(choice)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app.start(&Some(choice));` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sudoku::game::board::Board` [INFO] [stderr] --> src/sudoku/game/board.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Board { [INFO] [stderr] 14 | | data: HashMap::new(), [INFO] [stderr] 15 | | initialized: false, [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | writeln!(f, "Board"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | writeln!(f, "-------------------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | write!(f, "| "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | / write!( [INFO] [stderr] 62 | | f, [INFO] [stderr] 63 | | "{} ", [INFO] [stderr] 64 | | match self.get_square(&Coordinate::new(x, y)) [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sudoku/game/board.rs:69:40 [INFO] [stderr] | [INFO] [stderr] 69 | Some(ref p) => String::from(p.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `p.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/sudoku/game/board.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | writeln!(f, "|"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/sudoku/game/coordinate.rs:1:21 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Debug, Eq, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/sudoku/game/coordinate.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / impl PartialEq for Coordinate { [INFO] [stderr] 8 | | fn eq(&self, other: &Coordinate) -> bool { [INFO] [stderr] 9 | | self.x.eq(&other.x) && self.y.eq(&other.y) [INFO] [stderr] 10| | } [INFO] [stderr] 11| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sudoku::Sudoku` [INFO] [stderr] --> src/sudoku/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | Sudoku { [INFO] [stderr] 13 | | board: Board::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for sudoku::Sudoku { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/sudoku/mod.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | for &(x,y,value) in square_map.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/sudoku/mod.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | &self.init(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `self.init();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sudojo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b828fc3fd4e9f6e89848108f6233605ed02ae9292de9fb05f9117078a829d91d"` [INFO] running `"docker" "rm" "-f" "b828fc3fd4e9f6e89848108f6233605ed02ae9292de9fb05f9117078a829d91d"` [INFO] [stdout] b828fc3fd4e9f6e89848108f6233605ed02ae9292de9fb05f9117078a829d91d