[INFO] updating cached repository kamino410/vlm-based-simulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kamino410/vlm-based-simulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kamino410/vlm-based-simulator" "work/ex/clippy-test-run/sources/stable/gh/kamino410/vlm-based-simulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kamino410/vlm-based-simulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kamino410/vlm-based-simulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamino410/vlm-based-simulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamino410/vlm-based-simulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1220a546547fab0e94b1ea266cecd6574d765d78 [INFO] sha for GitHub repo kamino410/vlm-based-simulator: 1220a546547fab0e94b1ea266cecd6574d765d78 [INFO] validating manifest of kamino410/vlm-based-simulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kamino410/vlm-based-simulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kamino410/vlm-based-simulator [INFO] finished frobbing kamino410/vlm-based-simulator [INFO] frobbed toml for kamino410/vlm-based-simulator written to work/ex/clippy-test-run/sources/stable/gh/kamino410/vlm-based-simulator/Cargo.toml [INFO] started frobbing kamino410/vlm-based-simulator [INFO] finished frobbing kamino410/vlm-based-simulator [INFO] frobbed toml for kamino410/vlm-based-simulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamino410/vlm-based-simulator/Cargo.toml [INFO] crate kamino410/vlm-based-simulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kamino410/vlm-based-simulator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamino410/vlm-based-simulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bfc955de85292b5dcb03cd5fe3ec79b1ffd2a6650f8c3300fdc156f796b25b79 [INFO] running `"docker" "start" "-a" "bfc955de85292b5dcb03cd5fe3ec79b1ffd2a6650f8c3300fdc156f796b25b79"` [INFO] [stderr] Checking vlm-based-simulator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/foil.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | if upp_ps.len() > 0 && upp_ps.last().unwrap().x < x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!upp_ps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/foil.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | upp_ps: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/foil.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | low_ps: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/foil.rs:86:26 [INFO] [stderr] | [INFO] [stderr] 86 | fn interpolate_z(ps: &Vec, x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | fn export_p2_vec(filename: &str, vec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / file.write(format!("{}, {}\n", p.x, p.z).as_bytes()) [INFO] [stderr] 26 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `vlm-based-simulator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/foil.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | if upp_ps.len() > 0 && upp_ps.last().unwrap().x < x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!upp_ps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/foil.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | upp_ps: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/foil.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | low_ps: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/foil.rs:86:26 [INFO] [stderr] | [INFO] [stderr] 86 | fn interpolate_z(ps: &Vec, x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | fn export_p2_vec(filename: &str, vec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Point2D]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / file.write(format!("{}, {}\n", p.x, p.z).as_bytes()) [INFO] [stderr] 26 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `vlm-based-simulator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bfc955de85292b5dcb03cd5fe3ec79b1ffd2a6650f8c3300fdc156f796b25b79"` [INFO] running `"docker" "rm" "-f" "bfc955de85292b5dcb03cd5fe3ec79b1ffd2a6650f8c3300fdc156f796b25b79"` [INFO] [stdout] bfc955de85292b5dcb03cd5fe3ec79b1ffd2a6650f8c3300fdc156f796b25b79