[INFO] updating cached repository kAzec/find_file [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kAzec/find_file [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kAzec/find_file" "work/ex/clippy-test-run/sources/stable/gh/kAzec/find_file"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kAzec/find_file'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kAzec/find_file" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kAzec/find_file"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kAzec/find_file'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8580f12d139aeadef9a823545caa3164df433833 [INFO] sha for GitHub repo kAzec/find_file: 8580f12d139aeadef9a823545caa3164df433833 [INFO] validating manifest of kAzec/find_file on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kAzec/find_file on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kAzec/find_file [INFO] finished frobbing kAzec/find_file [INFO] frobbed toml for kAzec/find_file written to work/ex/clippy-test-run/sources/stable/gh/kAzec/find_file/Cargo.toml [INFO] started frobbing kAzec/find_file [INFO] finished frobbing kAzec/find_file [INFO] frobbed toml for kAzec/find_file written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kAzec/find_file/Cargo.toml [INFO] crate kAzec/find_file has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kAzec/find_file against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kAzec/find_file:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08c97b8b999789df4352d27e4e6285aaf08f0c33ec90263d1b39de70e7bd92bb [INFO] running `"docker" "start" "-a" "08c97b8b999789df4352d27e4e6285aaf08f0c33ec90263d1b39de70e7bd92bb"` [INFO] [stderr] Checking find_file v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | return Err(Error::NotFound); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotFound)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:4 [INFO] [stderr] | [INFO] [stderr] 106 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:114:4 [INFO] [stderr] | [INFO] [stderr] 114 | return Err(Error::NotFound); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotFound)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dir_names`. [INFO] [stderr] --> src/lib.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | for i in 1..dir_names.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for in dir_names.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:124:39 [INFO] [stderr] | [INFO] [stderr] 124 | err @ Err(Error::NotFound) => match depth > 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 125 | | true => { [INFO] [stderr] 126 | | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 127 | | let entry = try!(entry); [INFO] [stderr] ... | [INFO] [stderr] 137 | | false => err, [INFO] [stderr] 138 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 124 | err @ Err(Error::NotFound) => if depth > 0 { [INFO] [stderr] 125 | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 126 | let entry = try!(entry); [INFO] [stderr] 127 | let entry_path = entry.path(); [INFO] [stderr] 128 | if try!(fs::metadata(&entry_path)).is_dir() { [INFO] [stderr] 129 | if let Ok(folder) = check_kids(depth-1, name, &entry_path) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | return Err(Error::NotFound); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotFound)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:4 [INFO] [stderr] | [INFO] [stderr] 106 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:114:4 [INFO] [stderr] | [INFO] [stderr] 114 | return Err(Error::NotFound); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotFound)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dir_names`. [INFO] [stderr] --> src/lib.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | for i in 1..dir_names.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for in dir_names.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:124:39 [INFO] [stderr] | [INFO] [stderr] 124 | err @ Err(Error::NotFound) => match depth > 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 125 | | true => { [INFO] [stderr] 126 | | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 127 | | let entry = try!(entry); [INFO] [stderr] ... | [INFO] [stderr] 137 | | false => err, [INFO] [stderr] 138 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 124 | err @ Err(Error::NotFound) => if depth > 0 { [INFO] [stderr] 125 | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 126 | let entry = try!(entry); [INFO] [stderr] 127 | let entry_path = entry.path(); [INFO] [stderr] 128 | if try!(fs::metadata(&entry_path)).is_dir() { [INFO] [stderr] 129 | if let Ok(folder) = check_kids(depth-1, name, &entry_path) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "08c97b8b999789df4352d27e4e6285aaf08f0c33ec90263d1b39de70e7bd92bb"` [INFO] running `"docker" "rm" "-f" "08c97b8b999789df4352d27e4e6285aaf08f0c33ec90263d1b39de70e7bd92bb"` [INFO] [stdout] 08c97b8b999789df4352d27e4e6285aaf08f0c33ec90263d1b39de70e7bd92bb