[INFO] updating cached repository k16shikano/exif [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/k16shikano/exif [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/k16shikano/exif" "work/ex/clippy-test-run/sources/stable/gh/k16shikano/exif"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/k16shikano/exif'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/k16shikano/exif" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k16shikano/exif"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k16shikano/exif'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fd5d006a42cee485ad8801311a06e7138405796 [INFO] sha for GitHub repo k16shikano/exif: 2fd5d006a42cee485ad8801311a06e7138405796 [INFO] validating manifest of k16shikano/exif on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of k16shikano/exif on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing k16shikano/exif [INFO] finished frobbing k16shikano/exif [INFO] frobbed toml for k16shikano/exif written to work/ex/clippy-test-run/sources/stable/gh/k16shikano/exif/Cargo.toml [INFO] started frobbing k16shikano/exif [INFO] finished frobbing k16shikano/exif [INFO] frobbed toml for k16shikano/exif written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k16shikano/exif/Cargo.toml [INFO] crate k16shikano/exif has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting k16shikano/exif against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k16shikano/exif:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80933a10f2edb42487733a5240e8b4509e3bbf9fc3119b29f762a34915e25f0b [INFO] running `"docker" "start" "-a" "80933a10f2edb42487733a5240e8b4509e3bbf9fc3119b29f762a34915e25f0b"` [INFO] [stderr] Checking exif v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len` [INFO] [stderr] --> src/main.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | 1 | 2 | 6 | 7 => len * 1, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | Some(header) => {let mut h = header.clone(); h.reverse(); Some(h)}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len` [INFO] [stderr] --> src/main.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | 1 | 2 | 6 | 7 => len * 1, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | Some(header) => {let mut h = header.clone(); h.reverse(); Some(h)}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "80933a10f2edb42487733a5240e8b4509e3bbf9fc3119b29f762a34915e25f0b"` [INFO] running `"docker" "rm" "-f" "80933a10f2edb42487733a5240e8b4509e3bbf9fc3119b29f762a34915e25f0b"` [INFO] [stdout] 80933a10f2edb42487733a5240e8b4509e3bbf9fc3119b29f762a34915e25f0b