[INFO] updating cached repository jwinters2/kanye_average [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jwinters2/kanye_average [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jwinters2/kanye_average" "work/ex/clippy-test-run/sources/stable/gh/jwinters2/kanye_average"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jwinters2/kanye_average'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jwinters2/kanye_average" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jwinters2/kanye_average"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jwinters2/kanye_average'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c38c2ec99dac544f01714dd9bb55359349547724 [INFO] sha for GitHub repo jwinters2/kanye_average: c38c2ec99dac544f01714dd9bb55359349547724 [INFO] validating manifest of jwinters2/kanye_average on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jwinters2/kanye_average on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jwinters2/kanye_average [INFO] finished frobbing jwinters2/kanye_average [INFO] frobbed toml for jwinters2/kanye_average written to work/ex/clippy-test-run/sources/stable/gh/jwinters2/kanye_average/Cargo.toml [INFO] started frobbing jwinters2/kanye_average [INFO] finished frobbing jwinters2/kanye_average [INFO] frobbed toml for jwinters2/kanye_average written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jwinters2/kanye_average/Cargo.toml [INFO] crate jwinters2/kanye_average has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jwinters2/kanye_average against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jwinters2/kanye_average:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 855f170b1c56dd553533276bf9b57f774c24c99ae889c6101369ba7191e8165e [INFO] running `"docker" "start" "-a" "855f170b1c56dd553533276bf9b57f774c24c99ae889c6101369ba7191e8165e"` [INFO] [stderr] Checking kanye_average v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 12 | | if let Ok(num) = arg.parse() { [INFO] [stderr] 13 | | nums.push(num); [INFO] [stderr] 14 | | } else { [INFO] [stderr] 15 | | println!("Could not convert {} to a float", arg); [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | } else if let Ok(num) = arg.parse() { [INFO] [stderr] 12 | nums.push(num); [INFO] [stderr] 13 | } else { [INFO] [stderr] 14 | println!("Could not convert {} to a float", arg); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 12 | | if let Ok(num) = arg.parse() { [INFO] [stderr] 13 | | nums.push(num); [INFO] [stderr] 14 | | } else { [INFO] [stderr] 15 | | println!("Could not convert {} to a float", arg); [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | } else if let Ok(num) = arg.parse() { [INFO] [stderr] 12 | nums.push(num); [INFO] [stderr] 13 | } else { [INFO] [stderr] 14 | println!("Could not convert {} to a float", arg); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | let pgrm = env::args().nth(0).unwrap_or("kanye".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "kanye".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(a - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(b - 3.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(b - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:47 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(a - 3.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:47 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kanye_average`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | let pgrm = env::args().nth(0).unwrap_or("kanye".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "kanye".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(a - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(b - 3.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(b - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:37:47 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(a - 3.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:37:47 [INFO] [stderr] | [INFO] [stderr] 37 | if (a == 2.0 && b == 3.0) || (b == 2.0 && a == 3.0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kanye_average`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "855f170b1c56dd553533276bf9b57f774c24c99ae889c6101369ba7191e8165e"` [INFO] running `"docker" "rm" "-f" "855f170b1c56dd553533276bf9b57f774c24c99ae889c6101369ba7191e8165e"` [INFO] [stdout] 855f170b1c56dd553533276bf9b57f774c24c99ae889c6101369ba7191e8165e