[INFO] updating cached repository justincampbell/url-shortener-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justincampbell/url-shortener-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justincampbell/url-shortener-rust" "work/ex/clippy-test-run/sources/stable/gh/justincampbell/url-shortener-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justincampbell/url-shortener-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justincampbell/url-shortener-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justincampbell/url-shortener-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justincampbell/url-shortener-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dea15a889eaf723a4ab9ccfa1a9ca95e078f3b0a [INFO] sha for GitHub repo justincampbell/url-shortener-rust: dea15a889eaf723a4ab9ccfa1a9ca95e078f3b0a [INFO] validating manifest of justincampbell/url-shortener-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justincampbell/url-shortener-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justincampbell/url-shortener-rust [INFO] finished frobbing justincampbell/url-shortener-rust [INFO] frobbed toml for justincampbell/url-shortener-rust written to work/ex/clippy-test-run/sources/stable/gh/justincampbell/url-shortener-rust/Cargo.toml [INFO] started frobbing justincampbell/url-shortener-rust [INFO] finished frobbing justincampbell/url-shortener-rust [INFO] frobbed toml for justincampbell/url-shortener-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justincampbell/url-shortener-rust/Cargo.toml [INFO] crate justincampbell/url-shortener-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting justincampbell/url-shortener-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justincampbell/url-shortener-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a06f4112f32abe3701bbfb7cfba3e9292819821c0a2694608715641e9bca9b49 [INFO] running `"docker" "start" "-a" "a06f4112f32abe3701bbfb7cfba3e9292819821c0a2694608715641e9bca9b49"` [INFO] [stderr] Checking shortener v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: type alias is never used: `Token` [INFO] [stderr] --> src/shortener.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | type Token = String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Url` [INFO] [stderr] --> src/shortener.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | type Url = String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `World` [INFO] [stderr] --> src/shortener.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct World { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `empty` [INFO] [stderr] --> src/shortener.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn empty() -> World { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shorten` [INFO] [stderr] --> src/shortener.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn shorten(&mut self, url: &Url) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `expand` [INFO] [stderr] --> src/shortener.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn expand(&self, token: Token) -> Option<&Url> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tokenize` [INFO] [stderr] --> src/shortener.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | fn tokenize(id: i32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/shortener.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn shorten(&mut self, url: &Url) -> Token { [INFO] [stderr] | ^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/shortener.rs:16:36 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn shorten(&mut self, url: &Url) -> Token { [INFO] [stderr] | ^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.55s [INFO] running `"docker" "inspect" "a06f4112f32abe3701bbfb7cfba3e9292819821c0a2694608715641e9bca9b49"` [INFO] running `"docker" "rm" "-f" "a06f4112f32abe3701bbfb7cfba3e9292819821c0a2694608715641e9bca9b49"` [INFO] [stdout] a06f4112f32abe3701bbfb7cfba3e9292819821c0a2694608715641e9bca9b49