[INFO] updating cached repository justinbarclay/diff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justinbarclay/diff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justinbarclay/diff" "work/ex/clippy-test-run/sources/stable/gh/justinbarclay/diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justinbarclay/diff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justinbarclay/diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinbarclay/diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinbarclay/diff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef49a83b6ba664da27ab849f3f9eef3efdb91dfa [INFO] sha for GitHub repo justinbarclay/diff: ef49a83b6ba664da27ab849f3f9eef3efdb91dfa [INFO] validating manifest of justinbarclay/diff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justinbarclay/diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justinbarclay/diff [INFO] finished frobbing justinbarclay/diff [INFO] frobbed toml for justinbarclay/diff written to work/ex/clippy-test-run/sources/stable/gh/justinbarclay/diff/Cargo.toml [INFO] started frobbing justinbarclay/diff [INFO] finished frobbing justinbarclay/diff [INFO] frobbed toml for justinbarclay/diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinbarclay/diff/Cargo.toml [INFO] crate justinbarclay/diff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting justinbarclay/diff against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinbarclay/diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f4d1b3a84acf3f01dbf86e47218e685f268653dbdd63f8bac4a39b30016bd49 [INFO] running `"docker" "start" "-a" "4f4d1b3a84acf3f01dbf86e47218e685f268653dbdd63f8bac4a39b30016bd49"` [INFO] [stderr] Checking rdiff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `time::now` [INFO] [stderr] --> src/diff.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use time::now; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Edit`, `decorate_differences`, `diff_greedy` [INFO] [stderr] --> src/main.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | use diff::{diff_greedy, Edit, decorate_differences}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `time::now` [INFO] [stderr] --> src/diff.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use time::now; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Edit`, `decorate_differences`, `diff_greedy` [INFO] [stderr] --> src/main.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | use diff::{diff_greedy, Edit, decorate_differences}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `algo` [INFO] [stderr] --> src/main.rs:56:7 [INFO] [stderr] | [INFO] [stderr] 56 | let algo = matches.value_of("ALGORITHM").unwrap_or("greedy"); [INFO] [stderr] | ^^^^ help: consider using `_algo` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/negative_array.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn get(&self, offset: isize) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set` [INFO] [stderr] --> src/negative_array.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn set(&mut self, offset: isize, value: isize) -> &mut NegativeArray { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/diff.rs:292:28 [INFO] [stderr] | [INFO] [stderr] 292 | let mut edit_range = map [INFO] [stderr] | ____________________________^ [INFO] [stderr] 293 | | .get_mut(&operation_string) [INFO] [stderr] 294 | | .unwrap() [INFO] [stderr] 295 | | .pop() [INFO] [stderr] 296 | | .unwrap() [INFO] [stderr] 297 | | .clone(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try removing the `clone` call [INFO] [stderr] | [INFO] [stderr] 292 | let mut edit_range = map [INFO] [stderr] 293 | .get_mut(&operation_string) [INFO] [stderr] 294 | .unwrap() [INFO] [stderr] 295 | .pop() [INFO] [stderr] 296 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/diff.rs:301:52 [INFO] [stderr] | [INFO] [stderr] 301 | map.get_mut(&operation_string).unwrap().push(edit.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `edit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused variable: `algo` [INFO] [stderr] --> src/main.rs:56:7 [INFO] [stderr] | [INFO] [stderr] 56 | let algo = matches.value_of("ALGORITHM").unwrap_or("greedy"); [INFO] [stderr] | ^^^^ help: consider using `_algo` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/diff.rs:360:33 [INFO] [stderr] | [INFO] [stderr] 360 | } else if first.is_empty() && second.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!second.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/diff.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | } else if first.len() > 0 && second.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!first.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff_file.rs:4:53 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn diff_files(file_one: &str, file_two: &str)-> Result>)>, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:5:50 [INFO] [stderr] | [INFO] [stderr] 5 | let file_one_lines: Vec<&str> = file_one.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:6:50 [INFO] [stderr] | [INFO] [stderr] 6 | let file_two_lines: Vec<&str> = file_two.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:45:50 [INFO] [stderr] | [INFO] [stderr] 45 | let file_one_lines: Vec<&str> = file_one.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:46:50 [INFO] [stderr] | [INFO] [stderr] 46 | let file_two_lines: Vec<&str> = file_two.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/negative_array.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | / fn index_mut<'a>(&'a mut self, offset: isize) -> &'a mut isize { [INFO] [stderr] 24 | | let index = self.max + offset; [INFO] [stderr] 25 | | if index >= 0 { [INFO] [stderr] 26 | | &mut self.arr[index as usize] [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/negative_array.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let mut arr = NegativeArray::new(10); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/diff.rs:292:28 [INFO] [stderr] | [INFO] [stderr] 292 | let mut edit_range = map [INFO] [stderr] | ____________________________^ [INFO] [stderr] 293 | | .get_mut(&operation_string) [INFO] [stderr] 294 | | .unwrap() [INFO] [stderr] 295 | | .pop() [INFO] [stderr] 296 | | .unwrap() [INFO] [stderr] 297 | | .clone(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try removing the `clone` call [INFO] [stderr] | [INFO] [stderr] 292 | let mut edit_range = map [INFO] [stderr] 293 | .get_mut(&operation_string) [INFO] [stderr] 294 | .unwrap() [INFO] [stderr] 295 | .pop() [INFO] [stderr] 296 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/diff.rs:301:52 [INFO] [stderr] | [INFO] [stderr] 301 | map.get_mut(&operation_string).unwrap().push(edit.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `edit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/diff.rs:360:33 [INFO] [stderr] | [INFO] [stderr] 360 | } else if first.is_empty() && second.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!second.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/diff.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | } else if first.len() > 0 && second.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!first.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/diff_file.rs:4:53 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn diff_files(file_one: &str, file_two: &str)-> Result>)>, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:5:50 [INFO] [stderr] | [INFO] [stderr] 5 | let file_one_lines: Vec<&str> = file_one.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:6:50 [INFO] [stderr] | [INFO] [stderr] 6 | let file_two_lines: Vec<&str> = file_two.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:45:50 [INFO] [stderr] | [INFO] [stderr] 45 | let file_one_lines: Vec<&str> = file_one.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/diff_file.rs:46:50 [INFO] [stderr] | [INFO] [stderr] 46 | let file_two_lines: Vec<&str> = file_two.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/negative_array.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | / fn index_mut<'a>(&'a mut self, offset: isize) -> &'a mut isize { [INFO] [stderr] 24 | | let index = self.max + offset; [INFO] [stderr] 25 | | if index >= 0 { [INFO] [stderr] 26 | | &mut self.arr[index as usize] [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "4f4d1b3a84acf3f01dbf86e47218e685f268653dbdd63f8bac4a39b30016bd49"` [INFO] running `"docker" "rm" "-f" "4f4d1b3a84acf3f01dbf86e47218e685f268653dbdd63f8bac4a39b30016bd49"` [INFO] [stdout] 4f4d1b3a84acf3f01dbf86e47218e685f268653dbdd63f8bac4a39b30016bd49