[INFO] updating cached repository jpypi/crazy-trees
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jpypi/crazy-trees
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jpypi/crazy-trees" "work/ex/clippy-test-run/sources/stable/gh/jpypi/crazy-trees"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jpypi/crazy-trees'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jpypi/crazy-trees" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/crazy-trees"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/crazy-trees'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 715701f8f6655468cd904c92cf7805f56c90d7bd
[INFO] sha for GitHub repo jpypi/crazy-trees: 715701f8f6655468cd904c92cf7805f56c90d7bd
[INFO] validating manifest of jpypi/crazy-trees on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jpypi/crazy-trees on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jpypi/crazy-trees
[INFO] finished frobbing jpypi/crazy-trees
[INFO] frobbed toml for jpypi/crazy-trees written to work/ex/clippy-test-run/sources/stable/gh/jpypi/crazy-trees/Cargo.toml
[INFO] started frobbing jpypi/crazy-trees
[INFO] finished frobbing jpypi/crazy-trees
[INFO] frobbed toml for jpypi/crazy-trees written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/crazy-trees/Cargo.toml
[INFO] crate jpypi/crazy-trees has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jpypi/crazy-trees against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/crazy-trees:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ae0f95c038c3ea22026835c4e42c0f4d2d65a1abea2544d06818bfe1cdbfc480
[INFO] running `"docker" "start" "-a" "ae0f95c038c3ea22026835c4e42c0f4d2d65a1abea2544d06818bfe1cdbfc480"`
[INFO] [stderr]     Checking trees v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:183:9
[INFO] [stderr]     |
[INFO] [stderr] 183 |         return Some(cur);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(cur)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:183:9
[INFO] [stderr]     |
[INFO] [stderr] 183 |         return Some(cur);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(cur)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 | /     if let &Some(ref root) = root {
[INFO] [stderr] 52 | |         format!("TreeNode {{
[INFO] [stderr] 53 | | {0:1$}split: {3:?}
[INFO] [stderr] 54 | | {0:1$}left_child:  {4:}
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |         "None".to_string()
[INFO] [stderr] 61 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 | /     if let &Some(ref root) = root {
[INFO] [stderr] 52 | |         format!("TreeNode {{
[INFO] [stderr] 53 | | {0:1$}split: {3:?}
[INFO] [stderr] 54 | | {0:1$}left_child:  {4:}
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |         "None".to_string()
[INFO] [stderr] 61 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 51 |     if let Some(ref root) = *root {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:72:43
[INFO] [stderr]    |
[INFO] [stderr] 72 | fn count_dist<T: Hash + Eq + Clone>(data: &Vec<T>) -> Vec<Num> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 51 |     if let Some(ref root) = *root {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:72:43
[INFO] [stderr]    |
[INFO] [stderr] 72 | fn count_dist<T: Hash + Eq + Clone>(data: &Vec<T>) -> Vec<Num> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:92:15
[INFO] [stderr]    |
[INFO] [stderr] 92 | fn gini(dist: &Vec<Num>) -> Num {
[INFO] [stderr]    |               ^^^^^^^^^ help: change this to: `&[Num]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:97:18
[INFO] [stderr]    |
[INFO] [stderr] 97 | fn entropy(dist: &Vec<Num>) -> Num {
[INFO] [stderr]    |                  ^^^^^^^^^ help: change this to: `&[Num]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:121:27
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let left  = &data[..i+1];
[INFO] [stderr]     |                           ^^^^^ help: use: `..=i`
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:92:15
[INFO] [stderr]    |
[INFO] [stderr] 92 | fn gini(dist: &Vec<Num>) -> Num {
[INFO] [stderr]    |               ^^^^^^^^^ help: change this to: `&[Num]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:97:18
[INFO] [stderr]    |
[INFO] [stderr] 97 | fn entropy(dist: &Vec<Num>) -> Num {
[INFO] [stderr]    |                  ^^^^^^^^^ help: change this to: `&[Num]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:121:27
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let left  = &data[..i+1];
[INFO] [stderr]     |                           ^^^^^ help: use: `..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:173:38
[INFO] [stderr]     |
[INFO] [stderr] 173 |           let mut left: Vec<&Sample> = data.iter()
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 174 | |                                          .filter(|x| x[cur.split.feature] < cur.split.point)
[INFO] [stderr] 175 | |                                          .map(|x| *x).collect();
[INFO] [stderr]     | |_____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 173 |         let mut left: Vec<&Sample> = data.iter()
[INFO] [stderr] 174 |                                          .filter(|x| x[cur.split.feature] < cur.split.point).cloned().collect();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:176:39
[INFO] [stderr]     |
[INFO] [stderr] 176 |           let mut right: Vec<&Sample> = data.iter()
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 177 | |                                           .filter(|x| x[cur.split.feature] >= cur.split.point)
[INFO] [stderr] 178 | |                                           .map(|x| *x).collect();
[INFO] [stderr]     | |______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let mut right: Vec<&Sample> = data.iter()
[INFO] [stderr] 177 |                                           .filter(|x| x[cur.split.feature] >= cur.split.point).cloned().collect();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:173:38
[INFO] [stderr]     |
[INFO] [stderr] 173 |           let mut left: Vec<&Sample> = data.iter()
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 174 | |                                          .filter(|x| x[cur.split.feature] < cur.split.point)
[INFO] [stderr] 175 | |                                          .map(|x| *x).collect();
[INFO] [stderr]     | |_____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:196:34
[INFO] [stderr]     |
[INFO] [stderr] 196 |             data.push(line.split(",")
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 173 |         let mut left: Vec<&Sample> = data.iter()
[INFO] [stderr] 174 |                                          .filter(|x| x[cur.split.feature] < cur.split.point).cloned().collect();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:176:39
[INFO] [stderr]     |
[INFO] [stderr] 176 |           let mut right: Vec<&Sample> = data.iter()
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 177 | |                                           .filter(|x| x[cur.split.feature] >= cur.split.point)
[INFO] [stderr] 178 | |                                           .map(|x| *x).collect();
[INFO] [stderr]     | |______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let mut right: Vec<&Sample> = data.iter()
[INFO] [stderr] 177 |                                           .filter(|x| x[cur.split.feature] >= cur.split.point).cloned().collect();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:196:34
[INFO] [stderr]     |
[INFO] [stderr] 196 |             data.push(line.split(",")
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.82s
[INFO] running `"docker" "inspect" "ae0f95c038c3ea22026835c4e42c0f4d2d65a1abea2544d06818bfe1cdbfc480"`
[INFO] running `"docker" "rm" "-f" "ae0f95c038c3ea22026835c4e42c0f4d2d65a1abea2544d06818bfe1cdbfc480"`
[INFO] [stdout] ae0f95c038c3ea22026835c4e42c0f4d2d65a1abea2544d06818bfe1cdbfc480