[INFO] updating cached repository jparoz/huck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jparoz/huck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jparoz/huck" "work/ex/clippy-test-run/sources/stable/gh/jparoz/huck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jparoz/huck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jparoz/huck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jparoz/huck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jparoz/huck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6107d31c3b5a8286a3effdfbfde6df6569270d7 [INFO] sha for GitHub repo jparoz/huck: f6107d31c3b5a8286a3effdfbfde6df6569270d7 [INFO] validating manifest of jparoz/huck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jparoz/huck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jparoz/huck [INFO] finished frobbing jparoz/huck [INFO] frobbed toml for jparoz/huck written to work/ex/clippy-test-run/sources/stable/gh/jparoz/huck/Cargo.toml [INFO] started frobbing jparoz/huck [INFO] finished frobbing jparoz/huck [INFO] frobbed toml for jparoz/huck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jparoz/huck/Cargo.toml [INFO] crate jparoz/huck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jparoz/huck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jparoz/huck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 16f9f73601dff051e720aa09327c0a063a301874848216ff6cc75ac1c41bff23 [INFO] running `"docker" "start" "-a" "16f9f73601dff051e720aa09327c0a063a301874848216ff6cc75ac1c41bff23"` [INFO] [stderr] Checking huck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:188:41 [INFO] [stderr] | [INFO] [stderr] 188 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | rhs: rhs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:188:41 [INFO] [stderr] | [INFO] [stderr] 188 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | rhs: rhs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lex.rs:588:28 [INFO] [stderr] | [INFO] [stderr] 588 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 589 | | if let Some(c) = self.eat() { [INFO] [stderr] 590 | | if c == '`' { [INFO] [stderr] 591 | | Some(self.snip(Backtick)) [INFO] [stderr] ... | [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lex.rs:588:28 [INFO] [stderr] | [INFO] [stderr] 588 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 589 | | if let Some(c) = self.eat() { [INFO] [stderr] 590 | | if c == '`' { [INFO] [stderr] 591 | | Some(self.snip(Backtick)) [INFO] [stderr] ... | [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 588 | } else if let Some(c) = self.eat() { [INFO] [stderr] 589 | if c == '`' { [INFO] [stderr] 590 | Some(self.snip(Backtick)) [INFO] [stderr] 591 | } else { [INFO] [stderr] 592 | self.error(format!("Expected '`' to end infix function \ [INFO] [stderr] 593 | call, but found {:?}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 588 | } else if let Some(c) = self.eat() { [INFO] [stderr] 589 | if c == '`' { [INFO] [stderr] 590 | Some(self.snip(Backtick)) [INFO] [stderr] 591 | } else { [INFO] [stderr] 592 | self.error(format!("Expected '`' to end infix function \ [INFO] [stderr] 593 | call, but found {:?}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TypeSignature` [INFO] [stderr] --> src/ast.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | TypeSignature { names: Vec<&'a str>, typ: Type<'a> }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lit` [INFO] [stderr] --> src/ast.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Lit(Literal), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Var` [INFO] [stderr] --> src/ast.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Var(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lam` [INFO] [stderr] --> src/ast.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Lam(Lambda<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `App` [INFO] [stderr] --> src/ast.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | App(Box>, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Var` [INFO] [stderr] --> src/ast.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Var(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Concrete` [INFO] [stderr] --> src/ast.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | Concrete(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `App` [INFO] [stderr] --> src/ast.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | App(Box>, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lex.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | fn requires_separator(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lex.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | fn is_literal(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lex.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn is_pattern_start(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lex.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | self.iter.peek().map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lex.rs:353:30 [INFO] [stderr] | [INFO] [stderr] 353 | text: &self.file[self.start..self.end + 1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.start..=self.end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lex.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | / fn next(&mut self) -> Option { [INFO] [stderr] 482 | | while let Some(c) = self.eat() { [INFO] [stderr] 483 | | // Check for (line) comments. [INFO] [stderr] 484 | | if c == '-' { [INFO] [stderr] ... | [INFO] [stderr] 677 | | None [INFO] [stderr] 678 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parse.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(_) = tokens.eat_if(Module) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 14 | | tokens.expect(Ident).map(|tok| module.name = tok.text); [INFO] [stderr] 15 | | tokens.expect(Semi); [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____- help: try this: `if tokens.eat_if(Module).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/parse.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | tokens.expect(Ident).map(|tok| module.name = tok.text); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(tok) = tokens.expect(Ident) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TypeSignature` [INFO] [stderr] --> src/ast.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | TypeSignature { names: Vec<&'a str>, typ: Type<'a> }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lit` [INFO] [stderr] --> src/ast.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Lit(Literal), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Var` [INFO] [stderr] --> src/ast.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Var(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lam` [INFO] [stderr] --> src/ast.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Lam(Lambda<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `App` [INFO] [stderr] --> src/ast.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | App(Box>, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Var` [INFO] [stderr] --> src/ast.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Var(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Concrete` [INFO] [stderr] --> src/ast.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | Concrete(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `App` [INFO] [stderr] --> src/ast.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | App(Box>, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lex.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | fn requires_separator(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lex.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | fn is_literal(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lex.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn is_pattern_start(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lex.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | self.iter.peek().map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lex.rs:353:30 [INFO] [stderr] | [INFO] [stderr] 353 | text: &self.file[self.start..self.end + 1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.start..=self.end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lex.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | / fn next(&mut self) -> Option { [INFO] [stderr] 482 | | while let Some(c) = self.eat() { [INFO] [stderr] 483 | | // Check for (line) comments. [INFO] [stderr] 484 | | if c == '-' { [INFO] [stderr] ... | [INFO] [stderr] 677 | | None [INFO] [stderr] 678 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parse.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(_) = tokens.eat_if(Module) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 14 | | tokens.expect(Ident).map(|tok| module.name = tok.text); [INFO] [stderr] 15 | | tokens.expect(Semi); [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____- help: try this: `if tokens.eat_if(Module).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/parse.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | tokens.expect(Ident).map(|tok| module.name = tok.text); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(tok) = tokens.expect(Ident) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "16f9f73601dff051e720aa09327c0a063a301874848216ff6cc75ac1c41bff23"` [INFO] running `"docker" "rm" "-f" "16f9f73601dff051e720aa09327c0a063a301874848216ff6cc75ac1c41bff23"` [INFO] [stdout] 16f9f73601dff051e720aa09327c0a063a301874848216ff6cc75ac1c41bff23