[INFO] updating cached repository jotingen/rust-sudokusolver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jotingen/rust-sudokusolver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jotingen/rust-sudokusolver" "work/ex/clippy-test-run/sources/stable/gh/jotingen/rust-sudokusolver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jotingen/rust-sudokusolver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jotingen/rust-sudokusolver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jotingen/rust-sudokusolver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jotingen/rust-sudokusolver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5655b077a8c3cc64745ed0aa130370f5dfcf9c9e [INFO] sha for GitHub repo jotingen/rust-sudokusolver: 5655b077a8c3cc64745ed0aa130370f5dfcf9c9e [INFO] validating manifest of jotingen/rust-sudokusolver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jotingen/rust-sudokusolver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jotingen/rust-sudokusolver [INFO] finished frobbing jotingen/rust-sudokusolver [INFO] frobbed toml for jotingen/rust-sudokusolver written to work/ex/clippy-test-run/sources/stable/gh/jotingen/rust-sudokusolver/Cargo.toml [INFO] started frobbing jotingen/rust-sudokusolver [INFO] finished frobbing jotingen/rust-sudokusolver [INFO] frobbed toml for jotingen/rust-sudokusolver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jotingen/rust-sudokusolver/Cargo.toml [INFO] crate jotingen/rust-sudokusolver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jotingen/rust-sudokusolver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jotingen/rust-sudokusolver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc6418a68ff44aeab347687317f2615b2151d9365f89abb2239e78bd83cfcfe6 [INFO] running `"docker" "start" "-a" "bc6418a68ff44aeab347687317f2615b2151d9365f89abb2239e78bd83cfcfe6"` [INFO] [stderr] Checking rust-sudokusolver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let mut b = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let mut b = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return a; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / if i / 27 * 3 + (i / 3) % 3 == b / 27 * 3 + (b / 3) % 3 { [INFO] [stderr] 75 | | if b != i && a[b] == a[i] { [INFO] [stderr] 76 | | fail = true; [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | if i / 27 * 3 + (i / 3) % 3 == b / 27 * 3 + (b / 3) % 3 && b != i && a[b] == a[i] { [INFO] [stderr] 75 | fail = true; [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return a; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / if i / 27 * 3 + (i / 3) % 3 == b / 27 * 3 + (b / 3) % 3 { [INFO] [stderr] 75 | | if b != i && a[b] == a[i] { [INFO] [stderr] 76 | | fail = true; [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | if i / 27 * 3 + (i / 3) % 3 == b / 27 * 3 + (b / 3) % 3 && b != i && a[b] == a[i] { [INFO] [stderr] 75 | fail = true; [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in args[1].chars().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for c in args[1].chars() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | let mut a: [u8; SIZE] = hint.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*hint` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `counter` is used as a loop counter. Consider using `for (counter, item) in array.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | for x in array.iter() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in args[1].chars().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for c in args[1].chars() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | let mut a: [u8; SIZE] = hint.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*hint` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `counter` is used as a loop counter. Consider using `for (counter, item) in array.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | for x in array.iter() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "bc6418a68ff44aeab347687317f2615b2151d9365f89abb2239e78bd83cfcfe6"` [INFO] running `"docker" "rm" "-f" "bc6418a68ff44aeab347687317f2615b2151d9365f89abb2239e78bd83cfcfe6"` [INFO] [stdout] bc6418a68ff44aeab347687317f2615b2151d9365f89abb2239e78bd83cfcfe6