[INFO] updating cached repository joshleeb/hanoi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joshleeb/hanoi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joshleeb/hanoi" "work/ex/clippy-test-run/sources/stable/gh/joshleeb/hanoi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joshleeb/hanoi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joshleeb/hanoi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/hanoi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/hanoi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c0059736627c4a34c439b0352e28d8867da7b073 [INFO] sha for GitHub repo joshleeb/hanoi: c0059736627c4a34c439b0352e28d8867da7b073 [INFO] validating manifest of joshleeb/hanoi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joshleeb/hanoi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joshleeb/hanoi [INFO] finished frobbing joshleeb/hanoi [INFO] frobbed toml for joshleeb/hanoi written to work/ex/clippy-test-run/sources/stable/gh/joshleeb/hanoi/Cargo.toml [INFO] started frobbing joshleeb/hanoi [INFO] finished frobbing joshleeb/hanoi [INFO] frobbed toml for joshleeb/hanoi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/hanoi/Cargo.toml [INFO] crate joshleeb/hanoi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joshleeb/hanoi against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/hanoi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37453772639cebac67d5eb22030bf25853a25231e1c7ad52adad9164ce7195bd [INFO] running `"docker" "start" "-a" "37453772639cebac67d5eb22030bf25853a25231e1c7ad52adad9164ce7195bd"` [INFO] [stderr] Checking hanoi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | disk: disk, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `disk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | disk: disk, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `disk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/hanoi.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | rods[0] = (1..n_disks + 1).rev().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=n_disks)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/hanoi.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if n_disks <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n_disks == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hanoi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/hanoi.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | rods[0] = (1..n_disks + 1).rev().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=n_disks)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/hanoi.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if n_disks <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n_disks == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hanoi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "37453772639cebac67d5eb22030bf25853a25231e1c7ad52adad9164ce7195bd"` [INFO] running `"docker" "rm" "-f" "37453772639cebac67d5eb22030bf25853a25231e1c7ad52adad9164ce7195bd"` [INFO] [stdout] 37453772639cebac67d5eb22030bf25853a25231e1c7ad52adad9164ce7195bd