[INFO] updating cached repository jornvanwier/Tee-Log [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jornvanwier/Tee-Log [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jornvanwier/Tee-Log" "work/ex/clippy-test-run/sources/stable/gh/jornvanwier/Tee-Log"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jornvanwier/Tee-Log'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jornvanwier/Tee-Log" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jornvanwier/Tee-Log"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jornvanwier/Tee-Log'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf83cf25fea39701f271ee9420e8e13d42580f04 [INFO] sha for GitHub repo jornvanwier/Tee-Log: cf83cf25fea39701f271ee9420e8e13d42580f04 [INFO] validating manifest of jornvanwier/Tee-Log on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jornvanwier/Tee-Log on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jornvanwier/Tee-Log [INFO] finished frobbing jornvanwier/Tee-Log [INFO] frobbed toml for jornvanwier/Tee-Log written to work/ex/clippy-test-run/sources/stable/gh/jornvanwier/Tee-Log/Cargo.toml [INFO] started frobbing jornvanwier/Tee-Log [INFO] finished frobbing jornvanwier/Tee-Log [INFO] frobbed toml for jornvanwier/Tee-Log written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jornvanwier/Tee-Log/Cargo.toml [INFO] crate jornvanwier/Tee-Log has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jornvanwier/Tee-Log against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jornvanwier/Tee-Log:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 27c92cc4b920f95de9d8a5b0a2bb5b0e82dc8496c381a94dd6a8566c361a4d7c [INFO] running `"docker" "start" "-a" "27c92cc4b920f95de9d8a5b0a2bb5b0e82dc8496c381a94dd6a8566c361a4d7c"` [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking chrono v0.3.1 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking tee-log v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return Local::now().format("%F %T:0%.3f").to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Local::now().format("%F %T:0%.3f").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return Local::now().format("%F %T:0%.3f").to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Local::now().format("%F %T:0%.3f").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | format!("{}", buf) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `buf.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | format!("{}", buf) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `buf.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.21s [INFO] running `"docker" "inspect" "27c92cc4b920f95de9d8a5b0a2bb5b0e82dc8496c381a94dd6a8566c361a4d7c"` [INFO] running `"docker" "rm" "-f" "27c92cc4b920f95de9d8a5b0a2bb5b0e82dc8496c381a94dd6a8566c361a4d7c"` [INFO] [stdout] 27c92cc4b920f95de9d8a5b0a2bb5b0e82dc8496c381a94dd6a8566c361a4d7c