[INFO] updating cached repository jorenvo/recaman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jorenvo/recaman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jorenvo/recaman" "work/ex/clippy-test-run/sources/stable/gh/jorenvo/recaman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jorenvo/recaman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jorenvo/recaman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/recaman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/recaman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5035c1fc8a4bd7bd84f102662df0fe4248ac79a7 [INFO] sha for GitHub repo jorenvo/recaman: 5035c1fc8a4bd7bd84f102662df0fe4248ac79a7 [INFO] validating manifest of jorenvo/recaman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jorenvo/recaman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jorenvo/recaman [INFO] finished frobbing jorenvo/recaman [INFO] frobbed toml for jorenvo/recaman written to work/ex/clippy-test-run/sources/stable/gh/jorenvo/recaman/Cargo.toml [INFO] started frobbing jorenvo/recaman [INFO] finished frobbing jorenvo/recaman [INFO] frobbed toml for jorenvo/recaman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/recaman/Cargo.toml [INFO] crate jorenvo/recaman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jorenvo/recaman against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/recaman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66b646c725530b7f184e3568012df3ba2a042dd344038d8771adac9056ff8ce9 [INFO] running `"docker" "start" "-a" "66b646c725530b7f184e3568012df3ba2a042dd344038d8771adac9056ff8ce9"` [INFO] [stderr] Checking svg v0.5.11 [INFO] [stderr] Checking recaman-svg v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / let a: i32; [INFO] [stderr] 36 | | if subtract_result > 0 && !used_numbers.contains(&(subtract_result as u32)) { [INFO] [stderr] 37 | | a = subtract_result; [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | a = last + seq_len; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let a = if subtract_result > 0 && !used_numbers.contains(&(subtract_result as u32)) { subtract_result } else { last + seq_len };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | fn get_line_height(recaman_sequence: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn generate_svg_document(recaman_sequence: &Vec, stroke_width: f32) -> svg::Document { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / let a: i32; [INFO] [stderr] 36 | | if subtract_result > 0 && !used_numbers.contains(&(subtract_result as u32)) { [INFO] [stderr] 37 | | a = subtract_result; [INFO] [stderr] 38 | | } else { [INFO] [stderr] 39 | | a = last + seq_len; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let a = if subtract_result > 0 && !used_numbers.contains(&(subtract_result as u32)) { subtract_result } else { last + seq_len };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | fn get_line_height(recaman_sequence: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn generate_svg_document(recaman_sequence: &Vec, stroke_width: f32) -> svg::Document { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "66b646c725530b7f184e3568012df3ba2a042dd344038d8771adac9056ff8ce9"` [INFO] running `"docker" "rm" "-f" "66b646c725530b7f184e3568012df3ba2a042dd344038d8771adac9056ff8ce9"` [INFO] [stdout] 66b646c725530b7f184e3568012df3ba2a042dd344038d8771adac9056ff8ce9