[INFO] updating cached repository jorenvo/p2p_client
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jorenvo/p2p_client
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jorenvo/p2p_client" "work/ex/clippy-test-run/sources/stable/gh/jorenvo/p2p_client"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jorenvo/p2p_client'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jorenvo/p2p_client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/p2p_client"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/p2p_client'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e96e9604beae5e6fec61e964798de3ceb689d909
[INFO] sha for GitHub repo jorenvo/p2p_client: e96e9604beae5e6fec61e964798de3ceb689d909
[INFO] validating manifest of jorenvo/p2p_client on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jorenvo/p2p_client on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jorenvo/p2p_client
[INFO] finished frobbing jorenvo/p2p_client
[INFO] frobbed toml for jorenvo/p2p_client written to work/ex/clippy-test-run/sources/stable/gh/jorenvo/p2p_client/Cargo.toml
[INFO] started frobbing jorenvo/p2p_client
[INFO] finished frobbing jorenvo/p2p_client
[INFO] frobbed toml for jorenvo/p2p_client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/p2p_client/Cargo.toml
[INFO] crate jorenvo/p2p_client has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jorenvo/p2p_client against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/p2p_client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3090d6d0a10b25e5634ae4d48cdc9b6251d5e5ceda2856c66beee06cdfc899a9
[INFO] running `"docker" "start" "-a" "3090d6d0a10b25e5634ae4d48cdc9b6251d5e5ceda2856c66beee06cdfc899a9"`
[INFO] [stderr]     Checking p2p_client v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset`
[INFO] [stderr]   --> src/lib.rs:76:21
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 buf[offset + 0],
[INFO] [stderr]    |                     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:81:14
[INFO] [stderr]    |
[INFO] [stderr] 81 |             ((buf[offset + 4] as u16) << 8) + buf[offset + 5] as u16,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[offset + 4])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:81:47
[INFO] [stderr]    |
[INFO] [stderr] 81 |             ((buf[offset + 4] as u16) << 8) + buf[offset + 5] as u16,
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[offset + 5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:131:34
[INFO] [stderr]     |
[INFO] [stderr] 131 | fn send(socket: &UdpSocket, buf: &Vec<u8>) {
[INFO] [stderr]     |                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:134:10
[INFO] [stderr]     |
[INFO] [stderr] 134 |         ((buf[4] as u16) << 8) + buf[5] as u16,
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[4])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |         ((buf[4] as u16) << 8) + buf[5] as u16,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: try: `u16::from(buf[5])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/lib.rs:176:10
[INFO] [stderr]     |
[INFO] [stderr] 176 |         .expect(&format!("Can't resolve {}.", config.broker))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't resolve {}.", config.broker))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset`
[INFO] [stderr]   --> src/lib.rs:76:21
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 buf[offset + 0],
[INFO] [stderr]    |                     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:81:14
[INFO] [stderr]    |
[INFO] [stderr] 81 |             ((buf[offset + 4] as u16) << 8) + buf[offset + 5] as u16,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[offset + 4])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:81:47
[INFO] [stderr]    |
[INFO] [stderr] 81 |             ((buf[offset + 4] as u16) << 8) + buf[offset + 5] as u16,
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[offset + 5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:131:34
[INFO] [stderr]     |
[INFO] [stderr] 131 | fn send(socket: &UdpSocket, buf: &Vec<u8>) {
[INFO] [stderr]     |                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:134:10
[INFO] [stderr]     |
[INFO] [stderr] 134 |         ((buf[4] as u16) << 8) + buf[5] as u16,
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[4])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |         ((buf[4] as u16) << 8) + buf[5] as u16,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: try: `u16::from(buf[5])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/lib.rs:176:10
[INFO] [stderr]     |
[INFO] [stderr] 176 |         .expect(&format!("Can't resolve {}.", config.broker))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't resolve {}.", config.broker))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.33s
[INFO] running `"docker" "inspect" "3090d6d0a10b25e5634ae4d48cdc9b6251d5e5ceda2856c66beee06cdfc899a9"`
[INFO] running `"docker" "rm" "-f" "3090d6d0a10b25e5634ae4d48cdc9b6251d5e5ceda2856c66beee06cdfc899a9"`
[INFO] [stdout] 3090d6d0a10b25e5634ae4d48cdc9b6251d5e5ceda2856c66beee06cdfc899a9