[INFO] updating cached repository jordanlewis/tis100 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jordanlewis/tis100 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jordanlewis/tis100" "work/ex/clippy-test-run/sources/stable/gh/jordanlewis/tis100"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jordanlewis/tis100'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jordanlewis/tis100" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jordanlewis/tis100"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jordanlewis/tis100'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 798104ce58a3f9905aa388c377601faaf9d4864a [INFO] sha for GitHub repo jordanlewis/tis100: 798104ce58a3f9905aa388c377601faaf9d4864a [INFO] validating manifest of jordanlewis/tis100 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jordanlewis/tis100 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jordanlewis/tis100 [INFO] finished frobbing jordanlewis/tis100 [INFO] frobbed toml for jordanlewis/tis100 written to work/ex/clippy-test-run/sources/stable/gh/jordanlewis/tis100/Cargo.toml [INFO] started frobbing jordanlewis/tis100 [INFO] finished frobbing jordanlewis/tis100 [INFO] frobbed toml for jordanlewis/tis100 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jordanlewis/tis100/Cargo.toml [INFO] crate jordanlewis/tis100 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jordanlewis/tis100 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jordanlewis/tis100:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00963ec16f43f9d1b13014f2b41c83d39b1ca7b585f69c15d24c09035c80931b [INFO] running `"docker" "start" "-a" "00963ec16f43f9d1b13014f2b41c83d39b1ca7b585f69c15d24c09035c80931b"` [INFO] [stderr] Checking tis100 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:11 [INFO] [stderr] | [INFO] [stderr] 191 | instr: instr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `instr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | instrs: instrs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `instrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | Ok(Spec { programs: programs }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `programs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:11 [INFO] [stderr] | [INFO] [stderr] 191 | instr: instr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `instr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | instrs: instrs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `instrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | Ok(Spec { programs: programs }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `programs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | / match s.ends_with(",") { [INFO] [stderr] 83 | | true => Ok(&s[..s.len() - 1]), [INFO] [stderr] 84 | | false => Err("invalid mov instruction with no comma".to_string()), [INFO] [stderr] 85 | | } [INFO] [stderr] | |___^ help: consider using an if/else expression: `if s.ends_with(",") { Ok(&s[..s.len() - 1]) } else { Err("invalid mov instruction with no comma".to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | match s.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | .ok_or("invalid mov instruction without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid mov instruction without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | .ok_or("invalid mov instruction without dest".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid mov instruction without dest".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | .ok_or("invalid add instr without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid add instr without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:114:10 [INFO] [stderr] | [INFO] [stderr] 114 | .ok_or("invalid sub instr without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid sub instr without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:121:10 [INFO] [stderr] | [INFO] [stderr] 121 | .ok_or("invalid jmp instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jmp instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:126:10 [INFO] [stderr] | [INFO] [stderr] 126 | .ok_or("invalid jez instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jez instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:131:10 [INFO] [stderr] | [INFO] [stderr] 131 | .ok_or("invalid jnz instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jnz instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | .ok_or("invalid jgz instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jgz instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:141:10 [INFO] [stderr] | [INFO] [stderr] 141 | .ok_or("invalid jlz instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jlz instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | .ok_or("invalid jro instr without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jro instr without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:151:7 [INFO] [stderr] | [INFO] [stderr] 151 | / match s.starts_with("#") { [INFO] [stderr] 152 | | true => Ok(Instr::Comment(words.fold(s.to_string(), |acc, s| acc + " " + s))), [INFO] [stderr] 153 | | false => Err(format!("invalid instr '{}'", s)), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_______^ help: consider using an if/else expression: `if s.starts_with("#") { Ok(Instr::Comment(words.fold(s.to_string(), |acc, s| acc + " " + s))) } else { Err(format!("invalid instr '{}'", s)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | match s.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | match line.find(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | if line[..i].contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / match label { [INFO] [stderr] 179 | | Some(label) => { [INFO] [stderr] 180 | | if labels.insert(label, instrs.len()) != None { [INFO] [stderr] 181 | | return Err(format!("label '{}' already exists", label)); [INFO] [stderr] ... | [INFO] [stderr] 184 | | None => {} [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let Some(label) = label { [INFO] [stderr] 179 | if labels.insert(label, instrs.len()) != None { [INFO] [stderr] 180 | return Err(format!("label '{}' already exists", label)); [INFO] [stderr] 181 | } [INFO] [stderr] 182 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:203:1 [INFO] [stderr] | [INFO] [stderr] 203 | / pub fn parse_spec<'a>(buf: Lines<'a>) -> Result, String> { [INFO] [stderr] 204 | | let mut programs = Vec::new(); [INFO] [stderr] 205 | | [INFO] [stderr] 206 | | let mut buf = buf.into_iter(); [INFO] [stderr] ... | [INFO] [stderr] 239 | | Ok(Spec { programs: programs }) [INFO] [stderr] 240 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | let mut buf = buf.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:216:25 [INFO] [stderr] | [INFO] [stderr] 216 | if line.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:223:7 [INFO] [stderr] | [INFO] [stderr] 223 | next_section = next_section + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_section += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:224:46 [INFO] [stderr] | [INFO] [stderr] 224 | let last_line = try!(raw_program.pop().ok_or("invalid empty section".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid empty section".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | return Err(format!("invalid section: didn't end with an empty line")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"invalid section: didn't end with an empty line".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | / match s.ends_with(",") { [INFO] [stderr] 83 | | true => Ok(&s[..s.len() - 1]), [INFO] [stderr] 84 | | false => Err("invalid mov instruction with no comma".to_string()), [INFO] [stderr] 85 | | } [INFO] [stderr] | |___^ help: consider using an if/else expression: `if s.ends_with(",") { Ok(&s[..s.len() - 1]) } else { Err("invalid mov instruction with no comma".to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | match s.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | .ok_or("invalid mov instruction without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid mov instruction without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | .ok_or("invalid mov instruction without dest".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid mov instruction without dest".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | .ok_or("invalid add instr without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid add instr without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:114:10 [INFO] [stderr] | [INFO] [stderr] 114 | .ok_or("invalid sub instr without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid sub instr without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:121:10 [INFO] [stderr] | [INFO] [stderr] 121 | .ok_or("invalid jmp instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jmp instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:126:10 [INFO] [stderr] | [INFO] [stderr] 126 | .ok_or("invalid jez instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jez instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:131:10 [INFO] [stderr] | [INFO] [stderr] 131 | .ok_or("invalid jnz instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jnz instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | .ok_or("invalid jgz instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jgz instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:141:10 [INFO] [stderr] | [INFO] [stderr] 141 | .ok_or("invalid jlz instr without label".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jlz instr without label".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | .ok_or("invalid jro instr without source".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid jro instr without source".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:151:7 [INFO] [stderr] | [INFO] [stderr] 151 | / match s.starts_with("#") { [INFO] [stderr] 152 | | true => Ok(Instr::Comment(words.fold(s.to_string(), |acc, s| acc + " " + s))), [INFO] [stderr] 153 | | false => Err(format!("invalid instr '{}'", s)), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_______^ help: consider using an if/else expression: `if s.starts_with("#") { Ok(Instr::Comment(words.fold(s.to_string(), |acc, s| acc + " " + s))) } else { Err(format!("invalid instr '{}'", s)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | match s.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | match line.find(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | if line[..i].contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / match label { [INFO] [stderr] 179 | | Some(label) => { [INFO] [stderr] 180 | | if labels.insert(label, instrs.len()) != None { [INFO] [stderr] 181 | | return Err(format!("label '{}' already exists", label)); [INFO] [stderr] ... | [INFO] [stderr] 184 | | None => {} [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let Some(label) = label { [INFO] [stderr] 179 | if labels.insert(label, instrs.len()) != None { [INFO] [stderr] 180 | return Err(format!("label '{}' already exists", label)); [INFO] [stderr] 181 | } [INFO] [stderr] 182 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:203:1 [INFO] [stderr] | [INFO] [stderr] 203 | / pub fn parse_spec<'a>(buf: Lines<'a>) -> Result, String> { [INFO] [stderr] 204 | | let mut programs = Vec::new(); [INFO] [stderr] 205 | | [INFO] [stderr] 206 | | let mut buf = buf.into_iter(); [INFO] [stderr] ... | [INFO] [stderr] 239 | | Ok(Spec { programs: programs }) [INFO] [stderr] 240 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | let mut buf = buf.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:216:25 [INFO] [stderr] | [INFO] [stderr] 216 | if line.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:223:7 [INFO] [stderr] | [INFO] [stderr] 223 | next_section = next_section + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_section += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:224:46 [INFO] [stderr] | [INFO] [stderr] 224 | let last_line = try!(raw_program.pop().ok_or("invalid empty section".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "invalid empty section".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | return Err(format!("invalid section: didn't end with an empty line")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"invalid section: didn't end with an empty line".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "00963ec16f43f9d1b13014f2b41c83d39b1ca7b585f69c15d24c09035c80931b"` [INFO] running `"docker" "rm" "-f" "00963ec16f43f9d1b13014f2b41c83d39b1ca7b585f69c15d24c09035c80931b"` [INFO] [stdout] 00963ec16f43f9d1b13014f2b41c83d39b1ca7b585f69c15d24c09035c80931b