[INFO] updating cached repository jonfk/password-generator-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonfk/password-generator-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonfk/password-generator-rs" "work/ex/clippy-test-run/sources/stable/gh/jonfk/password-generator-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonfk/password-generator-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonfk/password-generator-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonfk/password-generator-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonfk/password-generator-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25430d22b3ecdc66202621905553d892f0c45ce5 [INFO] sha for GitHub repo jonfk/password-generator-rs: 25430d22b3ecdc66202621905553d892f0c45ce5 [INFO] validating manifest of jonfk/password-generator-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonfk/password-generator-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonfk/password-generator-rs [INFO] finished frobbing jonfk/password-generator-rs [INFO] frobbed toml for jonfk/password-generator-rs written to work/ex/clippy-test-run/sources/stable/gh/jonfk/password-generator-rs/Cargo.toml [INFO] started frobbing jonfk/password-generator-rs [INFO] finished frobbing jonfk/password-generator-rs [INFO] frobbed toml for jonfk/password-generator-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonfk/password-generator-rs/Cargo.toml [INFO] crate jonfk/password-generator-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonfk/password-generator-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonfk/password-generator-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd7222bd21008deffc3403be9a3bd5701ae24c6c3255d0bc4a7885a0750259a8 [INFO] running `"docker" "start" "-a" "cd7222bd21008deffc3403be9a3bd5701ae24c6c3255d0bc4a7885a0750259a8"` [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking password-generator-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match matches.occurrences_of("number") { [INFO] [stderr] 60 | | 1 => excluded.push(CharType::Number), [INFO] [stderr] 61 | | _ => {} [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("number") { excluded.push(CharType::Number) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / match matches.occurrences_of("special") { [INFO] [stderr] 64 | | 1 => excluded.push(CharType::Special), [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("special") { excluded.push(CharType::Special) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / match matches.occurrences_of("uppercase") { [INFO] [stderr] 68 | | 1 => excluded.push(CharType::UpperCase), [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("uppercase") { excluded.push(CharType::UpperCase) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / match matches.occurrences_of("lowercase") { [INFO] [stderr] 72 | | 1 => excluded.push(CharType::LowerCase), [INFO] [stderr] 73 | | _ => {} [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("lowercase") { excluded.push(CharType::LowerCase) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | fn to_type(num: u32) -> CharType { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match matches.occurrences_of("number") { [INFO] [stderr] 60 | | 1 => excluded.push(CharType::Number), [INFO] [stderr] 61 | | _ => {} [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("number") { excluded.push(CharType::Number) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / match matches.occurrences_of("special") { [INFO] [stderr] 64 | | 1 => excluded.push(CharType::Special), [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("special") { excluded.push(CharType::Special) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / match matches.occurrences_of("uppercase") { [INFO] [stderr] 68 | | 1 => excluded.push(CharType::UpperCase), [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("uppercase") { excluded.push(CharType::UpperCase) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / match matches.occurrences_of("lowercase") { [INFO] [stderr] 72 | | 1 => excluded.push(CharType::LowerCase), [INFO] [stderr] 73 | | _ => {} [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try this: `if let 1 = matches.occurrences_of("lowercase") { excluded.push(CharType::LowerCase) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | fn to_type(num: u32) -> CharType { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.13s [INFO] running `"docker" "inspect" "cd7222bd21008deffc3403be9a3bd5701ae24c6c3255d0bc4a7885a0750259a8"` [INFO] running `"docker" "rm" "-f" "cd7222bd21008deffc3403be9a3bd5701ae24c6c3255d0bc4a7885a0750259a8"` [INFO] [stdout] cd7222bd21008deffc3403be9a3bd5701ae24c6c3255d0bc4a7885a0750259a8