[INFO] updating cached repository johnnyasantoss/chat-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/johnnyasantoss/chat-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/johnnyasantoss/chat-rs" "work/ex/clippy-test-run/sources/stable/gh/johnnyasantoss/chat-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnnyasantoss/chat-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/johnnyasantoss/chat-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnnyasantoss/chat-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnnyasantoss/chat-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9dd9601ed15ecb841483526f9df4192eb4c175a6 [INFO] sha for GitHub repo johnnyasantoss/chat-rs: 9dd9601ed15ecb841483526f9df4192eb4c175a6 [INFO] validating manifest of johnnyasantoss/chat-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of johnnyasantoss/chat-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing johnnyasantoss/chat-rs [INFO] finished frobbing johnnyasantoss/chat-rs [INFO] frobbed toml for johnnyasantoss/chat-rs written to work/ex/clippy-test-run/sources/stable/gh/johnnyasantoss/chat-rs/Cargo.toml [INFO] started frobbing johnnyasantoss/chat-rs [INFO] finished frobbing johnnyasantoss/chat-rs [INFO] frobbed toml for johnnyasantoss/chat-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnnyasantoss/chat-rs/Cargo.toml [INFO] crate johnnyasantoss/chat-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting johnnyasantoss/chat-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnnyasantoss/chat-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd069d650c320a9383c9e794c6b6ee192e9b93ccd9e0022b9ee34c5fc2f71189 [INFO] running `"docker" "start" "-a" "bd069d650c320a9383c9e794c6b6ee192e9b93ccd9e0022b9ee34c5fc2f71189"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking chat-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/server.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return Server { [INFO] [stderr] 24 | | users: vec![], [INFO] [stderr] 25 | | location: location.to_owned(), [INFO] [stderr] 26 | | port: port, [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | Server { [INFO] [stderr] 24 | users: vec![], [INFO] [stderr] 25 | location: location.to_owned(), [INFO] [stderr] 26 | port: port, [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return app; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(_) => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/server.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return Server { [INFO] [stderr] 24 | | users: vec![], [INFO] [stderr] 25 | | location: location.to_owned(), [INFO] [stderr] 26 | | port: port, [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | Server { [INFO] [stderr] 24 | users: vec![], [INFO] [stderr] 25 | location: location.to_owned(), [INFO] [stderr] 26 | port: port, [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return app; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(_) => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `message` [INFO] [stderr] --> src/result.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | message: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `login` [INFO] [stderr] --> src/server.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | login: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `status` [INFO] [stderr] --> src/server.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | status: String, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `users` [INFO] [stderr] --> src/server.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | users: Vec<&'a User>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `join` [INFO] [stderr] --> src/server.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn join(mut self, user: &'a User) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `announce` [INFO] [stderr] --> src/server.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn announce(self, user: &'a User) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client.rs:3:42 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn join(server_location: &str, port: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: field is never used: `message` [INFO] [stderr] --> src/result.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | message: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/server.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!("Failed to bind."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: field is never used: `login` [INFO] [stderr] --> src/server.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | login: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `status` [INFO] [stderr] --> src/server.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | status: String, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `users` [INFO] [stderr] --> src/server.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | users: Vec<&'a User>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `join` [INFO] [stderr] --> src/server.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn join(mut self, user: &'a User) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `announce` [INFO] [stderr] --> src/server.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn announce(self, user: &'a User) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / stream [INFO] [stderr] 68 | | .write(b"HTTP/1.0 200 OK\nContent-Type: text/plain\nContent-Length: 5\n\nPong!\n") [INFO] [stderr] 69 | | .expect("Write"); [INFO] [stderr] | |____________________________^ [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client.rs:3:42 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn join(server_location: &str, port: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chat-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/server.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!("Failed to bind."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / stream [INFO] [stderr] 68 | | .write(b"HTTP/1.0 200 OK\nContent-Type: text/plain\nContent-Length: 5\n\nPong!\n") [INFO] [stderr] 69 | | .expect("Write"); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chat-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bd069d650c320a9383c9e794c6b6ee192e9b93ccd9e0022b9ee34c5fc2f71189"` [INFO] running `"docker" "rm" "-f" "bd069d650c320a9383c9e794c6b6ee192e9b93ccd9e0022b9ee34c5fc2f71189"` [INFO] [stdout] bd069d650c320a9383c9e794c6b6ee192e9b93ccd9e0022b9ee34c5fc2f71189