[INFO] updating cached repository johnny-keker/enter_wavman
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/johnny-keker/enter_wavman
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/johnny-keker/enter_wavman" "work/ex/clippy-test-run/sources/stable/gh/johnny-keker/enter_wavman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnny-keker/enter_wavman'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/johnny-keker/enter_wavman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnny-keker/enter_wavman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnny-keker/enter_wavman'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 70605ef6e50609018b0f63d20806fda8aebd7c65
[INFO] sha for GitHub repo johnny-keker/enter_wavman: 70605ef6e50609018b0f63d20806fda8aebd7c65
[INFO] validating manifest of johnny-keker/enter_wavman on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of johnny-keker/enter_wavman on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing johnny-keker/enter_wavman
[INFO] finished frobbing johnny-keker/enter_wavman
[INFO] frobbed toml for johnny-keker/enter_wavman written to work/ex/clippy-test-run/sources/stable/gh/johnny-keker/enter_wavman/Cargo.toml
[INFO] started frobbing johnny-keker/enter_wavman
[INFO] finished frobbing johnny-keker/enter_wavman
[INFO] frobbed toml for johnny-keker/enter_wavman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnny-keker/enter_wavman/Cargo.toml
[INFO] crate johnny-keker/enter_wavman has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting johnny-keker/enter_wavman against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnny-keker/enter_wavman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] afc6a10bfbc1ecb564a80d78f31468b38a363a9fea88bbd7934fcbbbca333242
[INFO] running `"docker" "start" "-a" "afc6a10bfbc1ecb564a80d78f31468b38a363a9fea88bbd7934fcbbbca333242"`
[INFO] [stderr]     Checking text_io v0.1.7
[INFO] [stderr]     Checking enter_wavman v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/notes_tools.rs:13:3
[INFO] [stderr]    |
[INFO] [stderr] 13 | /   return lead
[INFO] [stderr] 14 | |     .into_iter()
[INFO] [stderr] 15 | |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr] 16 | |     .flatten()
[INFO] [stderr] 17 | |     .collect();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 13 |   lead
[INFO] [stderr] 14 |     .into_iter()
[INFO] [stderr] 15 |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr] 16 |     .flatten()
[INFO] [stderr] 17 |     .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/notes_tools.rs:22:3
[INFO] [stderr]    |
[INFO] [stderr] 22 |   return rng.choose(&notes_data::KEYS).unwrap();
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rng.choose(&notes_data::KEYS).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/notes_tools.rs:28:3
[INFO] [stderr]    |
[INFO] [stderr] 28 | /   return UserKey {
[INFO] [stderr] 29 | |     lead: notes,
[INFO] [stderr] 30 | |     chords: key.chords,
[INFO] [stderr] 31 | |   };
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 28 |   UserKey {
[INFO] [stderr] 29 |     lead: notes,
[INFO] [stderr] 30 |     chords: key.chords,
[INFO] [stderr] 31 |   }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/wav_tools.rs:20:3
[INFO] [stderr]    |
[INFO] [stderr] 20 |   return buf;
[INFO] [stderr]    |   ^^^^^^^^^^^ help: remove `return` as shown: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude::*`
[INFO] [stderr]   --> src/wavman.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | use std::io::prelude::*;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/wavman.rs:93:3
[INFO] [stderr]    |
[INFO] [stderr] 93 |   return j;
[INFO] [stderr]    |   ^^^^^^^^^ help: remove `return` as shown: `j`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `LittleEndian`
[INFO] [stderr]   --> src/wavman.rs:76:19
[INFO] [stderr]    |
[INFO] [stderr] 76 |   use byteorder::{LittleEndian, WriteBytesExt};
[INFO] [stderr]    |                   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/notes_tools.rs:13:3
[INFO] [stderr]    |
[INFO] [stderr] 13 | /   return lead
[INFO] [stderr] 14 | |     .into_iter()
[INFO] [stderr] 15 | |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr] 16 | |     .flatten()
[INFO] [stderr] 17 | |     .collect();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 13 |   lead
[INFO] [stderr] 14 |     .into_iter()
[INFO] [stderr] 15 |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr] 16 |     .flatten()
[INFO] [stderr] 17 |     .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/notes_tools.rs:22:3
[INFO] [stderr]    |
[INFO] [stderr] 22 |   return rng.choose(&notes_data::KEYS).unwrap();
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rng.choose(&notes_data::KEYS).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/notes_tools.rs:28:3
[INFO] [stderr]    |
[INFO] [stderr] 28 | /   return UserKey {
[INFO] [stderr] 29 | |     lead: notes,
[INFO] [stderr] 30 | |     chords: key.chords,
[INFO] [stderr] 31 | |   };
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 28 |   UserKey {
[INFO] [stderr] 29 |     lead: notes,
[INFO] [stderr] 30 |     chords: key.chords,
[INFO] [stderr] 31 |   }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/wav_tools.rs:20:3
[INFO] [stderr]    |
[INFO] [stderr] 20 |   return buf;
[INFO] [stderr]    |   ^^^^^^^^^^^ help: remove `return` as shown: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude::*`
[INFO] [stderr]   --> src/wavman.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | use std::io::prelude::*;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/wavman.rs:93:3
[INFO] [stderr]    |
[INFO] [stderr] 93 |   return j;
[INFO] [stderr]    |   ^^^^^^^^^ help: remove `return` as shown: `j`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `LittleEndian`
[INFO] [stderr]   --> src/wavman.rs:76:19
[INFO] [stderr]    |
[INFO] [stderr] 76 |   use byteorder::{LittleEndian, WriteBytesExt};
[INFO] [stderr]    |                   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/notes_tools.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[allow(dead_code)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::useless_attribute)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/notes_tools.rs:14:6
[INFO] [stderr]    |
[INFO] [stderr] 14 |     .into_iter()
[INFO] [stderr]    |      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: requested on the command line with `-D clippy::into-iter-on-array`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/notes_tools.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `n.into_iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/notes_tools.rs:15:16
[INFO] [stderr]    |
[INFO] [stderr] 15 |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr]    |                ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/wavman.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | #[allow(dead_code)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 |   file.write(&wav).unwrap();
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `enter_wavman`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/notes_tools.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[allow(dead_code)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::useless_attribute)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/notes_tools.rs:14:6
[INFO] [stderr]    |
[INFO] [stderr] 14 |     .into_iter()
[INFO] [stderr]    |      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: requested on the command line with `-D clippy::into-iter-on-array`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/notes_tools.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `n.into_iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/notes_tools.rs:15:16
[INFO] [stderr]    |
[INFO] [stderr] 15 |     .map(|n| n.into_iter().map(|e| *e))
[INFO] [stderr]    |                ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/wavman.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | #[allow(dead_code)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 |   file.write(&wav).unwrap();
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `enter_wavman`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "afc6a10bfbc1ecb564a80d78f31468b38a363a9fea88bbd7934fcbbbca333242"`
[INFO] running `"docker" "rm" "-f" "afc6a10bfbc1ecb564a80d78f31468b38a363a9fea88bbd7934fcbbbca333242"`
[INFO] [stdout] afc6a10bfbc1ecb564a80d78f31468b38a363a9fea88bbd7934fcbbbca333242