[INFO] updating cached repository johnfoley3/rust-file-stuff
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/johnfoley3/rust-file-stuff
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/johnfoley3/rust-file-stuff" "work/ex/clippy-test-run/sources/stable/gh/johnfoley3/rust-file-stuff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johnfoley3/rust-file-stuff'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/johnfoley3/rust-file-stuff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnfoley3/rust-file-stuff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnfoley3/rust-file-stuff'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c224d7873db1cbcfc471a26710b167bf06dce846
[INFO] sha for GitHub repo johnfoley3/rust-file-stuff: c224d7873db1cbcfc471a26710b167bf06dce846
[INFO] validating manifest of johnfoley3/rust-file-stuff on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of johnfoley3/rust-file-stuff on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing johnfoley3/rust-file-stuff
[INFO] finished frobbing johnfoley3/rust-file-stuff
[INFO] frobbed toml for johnfoley3/rust-file-stuff written to work/ex/clippy-test-run/sources/stable/gh/johnfoley3/rust-file-stuff/Cargo.toml
[INFO] started frobbing johnfoley3/rust-file-stuff
[INFO] finished frobbing johnfoley3/rust-file-stuff
[INFO] frobbed toml for johnfoley3/rust-file-stuff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnfoley3/rust-file-stuff/Cargo.toml
[INFO] crate johnfoley3/rust-file-stuff has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting johnfoley3/rust-file-stuff against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johnfoley3/rust-file-stuff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ad2eb77ff2285dcedbae80d239b9040c86f726fbfe519bffed116cc989ce1e55
[INFO] running `"docker" "start" "-a" "ad2eb77ff2285dcedbae80d239b9040c86f726fbfe519bffed116cc989ce1e55"`
[INFO] [stderr]     Checking file_stuff v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     file
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:14:16
[INFO] [stderr]    |
[INFO] [stderr] 14 |       let file = match f {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 15 | |         Ok(file) => file,
[INFO] [stderr] 16 | |         Err(ref error) if error.kind() == ErrorKind::NotFound => match File::create(filename) {
[INFO] [stderr] 17 | |             Ok(file) => file,
[INFO] [stderr] ...  |
[INFO] [stderr] 20 | |         Err(e) => panic!("Failed to open the file with {:?}", e),
[INFO] [stderr] 21 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     file
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:14:16
[INFO] [stderr]    |
[INFO] [stderr] 14 |       let file = match f {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 15 | |         Ok(file) => file,
[INFO] [stderr] 16 | |         Err(ref error) if error.kind() == ErrorKind::NotFound => match File::create(filename) {
[INFO] [stderr] 17 | |             Ok(file) => file,
[INFO] [stderr] ...  |
[INFO] [stderr] 20 | |         Err(e) => panic!("Failed to open the file with {:?}", e),
[INFO] [stderr] 21 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.27s
[INFO] running `"docker" "inspect" "ad2eb77ff2285dcedbae80d239b9040c86f726fbfe519bffed116cc989ce1e55"`
[INFO] running `"docker" "rm" "-f" "ad2eb77ff2285dcedbae80d239b9040c86f726fbfe519bffed116cc989ce1e55"`
[INFO] [stdout] ad2eb77ff2285dcedbae80d239b9040c86f726fbfe519bffed116cc989ce1e55