[INFO] updating cached repository johan-bjareholt/mpsc_requests [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/johan-bjareholt/mpsc_requests [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/johan-bjareholt/mpsc_requests" "work/ex/clippy-test-run/sources/stable/gh/johan-bjareholt/mpsc_requests"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/johan-bjareholt/mpsc_requests'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/johan-bjareholt/mpsc_requests" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johan-bjareholt/mpsc_requests"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johan-bjareholt/mpsc_requests'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0bb3c4a8052d18c1cb36aacfe1c7f36a895678ef [INFO] sha for GitHub repo johan-bjareholt/mpsc_requests: 0bb3c4a8052d18c1cb36aacfe1c7f36a895678ef [INFO] validating manifest of johan-bjareholt/mpsc_requests on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of johan-bjareholt/mpsc_requests on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing johan-bjareholt/mpsc_requests [INFO] finished frobbing johan-bjareholt/mpsc_requests [INFO] frobbed toml for johan-bjareholt/mpsc_requests written to work/ex/clippy-test-run/sources/stable/gh/johan-bjareholt/mpsc_requests/Cargo.toml [INFO] started frobbing johan-bjareholt/mpsc_requests [INFO] finished frobbing johan-bjareholt/mpsc_requests [INFO] frobbed toml for johan-bjareholt/mpsc_requests written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johan-bjareholt/mpsc_requests/Cargo.toml [INFO] crate johan-bjareholt/mpsc_requests has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting johan-bjareholt/mpsc_requests against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/johan-bjareholt/mpsc_requests:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6922faf169b476ccd4f6a50ff93343eb66969b1bc9146161d0e54947dde4b04d [INFO] running `"docker" "start" "-a" "6922faf169b476ccd4f6a50ff93343eb66969b1bc9146161d0e54947dde4b04d"` [INFO] [stderr] Checking mpsc_requests v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | response_sender: response_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | request_receiver: request_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | request_sender: request_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | response_sender: response_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | request_receiver: request_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | request_sender: request_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return (c, p) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(c, p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return (c, p) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(c, p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/database.rs:30:60 [INFO] [stderr] | [INFO] [stderr] 30 | Some(age) => Ok(Responses::GotUser(age.clone())), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*age` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "6922faf169b476ccd4f6a50ff93343eb66969b1bc9146161d0e54947dde4b04d"` [INFO] running `"docker" "rm" "-f" "6922faf169b476ccd4f6a50ff93343eb66969b1bc9146161d0e54947dde4b04d"` [INFO] [stdout] 6922faf169b476ccd4f6a50ff93343eb66969b1bc9146161d0e54947dde4b04d