[INFO] updating cached repository joelpedraza/aoc2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joelpedraza/aoc2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joelpedraza/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/joelpedraza/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joelpedraza/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joelpedraza/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelpedraza/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelpedraza/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04328d125792606a9ce43cd67b17379a839b77a1 [INFO] sha for GitHub repo joelpedraza/aoc2018: 04328d125792606a9ce43cd67b17379a839b77a1 [INFO] validating manifest of joelpedraza/aoc2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joelpedraza/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joelpedraza/aoc2018 [INFO] finished frobbing joelpedraza/aoc2018 [INFO] frobbed toml for joelpedraza/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/joelpedraza/aoc2018/Cargo.toml [INFO] started frobbing joelpedraza/aoc2018 [INFO] finished frobbing joelpedraza/aoc2018 [INFO] frobbed toml for joelpedraza/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelpedraza/aoc2018/Cargo.toml [INFO] crate joelpedraza/aoc2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joelpedraza/aoc2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joelpedraza/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05741ea68b843ee06df395282e4104eb0dd05d0e3deff59794b2046bab0f8b4d [INFO] running `"docker" "start" "-a" "05741ea68b843ee06df395282e4104eb0dd05d0e3deff59794b2046bab0f8b4d"` [INFO] [stderr] Checking bit-vec v0.5.0 [INFO] [stderr] Checking bit-set v0.5.0 [INFO] [stderr] Checking aoc2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::once` [INFO] [stderr] --> src/problem01/solution.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | use std::iter::once; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitvec.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(false, BitVec32(0x80000000).get(0)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitvec.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(true, BitVec32(0x80000000).get(31)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitvec.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | let mut bs = BitVec32(0x80000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitvec.rs:138:27 [INFO] [stderr] | [INFO] [stderr] 138 | let bs = BitVec32(0x80000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::once` [INFO] [stderr] --> src/problem01/solution.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | use std::iter::once; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem01/solution.rs:71:20 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(4294967294, zig_zag_encode(2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_294` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem01/solution.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(4294967294, zig_zag_encode(2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem01/solution.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(4294967295, zig_zag_encode(-2147483648)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem01/solution.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(4294967295, zig_zag_encode(-2147483648)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem03/solution.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(101781, solve_part_1(INPUT)) [INFO] [stderr] | ^^^^^^ help: consider: `101_781` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: private type `bitvec::BitVec32Iter` in public interface (error E0446) [INFO] [stderr] --> src/bitvec.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn iter(&self) -> BitVec32Iter { [INFO] [stderr] 35 | | BitVec32Iter(self.clone()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/trie.rs:264:19 [INFO] [stderr] | [INFO] [stderr] 264 | .map(|mut node| { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: associated const is never used: `NO_SET_BITS` [INFO] [stderr] --> src/bitvec.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub const NO_SET_BITS: usize = 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: associated const is never used: `ALL` [INFO] [stderr] --> src/bitvec.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ALL: BitVec32 = BitVec32(u32::max_value()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/bitvec.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/bitvec.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn iter(&self) -> BitVec32Iter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `last` [INFO] [stderr] --> src/bitvec.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn last(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `BitVec32Iter` [INFO] [stderr] --> src/bitvec.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | struct BitVec32Iter(BitVec32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/trie.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `insert` [INFO] [stderr] --> src/trie.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn insert(&mut self, s: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/trie.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn contains(&mut self, s: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_boxes_with_single_transpose_bruteforce` [INFO] [stderr] --> src/problem02/solution.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn find_boxes_with_single_transpose_bruteforce(input: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `has_single_transpose` [INFO] [stderr] --> src/problem02/solution.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | fn has_single_transpose(word1: &str, word2: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/problem06/solution.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | fn new(x: u16, y: u16) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/problem06/solution.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | fn new() -> Rect { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_point` [INFO] [stderr] --> src/problem06/solution.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | fn from_point(point: &Point) -> Rect { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/trie.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | fn char_to_index(c: &char) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem02/solution.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | 'a' ... 'z' => Some((c as u8 - 'a' as u8) as usize), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem02/solution.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | 'A' ... 'Z' => Some((c as u8 - 'A' as u8) as usize), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/problem03/solution.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | / match intersection { [INFO] [stderr] 104 | | Some(r) => { [INFO] [stderr] 105 | | for y in r.top..r.bottom { [INFO] [stderr] 106 | | for x in r.left..r.right { [INFO] [stderr] ... | [INFO] [stderr] 111 | | None => {} [INFO] [stderr] 112 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(r) = intersection { [INFO] [stderr] 104 | for y in r.top..r.bottom { [INFO] [stderr] 105 | for x in r.left..r.right { [INFO] [stderr] 106 | intersected_squares.insert(y as usize * 1000usize + x as usize); [INFO] [stderr] 107 | } [INFO] [stderr] 108 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/problem04/solution.rs:87:50 [INFO] [stderr] | [INFO] [stderr] 87 | let total_sleep = *entry_value + elapsed_sleep as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(elapsed_sleep)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem05/solution.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | const REACTION_DIFFERENCE: u8 = 'a' as u8 - 'A' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem05/solution.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | const REACTION_DIFFERENCE: u8 = 'a' as u8 - 'A' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:45:56 [INFO] [stderr] | [INFO] [stderr] 45 | let nanos = elapsed.as_secs() * 1_000_000_000u64 + elapsed.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: private type `bitvec::BitVec32Iter` in public interface (error E0446) [INFO] [stderr] --> src/bitvec.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn iter(&self) -> BitVec32Iter { [INFO] [stderr] 35 | | BitVec32Iter(self.clone()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/trie.rs:264:19 [INFO] [stderr] | [INFO] [stderr] 264 | .map(|mut node| { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: associated const is never used: `NO_SET_BITS` [INFO] [stderr] --> src/bitvec.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub const NO_SET_BITS: usize = 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `last` [INFO] [stderr] --> src/bitvec.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn last(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/problem06/solution.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | fn new(x: u16, y: u16) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/problem06/solution.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | fn new() -> Rect { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_point` [INFO] [stderr] --> src/problem06/solution.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | fn from_point(point: &Point) -> Rect { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/trie.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | fn char_to_index(c: &char) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem02/solution.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | 'a' ... 'z' => Some((c as u8 - 'a' as u8) as usize), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem02/solution.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | 'A' ... 'Z' => Some((c as u8 - 'A' as u8) as usize), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/problem03/solution.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | / match intersection { [INFO] [stderr] 104 | | Some(r) => { [INFO] [stderr] 105 | | for y in r.top..r.bottom { [INFO] [stderr] 106 | | for x in r.left..r.right { [INFO] [stderr] ... | [INFO] [stderr] 111 | | None => {} [INFO] [stderr] 112 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(r) = intersection { [INFO] [stderr] 104 | for y in r.top..r.bottom { [INFO] [stderr] 105 | for x in r.left..r.right { [INFO] [stderr] 106 | intersected_squares.insert(y as usize * 1000usize + x as usize); [INFO] [stderr] 107 | } [INFO] [stderr] 108 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/problem04/solution.rs:87:50 [INFO] [stderr] | [INFO] [stderr] 87 | let total_sleep = *entry_value + elapsed_sleep as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(elapsed_sleep)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem05/solution.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | const REACTION_DIFFERENCE: u8 = 'a' as u8 - 'A' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/problem05/solution.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | const REACTION_DIFFERENCE: u8 = 'a' as u8 - 'A' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:45:56 [INFO] [stderr] | [INFO] [stderr] 45 | let nanos = elapsed.as_secs() * 1_000_000_000u64 + elapsed.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.71s [INFO] running `"docker" "inspect" "05741ea68b843ee06df395282e4104eb0dd05d0e3deff59794b2046bab0f8b4d"` [INFO] running `"docker" "rm" "-f" "05741ea68b843ee06df395282e4104eb0dd05d0e3deff59794b2046bab0f8b4d"` [INFO] [stdout] 05741ea68b843ee06df395282e4104eb0dd05d0e3deff59794b2046bab0f8b4d