[INFO] updating cached repository jmacdonald/bright [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jmacdonald/bright [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jmacdonald/bright" "work/ex/clippy-test-run/sources/stable/gh/jmacdonald/bright"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jmacdonald/bright'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jmacdonald/bright" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/bright"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/bright'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c53464495b90945b3df8dfec4a7fc7dbd3a8f1a [INFO] sha for GitHub repo jmacdonald/bright: 8c53464495b90945b3df8dfec4a7fc7dbd3a8f1a [INFO] validating manifest of jmacdonald/bright on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jmacdonald/bright on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jmacdonald/bright [INFO] finished frobbing jmacdonald/bright [INFO] frobbed toml for jmacdonald/bright written to work/ex/clippy-test-run/sources/stable/gh/jmacdonald/bright/Cargo.toml [INFO] started frobbing jmacdonald/bright [INFO] finished frobbing jmacdonald/bright [INFO] frobbed toml for jmacdonald/bright written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/bright/Cargo.toml [INFO] crate jmacdonald/bright has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jmacdonald/bright against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jmacdonald/bright:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 596351c7ecd0bd874f3f6b0e33ab2d876448b3eb6c6f3613beb2f24cb9a99dd6 [INFO] running `"docker" "start" "-a" "596351c7ecd0bd874f3f6b0e33ab2d876448b3eb6c6f3613beb2f24cb9a99dd6"` [INFO] [stderr] Checking bright v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / File::open(Path::new("/sys/class/backlight/intel_backlight/actual_brightness")) [INFO] [stderr] 18 | | .expect("Couldn't read current brightness.") [INFO] [stderr] 19 | | .read_to_string(&mut current_brightness); [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:21:56 [INFO] [stderr] | [INFO] [stderr] 21 | current_brightness.lines().next().unwrap().parse().expect( [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 22 | | &format!("Couldn't parse current brightness value: {}", current_brightness) [INFO] [stderr] 23 | | ) [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse current brightness value: {}", current_brightness))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / File::open(Path::new("/sys/class/backlight/intel_backlight/max_brightness")) [INFO] [stderr] 29 | | .expect("Couldn't read max brightness.") [INFO] [stderr] 30 | | .read_to_string(&mut max_brightness); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:32:52 [INFO] [stderr] | [INFO] [stderr] 32 | max_brightness.lines().next().unwrap().parse().expect( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 33 | | &format!("Couldn't parse max brightness value: {}", max_brightness) [INFO] [stderr] 34 | | ) [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse max brightness value: {}", max_brightness))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / File::open(Path::new("/sys/class/backlight/intel_backlight/actual_brightness")) [INFO] [stderr] 18 | | .expect("Couldn't read current brightness.") [INFO] [stderr] 19 | | .read_to_string(&mut current_brightness); [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:21:56 [INFO] [stderr] | [INFO] [stderr] 21 | current_brightness.lines().next().unwrap().parse().expect( [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 22 | | &format!("Couldn't parse current brightness value: {}", current_brightness) [INFO] [stderr] 23 | | ) [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse current brightness value: {}", current_brightness))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / File::open(Path::new("/sys/class/backlight/intel_backlight/max_brightness")) [INFO] [stderr] 29 | | .expect("Couldn't read max brightness.") [INFO] [stderr] 30 | | .read_to_string(&mut max_brightness); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:32:52 [INFO] [stderr] | [INFO] [stderr] 32 | max_brightness.lines().next().unwrap().parse().expect( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 33 | | &format!("Couldn't parse max brightness value: {}", max_brightness) [INFO] [stderr] 34 | | ) [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse max brightness value: {}", max_brightness))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `"docker" "inspect" "596351c7ecd0bd874f3f6b0e33ab2d876448b3eb6c6f3613beb2f24cb9a99dd6"` [INFO] running `"docker" "rm" "-f" "596351c7ecd0bd874f3f6b0e33ab2d876448b3eb6c6f3613beb2f24cb9a99dd6"` [INFO] [stdout] 596351c7ecd0bd874f3f6b0e33ab2d876448b3eb6c6f3613beb2f24cb9a99dd6