[INFO] updating cached repository jlgerber/renderer-scratch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jlgerber/renderer-scratch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jlgerber/renderer-scratch" "work/ex/clippy-test-run/sources/stable/gh/jlgerber/renderer-scratch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jlgerber/renderer-scratch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jlgerber/renderer-scratch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/renderer-scratch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/renderer-scratch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e543f786a5862d4374df36c053583be77132410 [INFO] sha for GitHub repo jlgerber/renderer-scratch: 0e543f786a5862d4374df36c053583be77132410 [INFO] validating manifest of jlgerber/renderer-scratch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jlgerber/renderer-scratch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jlgerber/renderer-scratch [INFO] finished frobbing jlgerber/renderer-scratch [INFO] frobbed toml for jlgerber/renderer-scratch written to work/ex/clippy-test-run/sources/stable/gh/jlgerber/renderer-scratch/Cargo.toml [INFO] started frobbing jlgerber/renderer-scratch [INFO] finished frobbing jlgerber/renderer-scratch [INFO] frobbed toml for jlgerber/renderer-scratch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/renderer-scratch/Cargo.toml [INFO] crate jlgerber/renderer-scratch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jlgerber/renderer-scratch against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jlgerber/renderer-scratch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11dcc232a3cfeaf765122bbd7a2a90014e9a100edfbb71abec99efe1c66b42e5 [INFO] running `"docker" "start" "-a" "11dcc232a3cfeaf765122bbd7a2a90014e9a100edfbb71abec99efe1c66b42e5"` [INFO] [stderr] Checking trait_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sphere.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | pub material: &'a Box [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a Material + 'a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sphere.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(radius: f32, material: &'a Box ) -> Sphere<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a Material + 'a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/hitrecord.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub material: Option<&'b Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'b Material + 'b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitrecord::HitRecord<'b>` [INFO] [stderr] --> src/hitrecord.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> HitRecord<'b> { [INFO] [stderr] 10 | | HitRecord { material: None } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sphere.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | pub material: &'a Box [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a Material + 'a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sphere.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(radius: f32, material: &'a Box ) -> Sphere<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a Material + 'a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/hitrecord.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub material: Option<&'b Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'b Material + 'b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitrecord::HitRecord<'b>` [INFO] [stderr] --> src/hitrecord.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> HitRecord<'b> { [INFO] [stderr] 10 | | HitRecord { material: None } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `trait_test::traits::*` [INFO] [stderr] --> src/bin/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use trait_test::traits::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/main.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | let keyref = mgr.get(key_ref.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mgr[key_ref.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused import: `trait_test::traits::*` [INFO] [stderr] --> src/bin/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use trait_test::traits::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/main.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | let keyref = mgr.get(key_ref.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mgr[key_ref.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "11dcc232a3cfeaf765122bbd7a2a90014e9a100edfbb71abec99efe1c66b42e5"` [INFO] running `"docker" "rm" "-f" "11dcc232a3cfeaf765122bbd7a2a90014e9a100edfbb71abec99efe1c66b42e5"` [INFO] [stdout] 11dcc232a3cfeaf765122bbd7a2a90014e9a100edfbb71abec99efe1c66b42e5