[INFO] updating cached repository jinroh/rust-brainfuck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jinroh/rust-brainfuck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jinroh/rust-brainfuck" "work/ex/clippy-test-run/sources/stable/gh/jinroh/rust-brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jinroh/rust-brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jinroh/rust-brainfuck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jinroh/rust-brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jinroh/rust-brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c77cacb3102024deedfa7c67ecbd95127d6dc2f [INFO] sha for GitHub repo jinroh/rust-brainfuck: 7c77cacb3102024deedfa7c67ecbd95127d6dc2f [INFO] validating manifest of jinroh/rust-brainfuck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jinroh/rust-brainfuck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jinroh/rust-brainfuck [INFO] finished frobbing jinroh/rust-brainfuck [INFO] frobbed toml for jinroh/rust-brainfuck written to work/ex/clippy-test-run/sources/stable/gh/jinroh/rust-brainfuck/Cargo.toml [INFO] started frobbing jinroh/rust-brainfuck [INFO] finished frobbing jinroh/rust-brainfuck [INFO] frobbed toml for jinroh/rust-brainfuck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jinroh/rust-brainfuck/Cargo.toml [INFO] crate jinroh/rust-brainfuck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jinroh/rust-brainfuck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jinroh/rust-brainfuck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fbe73ca5c6dd07afc571a74db0432af74767b1cbcef913802a51cbae3ea03c0 [INFO] running `"docker" "start" "-a" "4fbe73ca5c6dd07afc571a74db0432af74767b1cbcef913802a51cbae3ea03c0"` [INFO] [stderr] Checking rust-brainfuck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brfk/interpreter.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brfk/interpreter.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brfk/interpreter.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brfk/interpreter.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brfk/interpreter.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brfk/interpreter.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/brfk/opcodes.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / return if indent > 0 { [INFO] [stderr] 65 | | Err(CompileError::UnclosedWhile) [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | Ok(opcodes) [INFO] [stderr] 68 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | if indent > 0 { [INFO] [stderr] 65 | Err(CompileError::UnclosedWhile) [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | Ok(opcodes) [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/brfk/opcodes.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / return if indent > 0 { [INFO] [stderr] 65 | | Err(CompileError::UnclosedWhile) [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | Ok(opcodes) [INFO] [stderr] 68 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | if indent > 0 { [INFO] [stderr] 65 | Err(CompileError::UnclosedWhile) [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | Ok(opcodes) [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/brfk/interpreter.rs:79:53 [INFO] [stderr] | [INFO] [stderr] 79 | self.output.write_all(&self.ram[self.data..self.data + 1])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.data..=self.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/brfk/interpreter.rs:86:51 [INFO] [stderr] | [INFO] [stderr] 86 | .read_exact(&mut self.ram[self.data..self.data + 1])? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.data..=self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/brfk/interpreter.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if command_string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | .and_then(|filename| run_interpreter(filename)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `run_interpreter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | writeln!(io::stderr(), "{}", err.description()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/brfk/interpreter.rs:79:53 [INFO] [stderr] | [INFO] [stderr] 79 | self.output.write_all(&self.ram[self.data..self.data + 1])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.data..=self.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/brfk/interpreter.rs:86:51 [INFO] [stderr] | [INFO] [stderr] 86 | .read_exact(&mut self.ram[self.data..self.data + 1])? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.data..=self.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/brfk/interpreter.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if command_string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | .and_then(|filename| run_interpreter(filename)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `run_interpreter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | writeln!(io::stderr(), "{}", err.description()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "4fbe73ca5c6dd07afc571a74db0432af74767b1cbcef913802a51cbae3ea03c0"` [INFO] running `"docker" "rm" "-f" "4fbe73ca5c6dd07afc571a74db0432af74767b1cbcef913802a51cbae3ea03c0"` [INFO] [stdout] 4fbe73ca5c6dd07afc571a74db0432af74767b1cbcef913802a51cbae3ea03c0