[INFO] updating cached repository jimf/mincaml
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jimf/mincaml
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jimf/mincaml" "work/ex/clippy-test-run/sources/stable/gh/jimf/mincaml"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jimf/mincaml'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jimf/mincaml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimf/mincaml"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimf/mincaml'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c0228bfe3f06818b012991129abdee62bd7327e2
[INFO] sha for GitHub repo jimf/mincaml: c0228bfe3f06818b012991129abdee62bd7327e2
[INFO] validating manifest of jimf/mincaml on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jimf/mincaml on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jimf/mincaml
[INFO] finished frobbing jimf/mincaml
[INFO] frobbed toml for jimf/mincaml written to work/ex/clippy-test-run/sources/stable/gh/jimf/mincaml/Cargo.toml
[INFO] started frobbing jimf/mincaml
[INFO] finished frobbing jimf/mincaml
[INFO] frobbed toml for jimf/mincaml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimf/mincaml/Cargo.toml
[INFO] crate jimf/mincaml has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jimf/mincaml against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jimf/mincaml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b98543015b563ad10bc6fd659553b7dd9739e424e2b7055225b1a8e46e2345c0
[INFO] running `"docker" "start" "-a" "b98543015b563ad10bc6fd659553b7dd9739e424e2b7055225b1a8e46e2345c0"`
[INFO] [stderr]     Checking minicaml v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:147:21
[INFO] [stderr]     |
[INFO] [stderr] 147 |                     args: args,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:147:21
[INFO] [stderr]     |
[INFO] [stderr] 147 |                     args: args,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lexer.rs:176:5
[INFO] [stderr]     |
[INFO] [stderr] 176 | /     pub fn next(&mut self) -> Token {
[INFO] [stderr] 177 | |         self.skip_whitespace();
[INFO] [stderr] 178 | |
[INFO] [stderr] 179 | |         match self.read() {
[INFO] [stderr] ...   |
[INFO] [stderr] 275 | |         }
[INFO] [stderr] 276 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch`
[INFO] [stderr]    --> src/lexer.rs:265:18
[INFO] [stderr]     |
[INFO] [stderr] 265 |             Some(ch @ _) => {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:19:20
[INFO] [stderr]    |
[INFO] [stderr] 19 |     fn new(tokens: &Vec<Token>) -> Parser {
[INFO] [stderr]    |                    ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/parser.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |     fn is_done(&mut self) -> bool {
[INFO] [stderr]    |                ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:159:9
[INFO] [stderr]     |
[INFO] [stderr] 159 | /         loop {
[INFO] [stderr] 160 | |             match self.peek() {
[INFO] [stderr] 161 | |                 Token::Ident(ident) => {
[INFO] [stderr] 162 | |                     self.next();
[INFO] [stderr] ...   |
[INFO] [stderr] 168 | |             }
[INFO] [stderr] 169 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Token::Ident(ident) = self.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:170:12
[INFO] [stderr]     |
[INFO] [stderr] 170 |         if args.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:359:12
[INFO] [stderr]     |
[INFO] [stderr] 359 |         if args.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::Typing<'a>`
[INFO] [stderr]   --> src/typing.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Typing<'a> {
[INFO] [stderr] 21 | |         let env = HashMap::new();
[INFO] [stderr] 22 | |         let extenv = HashMap::new();
[INFO] [stderr] 23 | |         Typing { env, extenv }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lexer.rs:176:5
[INFO] [stderr]     |
[INFO] [stderr] 176 | /     pub fn next(&mut self) -> Token {
[INFO] [stderr] 177 | |         self.skip_whitespace();
[INFO] [stderr] 178 | |
[INFO] [stderr] 179 | |         match self.read() {
[INFO] [stderr] ...   |
[INFO] [stderr] 275 | |         }
[INFO] [stderr] 276 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch`
[INFO] [stderr]    --> src/lexer.rs:265:18
[INFO] [stderr]     |
[INFO] [stderr] 265 |             Some(ch @ _) => {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:19:20
[INFO] [stderr]    |
[INFO] [stderr] 19 |     fn new(tokens: &Vec<Token>) -> Parser {
[INFO] [stderr]    |                    ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/parser.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |     fn is_done(&mut self) -> bool {
[INFO] [stderr]    |                ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/typing.rs:83:30
[INFO] [stderr]    |
[INFO] [stderr] 83 |                     let t = *self.env.get(id).unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.env[id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `parse` doesn't need a mutable reference
[INFO] [stderr]   --> src/main.rs:31:21
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match parse(&mut line) {
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:159:9
[INFO] [stderr]     |
[INFO] [stderr] 159 | /         loop {
[INFO] [stderr] 160 | |             match self.peek() {
[INFO] [stderr] 161 | |                 Token::Ident(ident) => {
[INFO] [stderr] 162 | |                     self.next();
[INFO] [stderr] ...   |
[INFO] [stderr] 168 | |             }
[INFO] [stderr] 169 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Token::Ident(ident) = self.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:170:12
[INFO] [stderr]     |
[INFO] [stderr] 170 |         if args.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:359:12
[INFO] [stderr]     |
[INFO] [stderr] 359 |         if args.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::Typing<'a>`
[INFO] [stderr]   --> src/typing.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Typing<'a> {
[INFO] [stderr] 21 | |         let env = HashMap::new();
[INFO] [stderr] 22 | |         let extenv = HashMap::new();
[INFO] [stderr] 23 | |         Typing { env, extenv }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/typing.rs:83:30
[INFO] [stderr]    |
[INFO] [stderr] 83 |                     let t = *self.env.get(id).unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.env[id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `parse` doesn't need a mutable reference
[INFO] [stderr]   --> src/main.rs:31:21
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match parse(&mut line) {
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.95s
[INFO] running `"docker" "inspect" "b98543015b563ad10bc6fd659553b7dd9739e424e2b7055225b1a8e46e2345c0"`
[INFO] running `"docker" "rm" "-f" "b98543015b563ad10bc6fd659553b7dd9739e424e2b7055225b1a8e46e2345c0"`
[INFO] [stdout] b98543015b563ad10bc6fd659553b7dd9739e424e2b7055225b1a8e46e2345c0