[INFO] updating cached repository jhecking/algorithms-on-graphs-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jhecking/algorithms-on-graphs-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jhecking/algorithms-on-graphs-rust" "work/ex/clippy-test-run/sources/stable/gh/jhecking/algorithms-on-graphs-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jhecking/algorithms-on-graphs-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jhecking/algorithms-on-graphs-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhecking/algorithms-on-graphs-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhecking/algorithms-on-graphs-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b42ea89ab42ab680159df870c7dee01b79f6b727 [INFO] sha for GitHub repo jhecking/algorithms-on-graphs-rust: b42ea89ab42ab680159df870c7dee01b79f6b727 [INFO] validating manifest of jhecking/algorithms-on-graphs-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jhecking/algorithms-on-graphs-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jhecking/algorithms-on-graphs-rust [INFO] finished frobbing jhecking/algorithms-on-graphs-rust [INFO] frobbed toml for jhecking/algorithms-on-graphs-rust written to work/ex/clippy-test-run/sources/stable/gh/jhecking/algorithms-on-graphs-rust/Cargo.toml [INFO] started frobbing jhecking/algorithms-on-graphs-rust [INFO] finished frobbing jhecking/algorithms-on-graphs-rust [INFO] frobbed toml for jhecking/algorithms-on-graphs-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhecking/algorithms-on-graphs-rust/Cargo.toml [INFO] crate jhecking/algorithms-on-graphs-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jhecking/algorithms-on-graphs-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhecking/algorithms-on-graphs-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe0061947e9695a9b2498c834229b1d65a9ce81153a287088badaedcc84e8175 [INFO] running `"docker" "start" "-a" "fe0061947e9695a9b2498c834229b1d65a9ce81153a287088badaedcc84e8175"` [INFO] [stderr] Checking reachability v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Graph { vertices: vertices, edges: edges, directed: directed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | Graph { vertices: vertices, edges: edges, directed: directed } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:28:51 [INFO] [stderr] | [INFO] [stderr] 28 | Graph { vertices: vertices, edges: edges, directed: directed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `directed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | Graph { vertices: vertices, edges: edges, directed: directed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | Graph { vertices: vertices, edges: edges, directed: directed } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:28:51 [INFO] [stderr] | [INFO] [stderr] 28 | Graph { vertices: vertices, edges: edges, directed: directed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `directed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/graph.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let vertices = (1..v+1).collect(); [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graph.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | fn explore(&self, v: &Vertex, visited: &mut HashSet, component: &mut Component) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Vertex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graph.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | fn visit(v: &Vertex, adj: &Adjacencies, visited: &mut HashSet, component: &mut Component) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Vertex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/graph.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let vertices = (1..v+1).collect(); [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graph.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | fn explore(&self, v: &Vertex, visited: &mut HashSet, component: &mut Component) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Vertex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graph.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | fn visit(v: &Vertex, adj: &Adjacencies, visited: &mut HashSet, component: &mut Component) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Vertex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "fe0061947e9695a9b2498c834229b1d65a9ce81153a287088badaedcc84e8175"` [INFO] running `"docker" "rm" "-f" "fe0061947e9695a9b2498c834229b1d65a9ce81153a287088badaedcc84e8175"` [INFO] [stdout] fe0061947e9695a9b2498c834229b1d65a9ce81153a287088badaedcc84e8175