[INFO] updating cached repository jhartwell/expelcss [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jhartwell/expelcss [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jhartwell/expelcss" "work/ex/clippy-test-run/sources/stable/gh/jhartwell/expelcss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jhartwell/expelcss'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jhartwell/expelcss" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhartwell/expelcss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhartwell/expelcss'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 721f01731782c2a9f24b13d358a77b784f15cf6b [INFO] sha for GitHub repo jhartwell/expelcss: 721f01731782c2a9f24b13d358a77b784f15cf6b [INFO] validating manifest of jhartwell/expelcss on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jhartwell/expelcss on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jhartwell/expelcss [INFO] finished frobbing jhartwell/expelcss [INFO] frobbed toml for jhartwell/expelcss written to work/ex/clippy-test-run/sources/stable/gh/jhartwell/expelcss/Cargo.toml [INFO] started frobbing jhartwell/expelcss [INFO] finished frobbing jhartwell/expelcss [INFO] frobbed toml for jhartwell/expelcss written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhartwell/expelcss/Cargo.toml [INFO] crate jhartwell/expelcss has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jhartwell/expelcss against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jhartwell/expelcss:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 368c39bfe38479b46947c262fe7e42e51318db557a5d657b61298fa63420a606 [INFO] running `"docker" "start" "-a" "368c39bfe38479b46947c262fe7e42e51318db557a5d657b61298fa63420a606"` [INFO] [stderr] Checking ecss v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return end + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `end + 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return end + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `end + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return end + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `end + 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return end + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `end + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/html.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | i = match &contents[i..next] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `start_quotes` is assigned to, but never used [INFO] [stderr] --> src/html.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | let mut start_quotes = false; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_start_quotes` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `start_quotes` is never read [INFO] [stderr] --> src/html.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | start_quotes = true; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `start_quotes` is assigned to, but never used [INFO] [stderr] --> src/html.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | let mut start_quotes = false; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_start_quotes` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `start_quotes` is never read [INFO] [stderr] --> src/html.rs:166:29 [INFO] [stderr] | [INFO] [stderr] 166 | start_quotes = true; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/html.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | i = match &contents[i..next] { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/html.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | i = match &contents[i..next] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `start_quotes` is assigned to, but never used [INFO] [stderr] --> src/html.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | let mut start_quotes = false; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_start_quotes` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `start_quotes` is never read [INFO] [stderr] --> src/html.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | start_quotes = true; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `start_quotes` is assigned to, but never used [INFO] [stderr] --> src/html.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | let mut start_quotes = false; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_start_quotes` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `start_quotes` is never read [INFO] [stderr] --> src/html.rs:166:29 [INFO] [stderr] | [INFO] [stderr] 166 | start_quotes = true; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/html.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | i = match &contents[i..next] { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/html.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new<'a>(file_name: &'a str) -> Css { [INFO] [stderr] 12 | | Css { [INFO] [stderr] 13 | | file_name: file_name.to_string(), [INFO] [stderr] 14 | | classes: vec![], [INFO] [stderr] 15 | | ids: vec![], [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/html.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new<'a>(file_name: &'a str) -> Css { [INFO] [stderr] 12 | | Css { [INFO] [stderr] 13 | | file_name: file_name.to_string(), [INFO] [stderr] 14 | | classes: vec![], [INFO] [stderr] 15 | | ids: vec![], [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/html.rs:187:41 [INFO] [stderr] | [INFO] [stderr] 187 | while let Some(class) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for class in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/html.rs:187:41 [INFO] [stderr] | [INFO] [stderr] 187 | while let Some(class) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for class in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "368c39bfe38479b46947c262fe7e42e51318db557a5d657b61298fa63420a606"` [INFO] running `"docker" "rm" "-f" "368c39bfe38479b46947c262fe7e42e51318db557a5d657b61298fa63420a606"` [INFO] [stdout] 368c39bfe38479b46947c262fe7e42e51318db557a5d657b61298fa63420a606