[INFO] updating cached repository jeorb/icfp2006 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeorb/icfp2006 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeorb/icfp2006" "work/ex/clippy-test-run/sources/stable/gh/jeorb/icfp2006"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeorb/icfp2006'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeorb/icfp2006" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeorb/icfp2006"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeorb/icfp2006'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d5dce52c26800e02857ae5f260791fef6450b46 [INFO] sha for GitHub repo jeorb/icfp2006: 1d5dce52c26800e02857ae5f260791fef6450b46 [INFO] validating manifest of jeorb/icfp2006 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeorb/icfp2006 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeorb/icfp2006 [INFO] finished frobbing jeorb/icfp2006 [INFO] frobbed toml for jeorb/icfp2006 written to work/ex/clippy-test-run/sources/stable/gh/jeorb/icfp2006/Cargo.toml [INFO] started frobbing jeorb/icfp2006 [INFO] finished frobbing jeorb/icfp2006 [INFO] frobbed toml for jeorb/icfp2006 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeorb/icfp2006/Cargo.toml [INFO] crate jeorb/icfp2006 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeorb/icfp2006 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeorb/icfp2006:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9805f3e14a12813292360e68a16018ff4f54f1bf770baff8722e0fc910477b62 [INFO] running `"docker" "start" "-a" "9805f3e14a12813292360e68a16018ff4f54f1bf770baff8722e0fc910477b62"` [INFO] [stderr] Checking icfp2006 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let c = (platter & 0b111) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let c = (platter & 0b111) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:141:42 [INFO] [stderr] | [INFO] [stderr] 141 | registers[a] = platter & 0b11111111_11111111_11111111_1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1_1111_1111_1111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:141:42 [INFO] [stderr] | [INFO] [stderr] 141 | registers[a] = platter & 0b11111111_11111111_11111111_1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1_1111_1111_1111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dump_file` is never read [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut dump_file = "".to_owned(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | = ((scroll[i] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | + ((scroll[i+1] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | + ((scroll[i+2] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:15 [INFO] [stderr] | [INFO] [stderr] 49 | + (scroll[i+3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | registers[a] = ((registers[b] as u64) + (registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[b])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:57 [INFO] [stderr] | [INFO] [stderr] 82 | registers[a] = ((registers[b] as u64) + (registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[c])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:34 [INFO] [stderr] | [INFO] [stderr] 86 | registers[a] = ((registers[b] as u64 * registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[b])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | registers[a] = ((registers[b] as u64 * registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[c])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:103:20 [INFO] [stderr] | [INFO] [stderr] 103 | if pointers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pointers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | dump.write(&[registers[c] as u8]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:32 [INFO] [stderr] | [INFO] [stderr] 128 | registers[c] = input as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `icfp2006`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: value assigned to `dump_file` is never read [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut dump_file = "".to_owned(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | = ((scroll[i] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | + ((scroll[i+1] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | + ((scroll[i+2] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:15 [INFO] [stderr] | [INFO] [stderr] 49 | + (scroll[i+3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(scroll[i+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | registers[a] = ((registers[b] as u64) + (registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[b])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:57 [INFO] [stderr] | [INFO] [stderr] 82 | registers[a] = ((registers[b] as u64) + (registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[c])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:34 [INFO] [stderr] | [INFO] [stderr] 86 | registers[a] = ((registers[b] as u64 * registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[b])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | registers[a] = ((registers[b] as u64 * registers[c] as u64) % MAX) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(registers[c])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:103:20 [INFO] [stderr] | [INFO] [stderr] 103 | if pointers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pointers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | dump.write(&[registers[c] as u8]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:32 [INFO] [stderr] | [INFO] [stderr] 128 | registers[c] = input as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `icfp2006`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9805f3e14a12813292360e68a16018ff4f54f1bf770baff8722e0fc910477b62"` [INFO] running `"docker" "rm" "-f" "9805f3e14a12813292360e68a16018ff4f54f1bf770baff8722e0fc910477b62"` [INFO] [stdout] 9805f3e14a12813292360e68a16018ff4f54f1bf770baff8722e0fc910477b62