[INFO] updating cached repository jeffbarg/Tic-Tac-Toe
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jeffbarg/Tic-Tac-Toe
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jeffbarg/Tic-Tac-Toe" "work/ex/clippy-test-run/sources/stable/gh/jeffbarg/Tic-Tac-Toe"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeffbarg/Tic-Tac-Toe'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jeffbarg/Tic-Tac-Toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffbarg/Tic-Tac-Toe"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffbarg/Tic-Tac-Toe'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 714977b9cc98f048477218fcb6e9dd6e9eedfd21
[INFO] sha for GitHub repo jeffbarg/Tic-Tac-Toe: 714977b9cc98f048477218fcb6e9dd6e9eedfd21
[INFO] validating manifest of jeffbarg/Tic-Tac-Toe on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jeffbarg/Tic-Tac-Toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jeffbarg/Tic-Tac-Toe
[INFO] finished frobbing jeffbarg/Tic-Tac-Toe
[INFO] frobbed toml for jeffbarg/Tic-Tac-Toe written to work/ex/clippy-test-run/sources/stable/gh/jeffbarg/Tic-Tac-Toe/Cargo.toml
[INFO] started frobbing jeffbarg/Tic-Tac-Toe
[INFO] finished frobbing jeffbarg/Tic-Tac-Toe
[INFO] frobbed toml for jeffbarg/Tic-Tac-Toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffbarg/Tic-Tac-Toe/Cargo.toml
[INFO] crate jeffbarg/Tic-Tac-Toe has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jeffbarg/Tic-Tac-Toe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffbarg/Tic-Tac-Toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb42106b3a03547ec861932c6a50d63f5d441a5ab82f7a55209f91e2da39ef7b
[INFO] running `"docker" "start" "-a" "cb42106b3a03547ec861932c6a50d63f5d441a5ab82f7a55209f91e2da39ef7b"`
[INFO] [stderr]     Checking tic_tac_toe v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     return Board {
[INFO] [stderr] 16 | |       layout: [
[INFO] [stderr] 17 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 18 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 19 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank]
[INFO] [stderr] 20 | |       ]
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 15 |     Board {
[INFO] [stderr] 16 |       layout: [
[INFO] [stderr] 17 |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 18 |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 19 |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank]
[INFO] [stderr] 20 |       ]
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 | /     if p1 == BoardPiece::X {
[INFO] [stderr] 57 | |       if p2 == BoardPiece::X {
[INFO] [stderr] 58 | |         if p3 == BoardPiece::X {
[INFO] [stderr] 59 | |           return true;
[INFO] [stderr] 60 | |         }
[INFO] [stderr] 61 | |       }
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 56 |     if p1 == BoardPiece::X && p2 == BoardPiece::X {
[INFO] [stderr] 57 |   if p3 == BoardPiece::X {
[INFO] [stderr] 58 |     return true;
[INFO] [stderr] 59 |   }
[INFO] [stderr] 60 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:57:7
[INFO] [stderr]    |
[INFO] [stderr] 57 | /       if p2 == BoardPiece::X {
[INFO] [stderr] 58 | |         if p3 == BoardPiece::X {
[INFO] [stderr] 59 | |           return true;
[INFO] [stderr] 60 | |         }
[INFO] [stderr] 61 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 57 |       if p2 == BoardPiece::X && p3 == BoardPiece::X {
[INFO] [stderr] 58 |   return true;
[INFO] [stderr] 59 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 | /     if p1 == BoardPiece::O {
[INFO] [stderr] 65 | |       if p2 == BoardPiece::O {
[INFO] [stderr] 66 | |         if p3 == BoardPiece::O {
[INFO] [stderr] 67 | |           return true;
[INFO] [stderr] 68 | |         }
[INFO] [stderr] 69 | |       }
[INFO] [stderr] 70 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if p1 == BoardPiece::O && p2 == BoardPiece::O {
[INFO] [stderr] 65 |   if p3 == BoardPiece::O {
[INFO] [stderr] 66 |     return true;
[INFO] [stderr] 67 |   }
[INFO] [stderr] 68 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 | /       if p2 == BoardPiece::O {
[INFO] [stderr] 66 | |         if p3 == BoardPiece::O {
[INFO] [stderr] 67 | |           return true;
[INFO] [stderr] 68 | |         }
[INFO] [stderr] 69 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 65 |       if p2 == BoardPiece::O && p3 == BoardPiece::O {
[INFO] [stderr] 66 |   return true;
[INFO] [stderr] 67 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/lib.rs:74:23
[INFO] [stderr]    |
[INFO] [stderr] 74 |   pub fn print(&self) -> () {
[INFO] [stderr]    |                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     return Board {
[INFO] [stderr] 16 | |       layout: [
[INFO] [stderr] 17 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 18 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 19 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank]
[INFO] [stderr] 20 | |       ]
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 15 |     Board {
[INFO] [stderr] 16 |       layout: [
[INFO] [stderr] 17 |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 18 |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] 19 |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank]
[INFO] [stderr] 20 |       ]
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 | /     if p1 == BoardPiece::X {
[INFO] [stderr] 57 | |       if p2 == BoardPiece::X {
[INFO] [stderr] 58 | |         if p3 == BoardPiece::X {
[INFO] [stderr] 59 | |           return true;
[INFO] [stderr] 60 | |         }
[INFO] [stderr] 61 | |       }
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 56 |     if p1 == BoardPiece::X && p2 == BoardPiece::X {
[INFO] [stderr] 57 |   if p3 == BoardPiece::X {
[INFO] [stderr] 58 |     return true;
[INFO] [stderr] 59 |   }
[INFO] [stderr] 60 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:57:7
[INFO] [stderr]    |
[INFO] [stderr] 57 | /       if p2 == BoardPiece::X {
[INFO] [stderr] 58 | |         if p3 == BoardPiece::X {
[INFO] [stderr] 59 | |           return true;
[INFO] [stderr] 60 | |         }
[INFO] [stderr] 61 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 57 |       if p2 == BoardPiece::X && p3 == BoardPiece::X {
[INFO] [stderr] 58 |   return true;
[INFO] [stderr] 59 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 | /     if p1 == BoardPiece::O {
[INFO] [stderr] 65 | |       if p2 == BoardPiece::O {
[INFO] [stderr] 66 | |         if p3 == BoardPiece::O {
[INFO] [stderr] 67 | |           return true;
[INFO] [stderr] 68 | |         }
[INFO] [stderr] 69 | |       }
[INFO] [stderr] 70 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if p1 == BoardPiece::O && p2 == BoardPiece::O {
[INFO] [stderr] 65 |   if p3 == BoardPiece::O {
[INFO] [stderr] 66 |     return true;
[INFO] [stderr] 67 |   }
[INFO] [stderr] 68 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 | /       if p2 == BoardPiece::O {
[INFO] [stderr] 66 | |         if p3 == BoardPiece::O {
[INFO] [stderr] 67 | |           return true;
[INFO] [stderr] 68 | |         }
[INFO] [stderr] 69 | |       }
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 65 |       if p2 == BoardPiece::O && p3 == BoardPiece::O {
[INFO] [stderr] 66 |   return true;
[INFO] [stderr] 67 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/lib.rs:74:23
[INFO] [stderr]    |
[INFO] [stderr] 74 |   pub fn print(&self) -> () {
[INFO] [stderr]    |                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Board`
[INFO] [stderr]   --> src/lib.rs:14:3
[INFO] [stderr]    |
[INFO] [stderr] 14 | /   pub fn new() -> Board {
[INFO] [stderr] 15 | |     return Board {
[INFO] [stderr] 16 | |       layout: [
[INFO] [stderr] 17 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] ...  |
[INFO] [stderr] 21 | |     }
[INFO] [stderr] 22 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for Board {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Board`
[INFO] [stderr]   --> src/lib.rs:14:3
[INFO] [stderr]    |
[INFO] [stderr] 14 | /   pub fn new() -> Board {
[INFO] [stderr] 15 | |     return Board {
[INFO] [stderr] 16 | |       layout: [
[INFO] [stderr] 17 | |         [BoardPiece::Blank, BoardPiece::Blank, BoardPiece::Blank],
[INFO] [stderr] ...  |
[INFO] [stderr] 21 | |     }
[INFO] [stderr] 22 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for Board {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 | /   return match row.trim().parse() {
[INFO] [stderr] 57 | |     Ok(expr) if expr < 4 && expr > 0 => Ok(expr),
[INFO] [stderr] 58 | |     Ok(_) => { 
[INFO] [stderr] 59 | |       Err(String::from("Please type a number between 1 and 3"))
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |     }
[INFO] [stderr] 64 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 56 |   match row.trim().parse() {
[INFO] [stderr] 57 |     Ok(expr) if expr < 4 && expr > 0 => Ok(expr),
[INFO] [stderr] 58 |     Ok(_) => { 
[INFO] [stderr] 59 |       Err(String::from("Please type a number between 1 and 3"))
[INFO] [stderr] 60 |     }
[INFO] [stderr] 61 |     Err(_) => { 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 | /   return match row.trim().parse() {
[INFO] [stderr] 57 | |     Ok(expr) if expr < 4 && expr > 0 => Ok(expr),
[INFO] [stderr] 58 | |     Ok(_) => { 
[INFO] [stderr] 59 | |       Err(String::from("Please type a number between 1 and 3"))
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |     }
[INFO] [stderr] 64 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 56 |   match row.trim().parse() {
[INFO] [stderr] 57 |     Ok(expr) if expr < 4 && expr > 0 => Ok(expr),
[INFO] [stderr] 58 |     Ok(_) => { 
[INFO] [stderr] 59 |       Err(String::from("Please type a number between 1 and 3"))
[INFO] [stderr] 60 |     }
[INFO] [stderr] 61 |     Err(_) => { 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.06s
[INFO] running `"docker" "inspect" "cb42106b3a03547ec861932c6a50d63f5d441a5ab82f7a55209f91e2da39ef7b"`
[INFO] running `"docker" "rm" "-f" "cb42106b3a03547ec861932c6a50d63f5d441a5ab82f7a55209f91e2da39ef7b"`
[INFO] [stdout] cb42106b3a03547ec861932c6a50d63f5d441a5ab82f7a55209f91e2da39ef7b