[INFO] updating cached repository jdumont0201/rust-neural-network [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jdumont0201/rust-neural-network [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jdumont0201/rust-neural-network" "work/ex/clippy-test-run/sources/stable/gh/jdumont0201/rust-neural-network"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdumont0201/rust-neural-network'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jdumont0201/rust-neural-network" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdumont0201/rust-neural-network"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdumont0201/rust-neural-network'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c23fa61b5dfc4a54a307054cfca542d09db9eb4 [INFO] sha for GitHub repo jdumont0201/rust-neural-network: 3c23fa61b5dfc4a54a307054cfca542d09db9eb4 [INFO] validating manifest of jdumont0201/rust-neural-network on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jdumont0201/rust-neural-network on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jdumont0201/rust-neural-network [INFO] finished frobbing jdumont0201/rust-neural-network [INFO] frobbed toml for jdumont0201/rust-neural-network written to work/ex/clippy-test-run/sources/stable/gh/jdumont0201/rust-neural-network/Cargo.toml [INFO] started frobbing jdumont0201/rust-neural-network [INFO] finished frobbing jdumont0201/rust-neural-network [INFO] frobbed toml for jdumont0201/rust-neural-network written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdumont0201/rust-neural-network/Cargo.toml [INFO] crate jdumont0201/rust-neural-network has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jdumont0201/rust-neural-network against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdumont0201/rust-neural-network:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28611010e748cb926346b148d4cdef22d90e09bab312ad6b0796d57d81133dde [INFO] running `"docker" "start" "-a" "28611010e748cb926346b148d4cdef22d90e09bab312ad6b0796d57d81133dde"` [INFO] [stderr] Checking neuralnetwork v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/neuron/mod.rs:26:79 [INFO] [stderr] | [INFO] [stderr] 26 | println!(" L{}-N{}-I{} compute {} ", self.layer_id, self.id, 0, input.val); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/mod.rs:16:103 [INFO] [stderr] | [INFO] [stderr] 16 | self.neurons.push(Neuron { layer_id:self.id,id:i,is_bias: false, connections: Vec::new(), is_initial: is_initial, output: 0., transfer_function_type:TransferFunctionTypes::LINEAR,gradient:0.}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_initial` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/mod.rs:19:98 [INFO] [stderr] | [INFO] [stderr] 19 | self.neurons.push(Neuron { id:n,layer_id:self.id,is_bias: true, connections: Vec::new(), is_initial: is_initial, output: 0., transfer_function_type:TransferFunctionTypes::LINEAR,gradient:0. }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/topology/mod.rs:60:75 [INFO] [stderr] | [INFO] [stderr] 60 | let mut l: Layer = Layer { id: layer_id, neurons: Vec::new(), is_initial: is_initial }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/topology/mod.rs:133:93 [INFO] [stderr] | [INFO] [stderr] 133 | println!(" L{}-N{}-I{} compute: output={} ", n.layer_id, n.id, 0, val); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/neuron/mod.rs:26:79 [INFO] [stderr] | [INFO] [stderr] 26 | println!(" L{}-N{}-I{} compute {} ", self.layer_id, self.id, 0, input.val); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/mod.rs:16:103 [INFO] [stderr] | [INFO] [stderr] 16 | self.neurons.push(Neuron { layer_id:self.id,id:i,is_bias: false, connections: Vec::new(), is_initial: is_initial, output: 0., transfer_function_type:TransferFunctionTypes::LINEAR,gradient:0.}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_initial` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/mod.rs:19:98 [INFO] [stderr] | [INFO] [stderr] 19 | self.neurons.push(Neuron { id:n,layer_id:self.id,is_bias: true, connections: Vec::new(), is_initial: is_initial, output: 0., transfer_function_type:TransferFunctionTypes::LINEAR,gradient:0. }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/topology/mod.rs:60:75 [INFO] [stderr] | [INFO] [stderr] 60 | let mut l: Layer = Layer { id: layer_id, neurons: Vec::new(), is_initial: is_initial }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/topology/mod.rs:133:93 [INFO] [stderr] | [INFO] [stderr] 133 | println!(" L{}-N{}-I{} compute: output={} ", n.layer_id, n.id, 0, val); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/utils/mod.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | _=>{val } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/neuron/mod.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for (idx, n) in T.layers[self.layer_id + 1].neurons.iter().enumerate() { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `compute_output` [INFO] [stderr] --> src/neuron/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn compute_output(&mut self, L: &Layer) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sum_of_DOW` [INFO] [stderr] --> src/neuron/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn sum_of_DOW(&self, T: &Topology) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `compute_outputs` [INFO] [stderr] --> src/layer/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn compute_outputs(&mut self,prev:&Layer) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/topology/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn get(&self, layer_nb: usize, neuron_nb: usize) -> Option<&Neuron> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut` [INFO] [stderr] --> src/topology/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn get_mut(&mut self, layer_nb: usize, neuron_nb: usize) -> Option<&Neuron> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `compute_errors` [INFO] [stderr] --> src/topology/mod.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn compute_errors(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BINARY` [INFO] [stderr] --> src/utils/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | BINARY, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EXPONENTIAL` [INFO] [stderr] --> src/utils/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | EXPONENTIAL, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TANH` [INFO] [stderr] --> src/utils/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | TANH [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/neuron/mod.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn compute_output(&mut self, L: &Layer) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/neuron/mod.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self.is_initial { [INFO] [stderr] 23 | | true => { [INFO] [stderr] 24 | | //initial layer neuron are just sending their input [INFO] [stderr] 25 | | let input = &self.connections[0];//initial layer neurons are single input [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if self.is_initial { [INFO] [stderr] 23 | //initial layer neuron are just sending their input [INFO] [stderr] 24 | let input = &self.connections[0];//initial layer neurons are single input [INFO] [stderr] 25 | println!(" L{}-N{}-I{} compute {} ", self.layer_id, self.id, 0, input.val); [INFO] [stderr] 26 | self.output = input.val;//T.get(input.layer,input.neuron).in [INFO] [stderr] 27 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/neuron/mod.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | res = res + input.val * input.weight; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res += input.val * input.weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method `sum_of_DOW` should have a snake case name such as `sum_of_dow` [INFO] [stderr] --> src/neuron/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn sum_of_DOW(&self, T: &Topology) -> f64 { [INFO] [stderr] 50 | | //assert not last layer [INFO] [stderr] 51 | | assert!(self.layer_id != T.layers.len()); [INFO] [stderr] 52 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | sum [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: variable `T` should have a snake case name such as `t` [INFO] [stderr] --> src/neuron/mod.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn sum_of_DOW(&self, T: &Topology) -> f64 { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/neuron/mod.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | sum = sum + input.weight * T.layers[input.layer].neurons[input.neuron].gradient; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += input.weight * T.layers[input.layer].neurons[input.neuron].gradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `T` should have a snake case name such as `t` [INFO] [stderr] --> src/topology/mod.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn create_neurons(&mut self, T: Vec) { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | layer_id = layer_id + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `layer_id += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/topology/mod.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let L = &mut self.layers; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `I` should have a snake case name such as `i` [INFO] [stderr] --> src/topology/mod.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | let mut I = Vec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `I` should have a snake case name such as `i` [INFO] [stderr] --> src/topology/mod.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | let mut I = Vec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/topology/mod.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let L = &self.layers; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is used to index `L` [INFO] [stderr] --> src/topology/mod.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | for l in 0..L.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (l, ) in L.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/topology/mod.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | let L = self.layers.get(layer_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.layers[layer_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/topology/mod.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | let L = self.layers.get(layer_id).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/topology/mod.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | / match n.is_initial { [INFO] [stderr] 128 | | //distinguish initial layer [INFO] [stderr] 129 | | true => { [INFO] [stderr] 130 | | //initial layer neuron are just sending their input [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 127 | if n.is_initial { [INFO] [stderr] 128 | //initial layer neuron are just sending their input [INFO] [stderr] 129 | let connection = &n.connections[0];//initial layer neurons are single input [INFO] [stderr] 130 | let val = connection.val; [INFO] [stderr] 131 | println!(" L{}-N{}-I{} compute: output={} ", n.layer_id, n.id, 0, val); [INFO] [stderr] 132 | outputs.push(val); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:143:33 [INFO] [stderr] | [INFO] [stderr] 143 | res = res + val; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `res += val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/topology/mod.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | let mut LL = self.layers.get_mut(layer_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.layers[layer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: variable `LL` should have a snake case name such as `ll` [INFO] [stderr] --> src/topology/mod.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | let mut LL = self.layers.get_mut(layer_id).unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | error = error + delta * delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error += delta * delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name such as `n` [INFO] [stderr] --> src/topology/mod.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | let N = self.layers.last().unwrap().neurons.len() as f64; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | error = error / N; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `error /= N` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/utils/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match type_{ [INFO] [stderr] 10 | | &TransferFunctionTypes::LINEAR => { transfer_function_linear(val) } [INFO] [stderr] 11 | | &TransferFunctionTypes::BINARY => { transfer_function_binary(val) } [INFO] [stderr] 12 | | &TransferFunctionTypes::EXPONENTIAL => { transfer_function_exp(val) } [INFO] [stderr] 13 | | &TransferFunctionTypes::TANH => { transfer_function_tanh(val) } [INFO] [stderr] 14 | | _=>{val } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *type_{ [INFO] [stderr] 10 | TransferFunctionTypes::LINEAR => { transfer_function_linear(val) } [INFO] [stderr] 11 | TransferFunctionTypes::BINARY => { transfer_function_binary(val) } [INFO] [stderr] 12 | TransferFunctionTypes::EXPONENTIAL => { transfer_function_exp(val) } [INFO] [stderr] 13 | TransferFunctionTypes::TANH => { transfer_function_tanh(val) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `T` should have a snake case name such as `t` [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let mut T: Topology = Topology { layers: Vec::new(),targets:Vec::new(),error:1. }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/utils/mod.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | _=>{val } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/neuron/mod.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for (idx, n) in T.layers[self.layer_id + 1].neurons.iter().enumerate() { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `compute_output` [INFO] [stderr] --> src/neuron/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn compute_output(&mut self, L: &Layer) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sum_of_DOW` [INFO] [stderr] --> src/neuron/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn sum_of_DOW(&self, T: &Topology) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `compute_outputs` [INFO] [stderr] --> src/layer/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn compute_outputs(&mut self,prev:&Layer) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/topology/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn get(&self, layer_nb: usize, neuron_nb: usize) -> Option<&Neuron> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut` [INFO] [stderr] --> src/topology/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn get_mut(&mut self, layer_nb: usize, neuron_nb: usize) -> Option<&Neuron> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `compute_errors` [INFO] [stderr] --> src/topology/mod.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn compute_errors(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BINARY` [INFO] [stderr] --> src/utils/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | BINARY, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EXPONENTIAL` [INFO] [stderr] --> src/utils/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | EXPONENTIAL, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TANH` [INFO] [stderr] --> src/utils/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | TANH [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/neuron/mod.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn compute_output(&mut self, L: &Layer) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/neuron/mod.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self.is_initial { [INFO] [stderr] 23 | | true => { [INFO] [stderr] 24 | | //initial layer neuron are just sending their input [INFO] [stderr] 25 | | let input = &self.connections[0];//initial layer neurons are single input [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if self.is_initial { [INFO] [stderr] 23 | //initial layer neuron are just sending their input [INFO] [stderr] 24 | let input = &self.connections[0];//initial layer neurons are single input [INFO] [stderr] 25 | println!(" L{}-N{}-I{} compute {} ", self.layer_id, self.id, 0, input.val); [INFO] [stderr] 26 | self.output = input.val;//T.get(input.layer,input.neuron).in [INFO] [stderr] 27 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/neuron/mod.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | res = res + input.val * input.weight; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res += input.val * input.weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method `sum_of_DOW` should have a snake case name such as `sum_of_dow` [INFO] [stderr] --> src/neuron/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn sum_of_DOW(&self, T: &Topology) -> f64 { [INFO] [stderr] 50 | | //assert not last layer [INFO] [stderr] 51 | | assert!(self.layer_id != T.layers.len()); [INFO] [stderr] 52 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | sum [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: variable `T` should have a snake case name such as `t` [INFO] [stderr] --> src/neuron/mod.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn sum_of_DOW(&self, T: &Topology) -> f64 { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/neuron/mod.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | sum = sum + input.weight * T.layers[input.layer].neurons[input.neuron].gradient; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += input.weight * T.layers[input.layer].neurons[input.neuron].gradient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `T` should have a snake case name such as `t` [INFO] [stderr] --> src/topology/mod.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn create_neurons(&mut self, T: Vec) { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | layer_id = layer_id + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `layer_id += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/topology/mod.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let L = &mut self.layers; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `I` should have a snake case name such as `i` [INFO] [stderr] --> src/topology/mod.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | let mut I = Vec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `I` should have a snake case name such as `i` [INFO] [stderr] --> src/topology/mod.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | let mut I = Vec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/topology/mod.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let L = &self.layers; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is used to index `L` [INFO] [stderr] --> src/topology/mod.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | for l in 0..L.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (l, ) in L.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/topology/mod.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | let L = self.layers.get(layer_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.layers[layer_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: variable `L` should have a snake case name such as `l` [INFO] [stderr] --> src/topology/mod.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | let L = self.layers.get(layer_id).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/topology/mod.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | / match n.is_initial { [INFO] [stderr] 128 | | //distinguish initial layer [INFO] [stderr] 129 | | true => { [INFO] [stderr] 130 | | //initial layer neuron are just sending their input [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 127 | if n.is_initial { [INFO] [stderr] 128 | //initial layer neuron are just sending their input [INFO] [stderr] 129 | let connection = &n.connections[0];//initial layer neurons are single input [INFO] [stderr] 130 | let val = connection.val; [INFO] [stderr] 131 | println!(" L{}-N{}-I{} compute: output={} ", n.layer_id, n.id, 0, val); [INFO] [stderr] 132 | outputs.push(val); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:143:33 [INFO] [stderr] | [INFO] [stderr] 143 | res = res + val; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `res += val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/topology/mod.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | let mut LL = self.layers.get_mut(layer_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.layers[layer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: variable `LL` should have a snake case name such as `ll` [INFO] [stderr] --> src/topology/mod.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | let mut LL = self.layers.get_mut(layer_id).unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | error = error + delta * delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error += delta * delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name such as `n` [INFO] [stderr] --> src/topology/mod.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | let N = self.layers.last().unwrap().neurons.len() as f64; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/topology/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | error = error / N; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `error /= N` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/utils/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match type_{ [INFO] [stderr] 10 | | &TransferFunctionTypes::LINEAR => { transfer_function_linear(val) } [INFO] [stderr] 11 | | &TransferFunctionTypes::BINARY => { transfer_function_binary(val) } [INFO] [stderr] 12 | | &TransferFunctionTypes::EXPONENTIAL => { transfer_function_exp(val) } [INFO] [stderr] 13 | | &TransferFunctionTypes::TANH => { transfer_function_tanh(val) } [INFO] [stderr] 14 | | _=>{val } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *type_{ [INFO] [stderr] 10 | TransferFunctionTypes::LINEAR => { transfer_function_linear(val) } [INFO] [stderr] 11 | TransferFunctionTypes::BINARY => { transfer_function_binary(val) } [INFO] [stderr] 12 | TransferFunctionTypes::EXPONENTIAL => { transfer_function_exp(val) } [INFO] [stderr] 13 | TransferFunctionTypes::TANH => { transfer_function_tanh(val) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `T` should have a snake case name such as `t` [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let mut T: Topology = Topology { layers: Vec::new(),targets:Vec::new(),error:1. }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "28611010e748cb926346b148d4cdef22d90e09bab312ad6b0796d57d81133dde"` [INFO] running `"docker" "rm" "-f" "28611010e748cb926346b148d4cdef22d90e09bab312ad6b0796d57d81133dde"` [INFO] [stdout] 28611010e748cb926346b148d4cdef22d90e09bab312ad6b0796d57d81133dde