[INFO] updating cached repository jcswart/fnl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jcswart/fnl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jcswart/fnl" "work/ex/clippy-test-run/sources/stable/gh/jcswart/fnl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jcswart/fnl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jcswart/fnl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jcswart/fnl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jcswart/fnl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b8af4016d3427218f351ae5cc43c05096eae7e18
[INFO] sha for GitHub repo jcswart/fnl: b8af4016d3427218f351ae5cc43c05096eae7e18
[INFO] validating manifest of jcswart/fnl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jcswart/fnl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jcswart/fnl
[INFO] finished frobbing jcswart/fnl
[INFO] frobbed toml for jcswart/fnl written to work/ex/clippy-test-run/sources/stable/gh/jcswart/fnl/Cargo.toml
[INFO] started frobbing jcswart/fnl
[INFO] finished frobbing jcswart/fnl
[INFO] frobbed toml for jcswart/fnl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jcswart/fnl/Cargo.toml
[INFO] crate jcswart/fnl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jcswart/fnl against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jcswart/fnl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6174deb2cfe2e97b85888f7d5bbb653fe7b4f8a73b6d31d6f4f51a2458fa958c
[INFO] running `"docker" "start" "-a" "6174deb2cfe2e97b85888f7d5bbb653fe7b4f8a73b6d31d6f4f51a2458fa958c"`
[INFO] [stderr]     Checking clap v2.29.0
[INFO] [stderr]     Checking fnl v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::env as e`
[INFO] [stderr]  --> src/main.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::env as e;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:34:57
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn print_selected(columns: &Vec<&str>, pieces: &[&str]) -> () {
[INFO] [stderr]    |                                                         ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:48:31
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn print_all(pieces: &[&str]) -> () {
[INFO] [stderr]    |                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::env as e`
[INFO] [stderr]  --> src/main.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::env as e;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:34:57
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn print_selected(columns: &Vec<&str>, pieces: &[&str]) -> () {
[INFO] [stderr]    |                                                         ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:48:31
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn print_all(pieces: &[&str]) -> () {
[INFO] [stderr]    |                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default`
[INFO] [stderr]   --> src/main.rs:16:30
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let columns: Vec<&str> = matches.values_of("columns").unwrap_or(clap::Values::default()).collect();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches.values_of("columns").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:28
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn print_selected(columns: &Vec<&str>, pieces: &[&str]) -> () {
[INFO] [stderr]    |                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default`
[INFO] [stderr]   --> src/main.rs:16:30
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let columns: Vec<&str> = matches.values_of("columns").unwrap_or(clap::Values::default()).collect();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches.values_of("columns").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:28
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn print_selected(columns: &Vec<&str>, pieces: &[&str]) -> () {
[INFO] [stderr]    |                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.52s
[INFO] running `"docker" "inspect" "6174deb2cfe2e97b85888f7d5bbb653fe7b4f8a73b6d31d6f4f51a2458fa958c"`
[INFO] running `"docker" "rm" "-f" "6174deb2cfe2e97b85888f7d5bbb653fe7b4f8a73b6d31d6f4f51a2458fa958c"`
[INFO] [stdout] 6174deb2cfe2e97b85888f7d5bbb653fe7b4f8a73b6d31d6f4f51a2458fa958c