[INFO] updating cached repository jbyte/chip8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jbyte/chip8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jbyte/chip8" "work/ex/clippy-test-run/sources/stable/gh/jbyte/chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jbyte/chip8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jbyte/chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jbyte/chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jbyte/chip8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 26a560fc55c7d5f815923b9628295015f4d0cc47 [INFO] sha for GitHub repo jbyte/chip8: 26a560fc55c7d5f815923b9628295015f4d0cc47 [INFO] validating manifest of jbyte/chip8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jbyte/chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jbyte/chip8 [INFO] finished frobbing jbyte/chip8 [INFO] frobbed toml for jbyte/chip8 written to work/ex/clippy-test-run/sources/stable/gh/jbyte/chip8/Cargo.toml [INFO] started frobbing jbyte/chip8 [INFO] finished frobbing jbyte/chip8 [INFO] frobbed toml for jbyte/chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jbyte/chip8/Cargo.toml [INFO] crate jbyte/chip8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jbyte/chip8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jbyte/chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3cc7dfacf20f0731e182760bd64192e74604ace10503e892cd36f8634bd40d59 [INFO] running `"docker" "start" "-a" "3cc7dfacf20f0731e182760bd64192e74604ace10503e892cd36f8634bd40d59"` [INFO] [stderr] Checking nom v2.2.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/debugger/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | cpu: cpu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/debugger/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | cpu: cpu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cpu/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod cpu; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Cow` [INFO] [stderr] --> src/debugger/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::borrow::Cow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cpu/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod cpu; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Cow` [INFO] [stderr] --> src/debugger/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::borrow::Cow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INTERPRETER_START` [INFO] [stderr] --> src/cpu/cpu.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const INTERPRETER_START: u32 = 0x000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INTERPRETER_END` [INFO] [stderr] --> src/cpu/cpu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const INTERPRETER_END: u32 = 0x1FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INTERPRETER_LENGTH` [INFO] [stderr] --> src/cpu/cpu.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const INTERPRETER_LENGTH: u32 = INTERPRETER_END - INTERPRETER_START; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DATA_END` [INFO] [stderr] --> src/cpu/cpu.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const DATA_END: usize = 0xFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DATA_LENGTH` [INFO] [stderr] --> src/cpu/cpu.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | const DATA_LENGTH: usize = DATA_END - DATA_START; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `FONTSET` [INFO] [stderr] --> src/cpu/cpu.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..FONT_SET_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 87 | for (i, ) in FONTSET.iter().enumerate().take(FONT_SET_LENGTH) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/cpu/cpu.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..FONT_SET_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[FONT_SET_START..(FONT_SET_LENGTH + FONT_SET_START)].clone_from_slice(&FONTSET[..FONT_SET_LENGTH])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/cpu/cpu.rs:92:32 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn load_rom(&mut self, rom: Box<[u8]>) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rom` [INFO] [stderr] --> src/cpu/cpu.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..rom.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in rom.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cpu/cpu.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | stdin().read(&mut c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc+1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:146:60 [INFO] [stderr] | [INFO] [stderr] 146 | self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc+1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:206:41 [INFO] [stderr] | [INFO] [stderr] 206 | self.reg[x as usize] = (self.reg[x as usize] as u16 + nn) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[x as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/cpu.rs:220:25 [INFO] [stderr] | [INFO] [stderr] 220 | self.reg[x as usize] = self.reg[x as usize] & self.reg[y as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg[x as usize] &= self.reg[y as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:227:35 [INFO] [stderr] | [INFO] [stderr] 227 | let tmp = (self.reg[x as usize] as u16) + (self.reg[y as usize] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[x as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:227:67 [INFO] [stderr] | [INFO] [stderr] 227 | let tmp = (self.reg[x as usize] as u16) + (self.reg[y as usize] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[y as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | self.reg[x as usize] = ((r as u16) & nn) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INTERPRETER_START` [INFO] [stderr] --> src/cpu/cpu.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const INTERPRETER_START: u32 = 0x000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INTERPRETER_END` [INFO] [stderr] --> src/cpu/cpu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const INTERPRETER_END: u32 = 0x1FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INTERPRETER_LENGTH` [INFO] [stderr] --> src/cpu/cpu.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const INTERPRETER_LENGTH: u32 = INTERPRETER_END - INTERPRETER_START; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DATA_END` [INFO] [stderr] --> src/cpu/cpu.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const DATA_END: usize = 0xFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DATA_LENGTH` [INFO] [stderr] --> src/cpu/cpu.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | const DATA_LENGTH: usize = DATA_END - DATA_START; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `FONTSET` [INFO] [stderr] --> src/cpu/cpu.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..FONT_SET_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 87 | for (i, ) in FONTSET.iter().enumerate().take(FONT_SET_LENGTH) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/cpu/cpu.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..FONT_SET_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[FONT_SET_START..(FONT_SET_LENGTH + FONT_SET_START)].clone_from_slice(&FONTSET[..FONT_SET_LENGTH])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/cpu/cpu.rs:92:32 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn load_rom(&mut self, rom: Box<[u8]>) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rom` [INFO] [stderr] --> src/cpu/cpu.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..rom.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in rom.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cpu/cpu.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | stdin().read(&mut c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc+1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:146:60 [INFO] [stderr] | [INFO] [stderr] 146 | self.opcode = (self.memory[self.pc] as u16) << 8 | (self.memory[self.pc+1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:206:41 [INFO] [stderr] | [INFO] [stderr] 206 | self.reg[x as usize] = (self.reg[x as usize] as u16 + nn) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[x as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/cpu.rs:220:25 [INFO] [stderr] | [INFO] [stderr] 220 | self.reg[x as usize] = self.reg[x as usize] & self.reg[y as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg[x as usize] &= self.reg[y as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:227:35 [INFO] [stderr] | [INFO] [stderr] 227 | let tmp = (self.reg[x as usize] as u16) + (self.reg[y as usize] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[x as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:227:67 [INFO] [stderr] | [INFO] [stderr] 227 | let tmp = (self.reg[x as usize] as u16) + (self.reg[y as usize] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[y as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | self.reg[x as usize] = ((r as u16) & nn) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.01s [INFO] running `"docker" "inspect" "3cc7dfacf20f0731e182760bd64192e74604ace10503e892cd36f8634bd40d59"` [INFO] running `"docker" "rm" "-f" "3cc7dfacf20f0731e182760bd64192e74604ace10503e892cd36f8634bd40d59"` [INFO] [stdout] 3cc7dfacf20f0731e182760bd64192e74604ace10503e892cd36f8634bd40d59