[INFO] updating cached repository jawline/rust_dns_client
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jawline/rust_dns_client
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jawline/rust_dns_client" "work/ex/clippy-test-run/sources/stable/gh/jawline/rust_dns_client"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jawline/rust_dns_client'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jawline/rust_dns_client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jawline/rust_dns_client"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jawline/rust_dns_client'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d86f63660711439907dc9c38516c33da0cb2d283
[INFO] sha for GitHub repo jawline/rust_dns_client: d86f63660711439907dc9c38516c33da0cb2d283
[INFO] validating manifest of jawline/rust_dns_client on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jawline/rust_dns_client on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jawline/rust_dns_client
[INFO] finished frobbing jawline/rust_dns_client
[INFO] frobbed toml for jawline/rust_dns_client written to work/ex/clippy-test-run/sources/stable/gh/jawline/rust_dns_client/Cargo.toml
[INFO] started frobbing jawline/rust_dns_client
[INFO] finished frobbing jawline/rust_dns_client
[INFO] frobbed toml for jawline/rust_dns_client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jawline/rust_dns_client/Cargo.toml
[INFO] crate jawline/rust_dns_client has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jawline/rust_dns_client against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jawline/rust_dns_client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7668b08181ae641fca8b5674edbc02c4ee1baddaa47f0bf3068c25cfc1dab49d
[INFO] running `"docker" "start" "-a" "7668b08181ae641fca8b5674edbc02c4ee1baddaa47f0bf3068c25cfc1dab49d"`
[INFO] [stderr]     Checking dns_client v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             portions: portions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `portions`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             class_code: class_code
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maker.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             class_code: class_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             ttl: ttl,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             rdlength: rdlength,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rdlength`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             portions: portions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `portions`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             class_code: class_code
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maker.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             class_code: class_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             ttl: ttl,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             rdlength: rdlength,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rdlength`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> src/record.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         "NS" => Some(NS_CODE),
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:12
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset + 1])`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:41
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |                                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let lo = extract_u16(data, offset + 2)? as u32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset + 2)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let hi = (extract_u16(data, offset)? as u32) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         *v = *v | bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: replace it with: `*v |= bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         *v = *v & !bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `*v &= !bit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:75:37
[INFO] [stderr]    |
[INFO] [stderr] 75 |         set_bitfield(&mut data_row, self.opcode as u16, OPCODE_BITS, OPCODE_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.opcode)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:82:37
[INFO] [stderr]    |
[INFO] [stderr] 82 |         set_bitfield(&mut data_row, self.response_code as u16, Z_BITS, Z_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.response_code)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/question.rs:15:31
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for s in domain.split(".") {
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/question.rs:36:22
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for i in 0..bytes.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^ help: try replacing the loop by: `data[current..(bytes.len() + current)].clone_from_slice(&bytes[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> src/record.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         "NS" => Some(NS_CODE),
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:12
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset + 1])`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:41
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |                                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let lo = extract_u16(data, offset + 2)? as u32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset + 2)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let hi = (extract_u16(data, offset)? as u32) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         *v = *v | bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: replace it with: `*v |= bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         *v = *v & !bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `*v &= !bit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:75:37
[INFO] [stderr]    |
[INFO] [stderr] 75 |         set_bitfield(&mut data_row, self.opcode as u16, OPCODE_BITS, OPCODE_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.opcode)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:82:37
[INFO] [stderr]    |
[INFO] [stderr] 82 |         set_bitfield(&mut data_row, self.response_code as u16, Z_BITS, Z_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.response_code)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/question.rs:15:31
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for s in domain.split(".") {
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/question.rs:36:22
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for i in 0..bytes.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^ help: try replacing the loop by: `data[current..(bytes.len() + current)].clone_from_slice(&bytes[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             portions: portions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `portions`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             class_code: class_code
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maker.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             class_code: class_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             ttl: ttl,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             rdlength: rdlength,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rdlength`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             portions: portions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `portions`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/question.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             class_code: class_code
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maker.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             type_code: type_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             class_code: class_code,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             ttl: ttl,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/answer.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             rdlength: rdlength,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rdlength`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> src/record.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         "NS" => Some(NS_CODE),
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `SOA_CODE`
[INFO] [stderr]  --> src/record.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const SOA_CODE: u16 = 0x6;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `WKS_CODE`
[INFO] [stderr]  --> src/record.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const WKS_CODE: u16 = 0xB;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `PTR_CODE`
[INFO] [stderr]  --> src/record.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const PTR_CODE: u16 = 0xC;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `SRV_CODE`
[INFO] [stderr]   --> src/record.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub const SRV_CODE: u16 = 0x21;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `AAAA_CODE`
[INFO] [stderr]   --> src/record.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const AAAA_CODE: u16 = 0x1C;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:12
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset + 1])`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:41
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |                                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let lo = extract_u16(data, offset + 2)? as u32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset + 2)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let hi = (extract_u16(data, offset)? as u32) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         *v = *v | bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: replace it with: `*v |= bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         *v = *v & !bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `*v &= !bit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:75:37
[INFO] [stderr]    |
[INFO] [stderr] 75 |         set_bitfield(&mut data_row, self.opcode as u16, OPCODE_BITS, OPCODE_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.opcode)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:82:37
[INFO] [stderr]    |
[INFO] [stderr] 82 |         set_bitfield(&mut data_row, self.response_code as u16, Z_BITS, Z_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.response_code)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/question.rs:15:31
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for s in domain.split(".") {
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/question.rs:36:22
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for i in 0..bytes.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^ help: try replacing the loop by: `data[current..(bytes.len() + current)].clone_from_slice(&bytes[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> src/record.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         "NS" => Some(NS_CODE),
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `SOA_CODE`
[INFO] [stderr]  --> src/record.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const SOA_CODE: u16 = 0x6;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `WKS_CODE`
[INFO] [stderr]  --> src/record.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const WKS_CODE: u16 = 0xB;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `PTR_CODE`
[INFO] [stderr]  --> src/record.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const PTR_CODE: u16 = 0xC;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `SRV_CODE`
[INFO] [stderr]   --> src/record.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub const SRV_CODE: u16 = 0x21;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `AAAA_CODE`
[INFO] [stderr]   --> src/record.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const AAAA_CODE: u16 = 0x1C;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:12
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset + 1])`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/bits.rs:5:41
[INFO] [stderr]   |
[INFO] [stderr] 5 |         Ok((data[offset + 1] as u16) + ((data[offset] as u16) << 8))
[INFO] [stderr]   |                                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[offset])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let lo = extract_u16(data, offset + 2)? as u32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset + 2)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bits.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let hi = (extract_u16(data, offset)? as u32) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(extract_u16(data, offset)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         *v = *v | bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: replace it with: `*v |= bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bits.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         *v = *v & !bit;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `*v &= !bit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:75:37
[INFO] [stderr]    |
[INFO] [stderr] 75 |         set_bitfield(&mut data_row, self.opcode as u16, OPCODE_BITS, OPCODE_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.opcode)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/header.rs:82:37
[INFO] [stderr]    |
[INFO] [stderr] 82 |         set_bitfield(&mut data_row, self.response_code as u16, Z_BITS, Z_OFFSET);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.response_code)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/question.rs:15:31
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for s in domain.split(".") {
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/question.rs:36:22
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for i in 0..bytes.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^ help: try replacing the loop by: `data[current..(bytes.len() + current)].clone_from_slice(&bytes[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.48s
[INFO] running `"docker" "inspect" "7668b08181ae641fca8b5674edbc02c4ee1baddaa47f0bf3068c25cfc1dab49d"`
[INFO] running `"docker" "rm" "-f" "7668b08181ae641fca8b5674edbc02c4ee1baddaa47f0bf3068c25cfc1dab49d"`
[INFO] [stdout] 7668b08181ae641fca8b5674edbc02c4ee1baddaa47f0bf3068c25cfc1dab49d