[INFO] updating cached repository jamwaffles/SudokuSolver.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamwaffles/SudokuSolver.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/SudokuSolver.rs" "work/ex/clippy-test-run/sources/stable/gh/jamwaffles/SudokuSolver.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamwaffles/SudokuSolver.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/SudokuSolver.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/SudokuSolver.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/SudokuSolver.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0935762e8ab6c025ae83ec1adc4136d3629bba6b [INFO] sha for GitHub repo jamwaffles/SudokuSolver.rs: 0935762e8ab6c025ae83ec1adc4136d3629bba6b [INFO] validating manifest of jamwaffles/SudokuSolver.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamwaffles/SudokuSolver.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamwaffles/SudokuSolver.rs [INFO] finished frobbing jamwaffles/SudokuSolver.rs [INFO] frobbed toml for jamwaffles/SudokuSolver.rs written to work/ex/clippy-test-run/sources/stable/gh/jamwaffles/SudokuSolver.rs/Cargo.toml [INFO] started frobbing jamwaffles/SudokuSolver.rs [INFO] finished frobbing jamwaffles/SudokuSolver.rs [INFO] frobbed toml for jamwaffles/SudokuSolver.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/SudokuSolver.rs/Cargo.toml [INFO] crate jamwaffles/SudokuSolver.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamwaffles/SudokuSolver.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/SudokuSolver.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94167c1bc597a811adb1bcf53ab94a79b869b7de381bc577195109344ca4e2b2 [INFO] running `"docker" "start" "-a" "94167c1bc597a811adb1bcf53ab94a79b869b7de381bc577195109344ca4e2b2"` [INFO] [stderr] Checking SudokuSolver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sudoku/mod.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | if(col == 0) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/sudoku/mod.rs:195:32 [INFO] [stderr] | [INFO] [stderr] 195 | 'columns: for block_y in (top..top + 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/sudoku/mod.rs:196:23 [INFO] [stderr] | [INFO] [stderr] 196 | for block_x in (left..left + 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sudoku/mod.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | if(col == 0) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/sudoku/mod.rs:195:32 [INFO] [stderr] | [INFO] [stderr] 195 | 'columns: for block_y in (top..top + 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/sudoku/mod.rs:196:23 [INFO] [stderr] | [INFO] [stderr] 196 | for block_x in (left..left + 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/sudoku/mod.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | for (row_x, value) in self.board[y].iter().enumerate() { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/sudoku/mod.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | for (col_y, value) in col.iter().enumerate() { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/sudoku/mod.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(input_board: &[ [ u8; 9 ]; 9 ]) -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `SudokuSolver` should have a snake case name such as `sudoku_solver` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | board: input_board.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*input_board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | self.board[top].clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board[top]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:110:4 [INFO] [stderr] | [INFO] [stderr] 110 | self.board[top + 1].clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board[top + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | self.board[top + 2].clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board[top + 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | let mut new_board = self.board.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/sudoku/mod.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | for (row_x, value) in self.board[y].iter().enumerate() { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/sudoku/mod.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | for (col_y, value) in col.iter().enumerate() { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/sudoku/mod.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(input_board: &[ [ u8; 9 ]; 9 ]) -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `SudokuSolver` should have a snake case name such as `sudoku_solver` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | board: input_board.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*input_board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | self.board[top].clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board[top]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:110:4 [INFO] [stderr] | [INFO] [stderr] 110 | self.board[top + 1].clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board[top + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | self.board[top + 2].clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board[top + 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sudoku/mod.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | let mut new_board = self.board.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "94167c1bc597a811adb1bcf53ab94a79b869b7de381bc577195109344ca4e2b2"` [INFO] running `"docker" "rm" "-f" "94167c1bc597a811adb1bcf53ab94a79b869b7de381bc577195109344ca4e2b2"` [INFO] [stdout] 94167c1bc597a811adb1bcf53ab94a79b869b7de381bc577195109344ca4e2b2