[INFO] updating cached repository jamiebrynes7/git-tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamiebrynes7/git-tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamiebrynes7/git-tools" "work/ex/clippy-test-run/sources/stable/gh/jamiebrynes7/git-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamiebrynes7/git-tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamiebrynes7/git-tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiebrynes7/git-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiebrynes7/git-tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34e27dafaf77a05ea058244a21f9f71a1ad20019 [INFO] sha for GitHub repo jamiebrynes7/git-tools: 34e27dafaf77a05ea058244a21f9f71a1ad20019 [INFO] validating manifest of jamiebrynes7/git-tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamiebrynes7/git-tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamiebrynes7/git-tools [INFO] finished frobbing jamiebrynes7/git-tools [INFO] frobbed toml for jamiebrynes7/git-tools written to work/ex/clippy-test-run/sources/stable/gh/jamiebrynes7/git-tools/Cargo.toml [INFO] started frobbing jamiebrynes7/git-tools [INFO] finished frobbing jamiebrynes7/git-tools [INFO] frobbed toml for jamiebrynes7/git-tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiebrynes7/git-tools/Cargo.toml [INFO] crate jamiebrynes7/git-tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamiebrynes7/git-tools against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiebrynes7/git-tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8cb258f1969294c24185858fc0a966649fa712311f8b7a37f51e2fbdcb9ff42 [INFO] running `"docker" "start" "-a" "e8cb258f1969294c24185858fc0a966649fa712311f8b7a37f51e2fbdcb9ff42"` [INFO] [stderr] Checking git-tools v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/commands/branches.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return branch_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `branch_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/commands/prune.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(git_prune_origin_command); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(git_prune_origin_command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/commands/prune.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return branch_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `branch_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/commands/branches.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return branch_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `branch_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/commands/prune.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(git_prune_origin_command); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(git_prune_origin_command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/commands/prune.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return branch_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `branch_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib/commands/branches.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | let list_branches_command = match show_remotes { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 7 | | true => run_git_command(&vec!["branch".to_string(), "-a".to_string()]), [INFO] [stderr] 8 | | false => run_git_command(&vec!["branch".to_string(), "--list".to_string()]), [INFO] [stderr] 9 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if show_remotes { run_git_command(&vec!["branch".to_string(), "-a".to_string()]) } else { run_git_command(&vec!["branch".to_string(), "--list".to_string()]) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/branches.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/commands/branches.rs:32:43 [INFO] [stderr] | [INFO] [stderr] 32 | fn parse_raw_branch_data(raw_branch_data: &Vec, remote_identifier: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib/commands/branches.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | .map(|s| match s.starts_with(remote_identifier) { [INFO] [stderr] | __________________^ [INFO] [stderr] 36 | | true => { [INFO] [stderr] 37 | | let remote_branch_name = s [INFO] [stderr] 38 | | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] ... | [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | }).collect(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 35 | .map(|s| if s.starts_with(remote_identifier) { [INFO] [stderr] 36 | let remote_branch_name = s [INFO] [stderr] 37 | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] 38 | .nth(1) [INFO] [stderr] 39 | .unwrap(); [INFO] [stderr] 40 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/branches.rs:42:55 [INFO] [stderr] | [INFO] [stderr] 42 | let remote = remote_branch_name.split("/").nth(0).unwrap().to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/branches.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | .split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/commands/process.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn run_git_command(args: &Vec) -> ProcessOutput { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib/commands/process.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | .expect(&format!("No error code in command: git {:?}", args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No error code in command: git {:?}", args))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/prune.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/prune.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | .filter(|s| s.contains("*")) [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/prune.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | .map(|s| s.split("]").nth(1).unwrap().to_string()) [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/commands/prune.rs:51:43 [INFO] [stderr] | [INFO] [stderr] 51 | fn parse_raw_branch_data(raw_branch_data: &Vec, remote_identifier: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib/commands/prune.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | .map(|s| match s.starts_with(remote_identifier) { [INFO] [stderr] | __________________^ [INFO] [stderr] 55 | | true => { [INFO] [stderr] 56 | | let branch_name = s [INFO] [stderr] 57 | | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] ... | [INFO] [stderr] 69 | | }, [INFO] [stderr] 70 | | }).collect(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 54 | .map(|s| if s.starts_with(remote_identifier) { [INFO] [stderr] 55 | let branch_name = s [INFO] [stderr] 56 | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] 57 | .nth(1) [INFO] [stderr] 58 | .unwrap(); [INFO] [stderr] 59 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib/commands/branches.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | let list_branches_command = match show_remotes { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 7 | | true => run_git_command(&vec!["branch".to_string(), "-a".to_string()]), [INFO] [stderr] 8 | | false => run_git_command(&vec!["branch".to_string(), "--list".to_string()]), [INFO] [stderr] 9 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if show_remotes { run_git_command(&vec!["branch".to_string(), "-a".to_string()]) } else { run_git_command(&vec!["branch".to_string(), "--list".to_string()]) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/branches.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/commands/branches.rs:32:43 [INFO] [stderr] | [INFO] [stderr] 32 | fn parse_raw_branch_data(raw_branch_data: &Vec, remote_identifier: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib/commands/branches.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | .map(|s| match s.starts_with(remote_identifier) { [INFO] [stderr] | __________________^ [INFO] [stderr] 36 | | true => { [INFO] [stderr] 37 | | let remote_branch_name = s [INFO] [stderr] 38 | | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] ... | [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | }).collect(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 35 | .map(|s| if s.starts_with(remote_identifier) { [INFO] [stderr] 36 | let remote_branch_name = s [INFO] [stderr] 37 | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] 38 | .nth(1) [INFO] [stderr] 39 | .unwrap(); [INFO] [stderr] 40 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/branches.rs:42:55 [INFO] [stderr] | [INFO] [stderr] 42 | let remote = remote_branch_name.split("/").nth(0).unwrap().to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/branches.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | .split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/commands/process.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn run_git_command(args: &Vec) -> ProcessOutput { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib/commands/process.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | .expect(&format!("No error code in command: git {:?}", args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No error code in command: git {:?}", args))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/prune.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/prune.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | .filter(|s| s.contains("*")) [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib/commands/prune.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | .map(|s| s.split("]").nth(1).unwrap().to_string()) [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/commands/prune.rs:51:43 [INFO] [stderr] | [INFO] [stderr] 51 | fn parse_raw_branch_data(raw_branch_data: &Vec, remote_identifier: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib/commands/prune.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | .map(|s| match s.starts_with(remote_identifier) { [INFO] [stderr] | __________________^ [INFO] [stderr] 55 | | true => { [INFO] [stderr] 56 | | let branch_name = s [INFO] [stderr] 57 | | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] ... | [INFO] [stderr] 69 | | }, [INFO] [stderr] 70 | | }).collect(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 54 | .map(|s| if s.starts_with(remote_identifier) { [INFO] [stderr] 55 | let branch_name = s [INFO] [stderr] 56 | .split((remote_identifier.to_string() + "/").as_str()) [INFO] [stderr] 57 | .nth(1) [INFO] [stderr] 58 | .unwrap(); [INFO] [stderr] 59 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/branch_selector.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | show_remotes: show_remotes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_remotes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/branch_selector.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | show_remotes: show_remotes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_remotes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/clean_branches.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return intersection; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `intersection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/clean_branches.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return intersection; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `intersection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/clean_branches.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | if branches_to_delete.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branches_to_delete.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bin/clean_branches.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / match get_user_confirmation(&branches_to_delete, &pruned_branch_list) { [INFO] [stderr] 41 | | true => delete_branches(&branches_to_delete, args.remote_name.clone()), [INFO] [stderr] 42 | | false => println!("Aborting operation!"), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if get_user_confirmation(&branches_to_delete, &pruned_branch_list) { delete_branches(&branches_to_delete, args.remote_name.clone()) } else { println!("Aborting operation!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | remote_branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | local_branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | branches_to_delete: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | remote_branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:108:40 [INFO] [stderr] | [INFO] [stderr] 108 | fn delete_branches(branches_to_delete: &Vec, remote_name: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/clean_branches.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | if branches_to_delete.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branches_to_delete.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bin/clean_branches.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / match get_user_confirmation(&branches_to_delete, &pruned_branch_list) { [INFO] [stderr] 41 | | true => delete_branches(&branches_to_delete, args.remote_name.clone()), [INFO] [stderr] 42 | | false => println!("Aborting operation!"), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if get_user_confirmation(&branches_to_delete, &pruned_branch_list) { delete_branches(&branches_to_delete, args.remote_name.clone()) } else { println!("Aborting operation!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | remote_branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | local_branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | branches_to_delete: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | remote_branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/clean_branches.rs:108:40 [INFO] [stderr] | [INFO] [stderr] 108 | fn delete_branches(branches_to_delete: &Vec, remote_name: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/branch_selector.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | fn select_branch_index(branches: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/branch_selector.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | fn select_branch_index(branches: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[GitBranch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.67s [INFO] running `"docker" "inspect" "e8cb258f1969294c24185858fc0a966649fa712311f8b7a37f51e2fbdcb9ff42"` [INFO] running `"docker" "rm" "-f" "e8cb258f1969294c24185858fc0a966649fa712311f8b7a37f51e2fbdcb9ff42"` [INFO] [stdout] e8cb258f1969294c24185858fc0a966649fa712311f8b7a37f51e2fbdcb9ff42