[INFO] updating cached repository jamesob/cryptopals-solutions [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamesob/cryptopals-solutions [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamesob/cryptopals-solutions" "work/ex/clippy-test-run/sources/stable/gh/jamesob/cryptopals-solutions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamesob/cryptopals-solutions'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamesob/cryptopals-solutions" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesob/cryptopals-solutions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesob/cryptopals-solutions'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73156ff07f051f659c1c5023d4c8db1180df1bf7 [INFO] sha for GitHub repo jamesob/cryptopals-solutions: 73156ff07f051f659c1c5023d4c8db1180df1bf7 [INFO] validating manifest of jamesob/cryptopals-solutions on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamesob/cryptopals-solutions on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamesob/cryptopals-solutions [INFO] finished frobbing jamesob/cryptopals-solutions [INFO] frobbed toml for jamesob/cryptopals-solutions written to work/ex/clippy-test-run/sources/stable/gh/jamesob/cryptopals-solutions/Cargo.toml [INFO] started frobbing jamesob/cryptopals-solutions [INFO] finished frobbing jamesob/cryptopals-solutions [INFO] frobbed toml for jamesob/cryptopals-solutions written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesob/cryptopals-solutions/Cargo.toml [INFO] crate jamesob/cryptopals-solutions has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamesob/cryptopals-solutions against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesob/cryptopals-solutions:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98fe0ebd34a6d345979d677cf8ea96eeaf5d28345cfb62b561b62785572de20e [INFO] running `"docker" "start" "-a" "98fe0ebd34a6d345979d677cf8ea96eeaf5d28345cfb62b561b62785572de20e"` [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking base64 v0.10.0 [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | Candidate { msg: decoded_msg, score: score, key: i as char } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | Candidate { msg: decoded_msg, score: score, key: i as char } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:82:51 [INFO] [stderr] | [INFO] [stderr] 82 | fn xor_cipher_with_score<'a, I>(iterable: I, key: &u8) -> (String, u32) [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:82:51 [INFO] [stderr] | [INFO] [stderr] 82 | fn xor_cipher_with_score<'a, I>(iterable: I, key: &u8) -> (String, u32) [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.40s [INFO] running `"docker" "inspect" "98fe0ebd34a6d345979d677cf8ea96eeaf5d28345cfb62b561b62785572de20e"` [INFO] running `"docker" "rm" "-f" "98fe0ebd34a6d345979d677cf8ea96eeaf5d28345cfb62b561b62785572de20e"` [INFO] [stdout] 98fe0ebd34a6d345979d677cf8ea96eeaf5d28345cfb62b561b62785572de20e