[INFO] updating cached repository jakubtuchol/ls [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakubtuchol/ls [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakubtuchol/ls" "work/ex/clippy-test-run/sources/stable/gh/jakubtuchol/ls"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakubtuchol/ls'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakubtuchol/ls" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubtuchol/ls"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubtuchol/ls'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 95e0eb13a01dc60298a0e0a6e5281c0f8fff86d6 [INFO] sha for GitHub repo jakubtuchol/ls: 95e0eb13a01dc60298a0e0a6e5281c0f8fff86d6 [INFO] validating manifest of jakubtuchol/ls on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakubtuchol/ls on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakubtuchol/ls [INFO] finished frobbing jakubtuchol/ls [INFO] frobbed toml for jakubtuchol/ls written to work/ex/clippy-test-run/sources/stable/gh/jakubtuchol/ls/Cargo.toml [INFO] started frobbing jakubtuchol/ls [INFO] finished frobbing jakubtuchol/ls [INFO] frobbed toml for jakubtuchol/ls written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubtuchol/ls/Cargo.toml [INFO] crate jakubtuchol/ls has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakubtuchol/ls against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubtuchol/ls:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0409ad8023c811410442521952016bfd666f54d52d93373e39549d20eb1a6862 [INFO] running `"docker" "start" "-a" "0409ad8023c811410442521952016bfd666f54d52d93373e39549d20eb1a6862"` [INFO] [stderr] Checking ls v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unix_impl.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return File { [INFO] [stderr] 24 | | s_name: OsString::from(dir_entry.path()).into_string().unwrap(), [INFO] [stderr] 25 | | u_nlink: metadata.nlink(), [INFO] [stderr] 26 | | u_rwx: metadata.permissions().mode(), [INFO] [stderr] ... | [INFO] [stderr] 31 | | b_is_file: metadata.is_file() [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | File { [INFO] [stderr] 24 | s_name: OsString::from(dir_entry.path()).into_string().unwrap(), [INFO] [stderr] 25 | u_nlink: metadata.nlink(), [INFO] [stderr] 26 | u_rwx: metadata.permissions().mode(), [INFO] [stderr] 27 | u_userid: metadata.uid(), [INFO] [stderr] 28 | u_groupid: metadata.gid(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unix_impl.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(contents)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/unix_impl.rs:126:40 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn print_dir(contents: &Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unix_impl.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return File { [INFO] [stderr] 24 | | s_name: OsString::from(dir_entry.path()).into_string().unwrap(), [INFO] [stderr] 25 | | u_nlink: metadata.nlink(), [INFO] [stderr] 26 | | u_rwx: metadata.permissions().mode(), [INFO] [stderr] ... | [INFO] [stderr] 31 | | b_is_file: metadata.is_file() [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | File { [INFO] [stderr] 24 | s_name: OsString::from(dir_entry.path()).into_string().unwrap(), [INFO] [stderr] 25 | u_nlink: metadata.nlink(), [INFO] [stderr] 26 | u_rwx: metadata.permissions().mode(), [INFO] [stderr] 27 | u_userid: metadata.uid(), [INFO] [stderr] 28 | u_groupid: metadata.gid(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unix_impl.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | return Ok(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(contents)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/unix_impl.rs:126:40 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn print_dir(contents: &Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/unix_impl.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn print_dir(contents: &Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/unix_impl.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn print_dir(contents: &Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `"docker" "inspect" "0409ad8023c811410442521952016bfd666f54d52d93373e39549d20eb1a6862"` [INFO] running `"docker" "rm" "-f" "0409ad8023c811410442521952016bfd666f54d52d93373e39549d20eb1a6862"` [INFO] [stdout] 0409ad8023c811410442521952016bfd666f54d52d93373e39549d20eb1a6862