[INFO] updating cached repository jakobbeckmann/algos
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jakobbeckmann/algos
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jakobbeckmann/algos" "work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/algos"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/algos'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jakobbeckmann/algos" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/algos"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/algos'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 25079d05980a19b0762500073b52a9599c40baaf
[INFO] sha for GitHub repo jakobbeckmann/algos: 25079d05980a19b0762500073b52a9599c40baaf
[INFO] validating manifest of jakobbeckmann/algos on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jakobbeckmann/algos on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jakobbeckmann/algos
[INFO] finished frobbing jakobbeckmann/algos
[INFO] frobbed toml for jakobbeckmann/algos written to work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/algos/Cargo.toml
[INFO] started frobbing jakobbeckmann/algos
[INFO] finished frobbing jakobbeckmann/algos
[INFO] frobbed toml for jakobbeckmann/algos written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/algos/Cargo.toml
[INFO] crate jakobbeckmann/algos has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jakobbeckmann/algos against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/algos:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 026372f5a32e69b1a821f40b2dac1d03a60250eaf4ef2f67dcfd3eeac9eeb0b0
[INFO] running `"docker" "start" "-a" "026372f5a32e69b1a821f40b2dac1d03a60250eaf4ef2f67dcfd3eeac9eeb0b0"`
[INFO] [stderr]     Checking algos v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/genetic.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         return pop[i].clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pop[i].clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/genetic.rs:136:9
[INFO] [stderr]     |
[INFO] [stderr] 136 |         return pop[j].clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pop[j].clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/genetic.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         return pop[i].clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pop[i].clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/genetic.rs:136:9
[INFO] [stderr]     |
[INFO] [stderr] 136 |         return pop[j].clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pop[j].clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/genetic.rs:125:27
[INFO] [stderr]     |
[INFO] [stderr] 125 | fn binary_tournament(pop: &Vec<(String, usize)>) -> (String, usize) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, usize)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/genetic.rs:151:25
[INFO] [stderr]     |
[INFO] [stderr] 151 |             let mut t = String::from(s);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/genetic.rs:155:25
[INFO] [stderr]     |
[INFO] [stderr] 155 |             let mut t = String::from(s);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is only used to index `b`.
[INFO] [stderr]   --> src/merge_sort.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for k in begin..end {
[INFO] [stderr]    |              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for <item> in b.iter_mut().take(end).skip(begin) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/genetic.rs:125:27
[INFO] [stderr]     |
[INFO] [stderr] 125 | fn binary_tournament(pop: &Vec<(String, usize)>) -> (String, usize) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, usize)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/genetic.rs:151:25
[INFO] [stderr]     |
[INFO] [stderr] 151 |             let mut t = String::from(s);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/genetic.rs:155:25
[INFO] [stderr]     |
[INFO] [stderr] 155 |             let mut t = String::from(s);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is only used to index `b`.
[INFO] [stderr]   --> src/merge_sort.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for k in begin..end {
[INFO] [stderr]    |              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 28 |     for <item> in b.iter_mut().take(end).skip(begin) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.95s
[INFO] running `"docker" "inspect" "026372f5a32e69b1a821f40b2dac1d03a60250eaf4ef2f67dcfd3eeac9eeb0b0"`
[INFO] running `"docker" "rm" "-f" "026372f5a32e69b1a821f40b2dac1d03a60250eaf4ef2f67dcfd3eeac9eeb0b0"`
[INFO] [stdout] 026372f5a32e69b1a821f40b2dac1d03a60250eaf4ef2f67dcfd3eeac9eeb0b0