[INFO] updating cached repository jagg/zen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jagg/zen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jagg/zen" "work/ex/clippy-test-run/sources/stable/gh/jagg/zen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jagg/zen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jagg/zen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jagg/zen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jagg/zen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e4c66681d636de37508509c5b6134353202b0ed7 [INFO] sha for GitHub repo jagg/zen: e4c66681d636de37508509c5b6134353202b0ed7 [INFO] validating manifest of jagg/zen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jagg/zen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jagg/zen [INFO] finished frobbing jagg/zen [INFO] frobbed toml for jagg/zen written to work/ex/clippy-test-run/sources/stable/gh/jagg/zen/Cargo.toml [INFO] started frobbing jagg/zen [INFO] finished frobbing jagg/zen [INFO] frobbed toml for jagg/zen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jagg/zen/Cargo.toml [INFO] crate jagg/zen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jagg/zen against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jagg/zen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6cf998d770f20e564d22cea8edfc24c0b4e90541c630e3c118ff69b0d1af27d9 [INFO] running `"docker" "start" "-a" "6cf998d770f20e564d22cea8edfc24c0b4e90541c630e3c118ff69b0d1af27d9"` [INFO] [stderr] Checking zen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | KeyReader {recv: recv} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `recv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/terminal.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | print!("{} x {}\r\n", cols, rows); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terminal.rs:25:64 [INFO] [stderr] | [INFO] [stderr] 25 | Terminal { termios_c: unsafe { mem::uninitialized() }, cols: cols, rows: rows } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terminal.rs:25:76 [INFO] [stderr] | [INFO] [stderr] 25 | Terminal { termios_c: unsafe { mem::uninitialized() }, cols: cols, rows: rows } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | KeyReader {recv: recv} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `recv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/terminal.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | print!("{} x {}\r\n", cols, rows); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terminal.rs:25:64 [INFO] [stderr] | [INFO] [stderr] 25 | Terminal { termios_c: unsafe { mem::uninitialized() }, cols: cols, rows: rows } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terminal.rs:25:76 [INFO] [stderr] | [INFO] [stderr] 25 | Terminal { termios_c: unsafe { mem::uninitialized() }, cols: cols, rows: rows } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/keys.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/keys.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/keys.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/keys.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `terminal::Terminal` [INFO] [stderr] --> src/terminal.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | let (cols, rows) = get_window_size().unwrap(); [INFO] [stderr] 24 | | print!("{} x {}\r\n", cols, rows); [INFO] [stderr] 25 | | Terminal { termios_c: unsafe { mem::uninitialized() }, cols: cols, rows: rows } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for terminal::Terminal { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | raw.c_lflag = raw.c_lflag & !(libc::ECHO | libc::ICANON | libc::ISIG | libc::IEXTEN); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw.c_lflag &= !(libc::ECHO | libc::ICANON | libc::ISIG | libc::IEXTEN)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / raw.c_iflag = raw.c_iflag & [INFO] [stderr] 36 | | !(libc::IXON | libc::ICRNL | libc::BRKINT | libc::INPCK | libc::ISTRIP); [INFO] [stderr] | |_________________________________________________________________________________________________^ help: replace it with: `raw.c_iflag &= !(libc::IXON | libc::ICRNL | libc::BRKINT | libc::INPCK | libc::ISTRIP)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | raw.c_oflag = raw.c_oflag & !(libc::OPOST); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw.c_oflag &= !(libc::OPOST)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | raw.c_cflag = raw.c_cflag & !(libc::CS8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw.c_cflag &= !(libc::CS8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `terminal::Terminal` [INFO] [stderr] --> src/terminal.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | let (cols, rows) = get_window_size().unwrap(); [INFO] [stderr] 24 | | print!("{} x {}\r\n", cols, rows); [INFO] [stderr] 25 | | Terminal { termios_c: unsafe { mem::uninitialized() }, cols: cols, rows: rows } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for terminal::Terminal { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | raw.c_lflag = raw.c_lflag & !(libc::ECHO | libc::ICANON | libc::ISIG | libc::IEXTEN); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw.c_lflag &= !(libc::ECHO | libc::ICANON | libc::ISIG | libc::IEXTEN)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / raw.c_iflag = raw.c_iflag & [INFO] [stderr] 36 | | !(libc::IXON | libc::ICRNL | libc::BRKINT | libc::INPCK | libc::ISTRIP); [INFO] [stderr] | |_________________________________________________________________________________________________^ help: replace it with: `raw.c_iflag &= !(libc::IXON | libc::ICRNL | libc::BRKINT | libc::INPCK | libc::ISTRIP)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | raw.c_oflag = raw.c_oflag & !(libc::OPOST); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw.c_oflag &= !(libc::OPOST)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/terminal.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | raw.c_cflag = raw.c_cflag & !(libc::CS8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw.c_cflag &= !(libc::CS8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | / match parse_key(buf[0]) { [INFO] [stderr] 40 | | Key::Ctrl('q') => break, [INFO] [stderr] 41 | | //Key::Char(ch) => print!("{:?}\r\n", ch), [INFO] [stderr] 42 | | _ => (), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Key::Ctrl('q') = parse_key(buf[0]) { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | / match parse_key(buf[0]) { [INFO] [stderr] 40 | | Key::Ctrl('q') => break, [INFO] [stderr] 41 | | //Key::Char(ch) => print!("{:?}\r\n", ch), [INFO] [stderr] 42 | | _ => (), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Key::Ctrl('q') = parse_key(buf[0]) { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.71s [INFO] running `"docker" "inspect" "6cf998d770f20e564d22cea8edfc24c0b4e90541c630e3c118ff69b0d1af27d9"` [INFO] running `"docker" "rm" "-f" "6cf998d770f20e564d22cea8edfc24c0b4e90541c630e3c118ff69b0d1af27d9"` [INFO] [stdout] 6cf998d770f20e564d22cea8edfc24c0b4e90541c630e3c118ff69b0d1af27d9